[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Nick Clemens changed: What|Removed |Added Blocks||24244 Referenced Bugs:

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #56 from Jonathan Druart --- However bug 22905 is still valid, the suggestion will not be accepted. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #55 from Jonathan Druart --- (In reply to Jonathan Druart from comment #54) > I think I have a blocker for 19.05, see bug 22905. > > suggestions.branchcode may be set to __ANY__ prior to this patch, and so the >

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Jonathan Druart changed: What|Removed |Added Blocks||22905 Referenced Bugs:

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #54 from Jonathan Druart --- I think I have a blocker for 19.05, see bug 22905. suggestions.branchcode may be set to __ANY__ prior to this patch, and so the constraint will not be created. -- You are receiving this

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #53 from Katrin Fischer --- *** Bug 22758 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Katrin Fischer changed: What|Removed |Added CC||vasant...@infoplus.co.in

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master ---

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #49 from Jonathan Druart --- Created attachment 85754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85754=edit Bug 22368: Make sure the tests will always pass Who knows! Signed-off-by: Jonathan

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #48 from Kyle M Hall --- Created attachment 85747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85747=edit Bug 22368: (QA follow-up) Changed to LEFT JOIN as requested Signed-off-by: Martin Renvoize

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #46 from Kyle M Hall --- Created attachment 85745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85745=edit Bug 22368: (QA follow-up) Missing comma in kohastructure.sql Signed-off-by: Martin Renvoize

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #47 from Kyle M Hall --- Created attachment 85746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85746=edit Bug 22368: (QA follow-up) Switch to using foreign_key_exists Signed-off-by: Martin Renvoize

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #45 from Kyle M Hall --- Created attachment 85744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85744=edit Bug 22368: (QA follow-up) Mute db errors in test Signed-off-by: Josef Moravec

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #44 from Kyle M Hall --- Created attachment 85743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85743=edit Bug 22368: Add missing constraints to `suggestions` Signed-off-by: Mark Tompsett

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Kyle M Hall changed: What|Removed |Added Attachment #85739|0 |1 is obsolete|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Kyle M Hall changed: What|Removed |Added Attachment #85723|0 |1 is obsolete|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85609|0 |1 is obsolete|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #41 from Martin Renvoize --- Created attachment 85729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85729=edit Bug 22368: (QA follow-up) Changed to LEFT JOIN as requested Signed-off-by: Martin

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85608|0 |1 is obsolete|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85610|0 |1 is obsolete|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85612|0 |1 is obsolete|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85611|0 |1 is obsolete|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added CC||gmcha...@gmail.com --

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Keywords||Academy Patch

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85378|0 |1 is obsolete|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85379|0 |1 is obsolete|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85377|0 |1 is obsolete|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #35 from Martin Renvoize --- Created attachment 85612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85612=edit Bug 22368: (QA follow-up) Switch to using foreign_key_exists Signed-off-by: Martin

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85388|0 |1 is obsolete|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #30 from Josef Moravec --- (In reply to Katrin Fischer from comment #28) > (In reply to Martin Renvoize from comment #27) > > (In reply to Jonathan Druart from comment #24) > > > Regarding C4::Biblio::DelBiblio,

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #29 from Josef Moravec --- (In reply to Martin Renvoize from comment #26) > (In reply to Jonathan Druart from comment #23) > > NOT IN could (must?) be replaced with LEFT JOIN table SET attr_a = NULL > > WHERE attr_b IS

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #28 from Katrin Fischer --- (In reply to Martin Renvoize from comment #27) > (In reply to Jonathan Druart from comment #24) > > Regarding C4::Biblio::DelBiblio, suggestions_ibfk_biblionumber should ON > > DELETE CASCADE

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #27 from Martin Renvoize --- (In reply to Jonathan Druart from comment #24) > Regarding C4::Biblio::DelBiblio, suggestions_ibfk_biblionumber should ON > DELETE CASCADE (instead of SET NULL). > Same for

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #26 from Martin Renvoize --- (In reply to Jonathan Druart from comment #23) > NOT IN could (must?) be replaced with LEFT JOIN table SET attr_a = NULL > WHERE attr_b IS NULL Personally, I always find the NOT IN clearer

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #25 from Martin Renvoize --- (In reply to Jonathan Druart from comment #22) > C4::Installer::foreign_key_exists should be used here. Happy to use this, though I used bug 21065 as an example.. do we need to fixup that

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #22 from Jonathan Druart --- C4::Installer::foreign_key_exists should be used here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Marjorie Barry-Vila changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #23 from Jonathan Druart --- NOT IN could (must?) be replaced with LEFT JOIN table SET attr_a = NULL WHERE attr_b IS NULL -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Blocks||5334 Referenced Bugs:

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #20 from Martin Renvoize --- Hehe, well, one extra and one missing.  It's so easy to make such a mistake in kohastructure during rebase.. I may try and write a test to catch such mistakes.. though that's for another

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #19 from M. Tompsett --- Comment on attachment 85388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85388 Bug 22368: (QA follow-up) Missing comma in kohastructure.sql Review of attachment 85388: -->

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Keywords|Academy | -- You are receiving

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Keywords||Academy -- You are

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #18 from Martin Renvoize --- Madly enough.. I just found a typo in the second patch so I've fixed it with the QA follow-up.. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #17 from Martin Renvoize --- Created attachment 85388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85388=edit Bug 22368: (QA follow-up) Missing comma in kohastructure.sql Signed-off-by: Martin

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #15 from Martin Renvoize --- *** Bug 13533 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #16 from Martin Renvoize --- Awesome, thanks for the followup.. I'll bank that one for next time :). -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #13 from Josef Moravec --- Created attachment 85378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85378=edit Bug 22368: Add missing constraints to `suggestions` Signed-off-by: Mark Tompsett

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #14 from Josef Moravec --- Created attachment 85379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85379=edit Bug 22368: (QA follow-up) Mute db errors in test Signed-off-by: Josef Moravec -- You

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Josef Moravec changed: What|Removed |Added Attachment #85309|0 |1 is obsolete|

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #11 from Martin Renvoize --- OK, I have no idea how to quiet those warnings.. perhaps a friendly QA person might add a QA followup and teach me how to do it ? -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Christopher Brannon changed: What|Removed |Added CC|cbran...@cdalibrary.org | -- You are

[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de