[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Philip Orr changed: What|Removed |Added Status|Needs documenting |RESOLVED

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Philip Orr changed: What|Removed |Added CC||philip@lmscloud.de

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Fridolin Somers changed: What|Removed |Added Blocks||35389 Referenced Bugs:

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #77 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #76) > I found this report after breaking my head about how to add transfers > without a date sent ;) Added two reports to lower possible confusion.

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #76 from Marcel de Rooy --- I found this report after breaking my head about how to add transfers without a date sent ;) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #75 from Katrin Fischer --- (In reply to mathieu saby from comment #74) > Hi > > I don't find a description of this feature in Koha Manual. Is it described > somewhere? It still has the keyword Manual, so it might not

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com ---

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Blocks|25753 |22160 Referenced Bugs:

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Blocks|22160 | Referenced Bugs:

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #72 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #71 from Katrin Fischer --- I think we should use this report to advertise on the hard work that has gone into cleaning up the transfers code that has led up to here :) -- You are receiving this mail because: You are

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Attachment #117848|0 |1 is obsolete|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Attachment #117847|0 |1 is obsolete|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Attachment #117613|0 |1 is obsolete|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Attachment #117612|0 |1 is obsolete|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #117843|0 |1 is obsolete|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #117842|0 |1 is obsolete|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #64 from Katrin Fischer --- I think you fell of IRC, so asking here: I am happy with the translations patch now, but can you explain how Hold lost can come to be? If I mark an item lost... how can it be in transfer? --

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #117841|0 |1 is obsolete|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #117840|0 |1 is obsolete|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #61 from Martin Renvoize --- Created attachment 117841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117841=edit Bug 22569: (QA follow-up) Use itemtype description -- You are receiving this mail

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #60 from Martin Renvoize --- Created attachment 117840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117840=edit Bug 22569: (QA follow-up) Make 'reason' translatable -- You are receiving this mail

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #59

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #58 from Katrin Fischer --- 1) I notice that the reason in the table appears to be taken directly from the database. "AdvanceStockRotation" is not easy to understand untranslated. Can you please deal with this in the

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Text to go in the||This enhancement adds a

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Keywords||Manual Text to go in

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement adds a

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #57 from Jonathan Druart --- Created attachment 117613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117613=edit Bug 22569: Add Unit Tests Test plan: 1/ Run the updated unit tests Signed-off-by:

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Jonathan Druart changed: What|Removed |Added Attachment #116572|0 |1 is obsolete|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #55 from Martin Renvoize --- Thanks for clarifying.. couldn't see the wood for the trees.. Followups pushed to branch to deal with both issues :) -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #54 from Jonathan Druart --- (In reply to Martin Renvoize from comment #53) > (In reply to Jonathan Druart from comment #46) > > 7. There are some indentation inconsistencies in circ/transferstosend.tt > > Not sure

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #53 from Martin Renvoize --- (In reply to Jonathan Druart from comment #46) > 5. in circ/transferstosend.pl > +show_date=> output_pref( > > +{ dt =>

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #52 from Martin Renvoize --- Updated the branch attached to the merge request here: https://gitlab.com/mrenvoize/Koha/-/merge_requests/1 -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #51 from Martin Renvoize --- (In reply to Jonathan Druart from comment #44) > Is this store call needed? > > +$self->stage_id($new_stage->stage_id)->store;# Revert > stage change > > There are also

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #50 from Martin Renvoize --- (In reply to Jonathan Druart from comment #45) > Shouldn't we start with a good script/template name? > transferstosend.pl => transfers_to_send.pl More than happy for that change.. I was

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #49 from Martin Renvoize --- (In reply to Jonathan Druart from comment #46) > 3. Shouldn't Koha::Exceptions::Item::Transfer::Found be actually > Koha::Exceptions::Item::Transfer::AlreadyInTransfer, to be more explicit? >

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #48 from Martin Renvoize --- (In reply to Jonathan Druart from comment #46) > 2. > -my ($datesent,$frombranch,$tobranch) = GetTransfers( $item->itemnumber > ); > +my $transfer = $item->get_transfer; > > This

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #47 from Martin Renvoize --- (In reply to Jonathan Druart from comment #46) > Adding here some notes about the dependent tree (I've squashed the whole > tree for pre-review): > > 1. > -

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #46 from Jonathan Druart --- Adding here some notes about the dependent tree (I've squashed the whole tree for pre-review): 1. -$messages->{'WasTransfered'} = 1; +$messages->{'WasTransfered'} = $tbr;

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #45 from Jonathan Druart --- Shouldn't we start with a good script/template name? transferstosend.pl => transfers_to_send.pl -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #44 from Jonathan Druart --- Is this store call needed? +$self->stage_id($new_stage->stage_id)->store;# Revert stage change There are also several places in the tests where ->store calls are

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Patch complexity|Large patch |Small patch -- You are

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #43 from Martin Renvoize --- Created attachment 116573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116573=edit Bug 22569: Add Unit Tests Test plan: 1/ Run the updated unit tests Signed-off-by:

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #42 from Martin Renvoize --- Created attachment 116572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116572=edit Bug 22569: Add a 'Transfers to send' report This patch adds a 'Transfers to send'

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #41

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Patch complexity|Small patch |Large patch -- You are

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #40 from Martin Renvoize --- I'm looking for feedback for this tree on https://gitlab.com/mrenvoize/Koha/-/merge_requests/1 -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Blocks||25753 Referenced Bugs:

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Depends on|25753 |26618 Referenced Bugs:

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Depends on||25753 Referenced Bugs:

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Depends on|26618 | Referenced Bugs:

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #39 from Martin Renvoize --- OK.. pretty much the entire tree beneath this has now been tested and either already QA'd or SO'd in isolation, but it's time to QA the whole patchset. I've set all preceeding bugs to

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #110543|0 |1 is obsolete|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #110544|0 |1 is obsolete|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added URL|

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Summary|Stock rotation: 'Transfers |Add a 'Transfers to send'