https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #23 from Agustín Moyano ---
(In reply to Bernardo Gonzalez Kriegel from comment #22)
> Question: Why 'inscripts' instead of 'incipits'?
> I'm referring to the name of the preference and the displayed text.
>
> Came to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Martin Renvoize changed:
What|Removed |Added
Text to go in the||This development adds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Martin Renvoize changed:
What|Removed |Added
Keywords|rel_19_11_candidate |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #21 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Martin Renvoize changed:
What|Removed |Added
Version(s)||19.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #20 from Katrin Fischer ---
Tiny thing: Play this sample - the space might get lost
with the translation tools.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #19 from Katrin Fischer ---
We might to improve the display later slightly - maybe move it further up, move
the link closer to the written music, include a label.. but works for now
nicely and is an optional feature.
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #18 from Katrin Fischer ---
The written music is very pretty. How is the code in 031 generated? (out of
interest) Passing QA on this one.
Do we need to add something to the about page for the new JavaScript libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #17 from Katrin Fischer ---
Created attachment 94952
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94952=edit
Bug 22581: Add new system preferences
This patch adds 2 new system preferences:
1.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Katrin Fischer changed:
What|Removed |Added
Attachment #94856|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #16 from Katrin Fischer ---
Having a go here.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #14 from Agustín Moyano ---
I've updated the commits in gitlab, with Owen Leonard's code and suggestion
(Thanks Owen!)
I didn't realize that the midi player didn't play nice if multiple 031 were
present.
Thanks again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #13 from Agustín Moyano ---
(In reply to Martin Renvoize from comment #12)
> Minor QA comments.
Hi Martin, I'll reply your comments
> * We appear to load the verovio css regardless of the syspref settings
Yes, I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #12 from Martin Renvoize ---
Minor QA comments.
* We appear to load the verovio css regardless of the syspref settings
* I think we seem to load the midi player JS even if we're only interested in
displaying the musical
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #11 from Martin Renvoize ---
So far so good, I've left a comment about using `Koha.Preference(` in the
templates as an alterative to adding preference called inside the controller.
I'll continue to test here.. going to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #10 from Agustín Moyano ---
(In reply to Katrin Fischer from comment #8)
> Could you add a sample record or an example on how to catalog this?
I'll paste the comment on the second commit (that I couldn't upload):
This
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #9 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #8)
> Could you add a sample record or an example on how to catalog this?
I saw the commit on the branch has an example.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #7 from Agustín Moyano ---
Library with piano data is too big to be attached, please apply patches from
https://gitlab.com/thekesolutions/Koha/tree/bug-22581
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Agustín Moyano changed:
What|Removed |Added
Attachment #94855|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #5 from Agustín Moyano ---
Created attachment 94855
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94855=edit
Bug 22581: Add new system preferences
This patch adds 2 new system preferences:
1.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Agustín Moyano changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Tomás Cohen Arazi changed:
What|Removed |Added
Summary|Add support for Plaine &|Add support for Plaine
29 matches
Mail list logo
