[Koha-bugs] [Bug 22644] Some tests in Upload.t are not testing the right thing

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644 --- Comment #6 from Marcel de Rooy --- The test reflects the history of Upload to Uploader and UploadedFile(s) with Koha::Object(s). I think we should put the Uploader stuff into its own test Uploader.t. And put all Koha objects

[Koha-bugs] [Bug 22644] Some tests in Upload.t are not testing the right thing

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644 --- Comment #5 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #4) > Marcel, what do you think? How could I provide tests for bug 22508 without > having this being fixed? Any ideas? Will have a look very soon. --

[Koha-bugs] [Bug 22644] Some tests in Upload.t are not testing the right thing

2019-05-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644 --- Comment #4 from Jonathan Druart --- Marcel, what do you think? How could I provide tests for bug 22508 without having this being fixed? Any ideas? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22644] Some tests in Upload.t are not testing the right thing

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644 --- Comment #3 from Jonathan Druart --- 162 my $delete = Koha::UploadedFiles->search({ id => $id })->delete; 163 isnt( $delete, "0E0", 'Delete successful' ); 164 isnt( -e $path, 1, 'File no longer found after delete' );

[Koha-bugs] [Bug 22644] Some tests in Upload.t are not testing the right thing

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 22644] Some tests in Upload.t are not testing the right thing

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644 Jonathan Druart changed: What|Removed |Added Blocks||22508 Referenced Bugs:

[Koha-bugs] [Bug 22644] Some tests in Upload.t are not testing the right thing

2019-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 22644] Some tests in Upload.t are not testing the right thing

2019-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644 --- Comment #1 from Jonathan Druart --- Created attachment 87429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87429=edit Bug 22644: Highlight the problem -- You are receiving this mail because: You are