https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Niamh Walker-Headon changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #199 from Andrew Isherwood ---
Thanks for that fix Jonathan! I actually had 4 parameters when I tested the
upgrade, then just prior to committing I removed the last one thinking its
absence would infer undef, I didn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #198 from Jonathan Druart
---
(In reply to Didier Gautheron from comment #197)
> Update datanase isn't working for me
>
> DBI last_insert_id: invalid number of arguments: got handle + 3, expected
> handle + between 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Didier Gautheron changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #195 from Jonathan Druart
---
Created attachment 113584
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113584=edit
Bug 22818: Fix the last_insert_id call
DBI last_insert_id: invalid number of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #196 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #194)
> Same, I can't recreate anymore, weird! Will see later if it popups.
>
> Last patch pushed to master.
Patch pushed to master.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Jonathan Druart changed:
What|Removed |Added
Keywords|additional_work_needed |
--- Comment #194 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #193 from Andrew Isherwood ---
Arghhh, I missed that you'd run 3 lots of tests there. Anyway, I just tried
that, and still can't replicate it:
root@kohadevbox:koha(master)$ prove t/db_dependent/Circulation.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #192 from Jonathan Druart
---
(In reply to Andrew Isherwood from comment #191)
> (In reply to Jonathan Druart from comment #188)
> > 3. t/db_dependent/Illrequests.t is passing but, only when run once:
>
> I can't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #191 from Andrew Isherwood ---
(In reply to Jonathan Druart from comment #188)
Hi Jonathan
> 1. Fix the checkbox wording
Done
> 2. $dbh->{mysql_insertid}; in the upgrade process should be replaced. It's a
> MySQLism
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #190 from Andrew Isherwood ---
Created attachment 113549
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113549=edit
Bug 22818: (QA follow-up) Respond to feedback
This commit addresses the requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Jonathan Druart changed:
What|Removed |Added
Attachment #113479|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #189 from Jonathan Druart
---
Created attachment 113522
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113522=edit
Bug 22818: Fix TestBuilder.t
t/db_dependent/TestBuilder.t .. 12/13
# Failed test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Jonathan Druart changed:
What|Removed |Added
Keywords|release-notes-needed|additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #187 from Jonathan Druart
---
Pushed to master for 20.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #186 from Katrin Fischer ---
> >
> > Ah! Suggestions: We change the wording on the log viewer to read: "ILL
> > notice sent to patron" and create a new bug report for widening the support
> > of this?
>
> I understood
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #185 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #184)
> > We prefer "library" over "branch"
> > https://wiki.koha-community.org/wiki/Terminology
> >
> > > > 2. PATRON_NOTICE is (so far) only for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #184 from Katrin Fischer ---
> We prefer "library" over "branch"
> https://wiki.koha-community.org/wiki/Terminology
>
> > > 2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it
> > > explicit on the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #183 from Tomás Cohen Arazi ---
Hi, I suggest the new column for branches is called 'ill_email', and please add
it to the api/v1/definitions/library.json object definition.
If you prefer to keep the current name for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #182 from Jonathan Druart
---
(In reply to Andrew Isherwood from comment #180)
> (In reply to Jonathan Druart from comment #162)
> > Those changes are not expected:
> >
> > -my $library =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #181 from Katrin Fischer ---
(In reply to Andrew Isherwood from comment #180)
> (In reply to Jonathan Druart from comment #162)
> > Those changes are not expected:
> >
> > -my $library =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #180 from Andrew Isherwood ---
(In reply to Jonathan Druart from comment #162)
> Those changes are not expected:
>
> -my $library = Koha::Libraries->find($params->{current_branchcode})
> +my $branch =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113411|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113413|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #179 from Andrew Isherwood ---
Created attachment 113479
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113479=edit
Bug 22818: (follow-up) "use" correct class
Following up on the feedback from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #175 from Andrew Isherwood ---
Created attachment 113475
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113475=edit
Bug 22818: (follow-up) Respond to feedback
This commit implements the feedback from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113412|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113409|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113408|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113407|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113404|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113406|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113405|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113403|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113402|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113400|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113401|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113399|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #113398|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #162 from Jonathan Druart
---
Only found minor things so far.
1.
Those changes are not expected:
-my $library = Koha::Libraries->find($params->{current_branchcode})
+my $branch =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111912|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111913|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Status|Patch doesn't apply |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111911|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111908|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111909|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #157 from Andrew Isherwood ---
Created attachment 113410
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113410=edit
Bug 22818: (follow-up) Respond to feedback
This commit implements the feedback from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111904|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111907|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111906|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111905|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111903|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111897|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111901|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111902|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111900|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111899|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #143 from Andrew Isherwood ---
Hi Katrin
Thanks for the follow ups, they look great. Sorry for missing the Italian file!
Thanks for all your hard work on this, much appreciated!
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #142 from Katrin Fischer ---
Thx for the quick work and great test plan, Andrew. I threw in 3 tiny
follow-ups at the end - hope they are agreeable :)
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #140 from Katrin Fischer ---
Created attachment 111912
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111912=edit
Bug 22818: (QA follow-up) Add some punctuation and terminology fixes to pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #141 from Katrin Fischer ---
Created attachment 111913
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111913=edit
Bug 22818: (QA follow-up) Add hint to new library ILL email setting
Copies the hints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #139 from Katrin Fischer ---
Created attachment 111911
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111911=edit
Bug 22818: (QA follow-up) Add sample ILL notices to it-IT installer
Run: prove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111890|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111889|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111892|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111891|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #138 from Katrin Fischer ---
Created attachment 111910
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111910=edit
Bug 22818: (follow-up) Respond to feedback
This commit implements the feedback from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111888|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111887|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111885|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111886|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111884|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111880|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111881|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Attachment #111883|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #125 from Katrin Fischer ---
Hi Andrew,
5) is fixed for me now.
All others look good too. I am working on some tiny follow-ups. Ready soon.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #124 from Katrin Fischer ---
Back here :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111848|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #122 from Andrew Isherwood ---
Created attachment 111893
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111893=edit
Bug 22818: (follow-up) Respond to feedback
This commit implements the feedback from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111845|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111843|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111847|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111846|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111844|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111842|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111841|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111839|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111840|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111837|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #111838|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #109 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #108)
> Created attachment 111874 [details]
> ILL view in OPAC - button
For 6) Checked with Owen:
Since it's a submit button I'd change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #108 from Katrin Fischer ---
Created attachment 111874
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111874=edit
ILL view in OPAC - button
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #106 from Katrin Fischer ---
Ok, still testing! But it gets a little too much for me to fix myself, so I'll
need follow-ups for:
1) Email issue noted in comment#103
2) Messaging preferences: Hide ILL notices if
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
--- Comment #105 from Katrin Fischer ---
Sadly the ILLModule check on the system preference doesn't work the intended
way. It only removes the labels, the ILL notices still show up as "Unknown". I
think a slightly different
1 - 100 of 227 matches
Mail list logo