[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable ---

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Martin Renvoize changed: What|Removed |Added Version(s)||19.05.00, 18.11.06

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Galen Charlton changed: What|Removed |Added Keywords||regression -- You are

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com ---

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master ---

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 --- Comment #14 from Martin Renvoize --- Created attachment 89740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89740=edit Bug 22899: (QA follow-up) Change accessor name This patch changes pending_hold to

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 --- Comment #13 from Martin Renvoize --- Created attachment 89739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89739=edit Bug 22899: (QA follow-up) Ensure constraint is created Signed-off-by: Martin Renvoize

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Martin Renvoize changed: What|Removed |Added Attachment #89707|0 |1 is obsolete|

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Martin Renvoize changed: What|Removed |Added Attachment #89725|0 |1 is obsolete|

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Martin Renvoize changed: What|Removed |Added Attachment #89708|0 |1 is obsolete|

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 --- Comment #9 from Martin Renvoize --- (In reply to Martin Renvoize from comment #8) > I'm not familiar enough with the logic in this area now I'm afraid... but I > do wonder a few things: > > 1) Should it really be an ON DELETE

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 --- Comment #8 from Martin Renvoize --- I'm not familiar enough with the logic in this area now I'm afraid... but I do wonder a few things: 1) Should it really be an ON DELETE CASCADE.. or should we be setting to NULL or something

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 --- Comment #7 from Martin Renvoize --- Grr.. bit annoyed I missed this whilst QAing bug 15505 :( This patch doesn't feel quit right yet, I agree with Jonathan than the accessor name is misleading especially as it's not only acting

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Hayley Mapley changed: What|Removed |Added Attachment #89709|0 |1 is obsolete|

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 --- Comment #5 from Jonathan Druart --- A couple of small things: 1. The new constraint will not be added if there are itemnumbers in the tmp_holdsqueue that do not exist in items. I know it's unlikely to happen but... who knows?

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Nick Clemens changed: What|Removed |Added Attachment #89706|0 |1 is obsolete|

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 --- Comment #4 from Nick Clemens --- Created attachment 89709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89709=edit Bug 22899: Add pending_hold method to Koha::Item To test: 1 - Enable course reserves 2 -

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 --- Comment #3 from Nick Clemens --- Created attachment 89708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89708=edit Bug 22899: [DO NOT PUSH] Schema updates -- You are receiving this mail because: You are

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Nick Clemens changed: What|Removed |Added Depends on||15505

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 --- Comment #1 from Nick Clemens --- Created attachment 89706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89706=edit Bug 22899: Add pending_hold method to Koha::Item To test: 1 - Enable course reserves 2 -

[Koha-bugs] [Bug 22899] Cannot view course details

2019-05-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22899 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are