[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #52 from Caroline Cyr La Rose --- Here is the insert we did in all our clients' databases `insert into circulation_rules (rule_name, rule_value) values ("processingreturn", 0);` If the rule is not in the

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Blou changed: What|Removed |Added CC||philippe.blo...@inlibro.com ---

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Caroline Cyr La Rose changed: What|Removed |Added Documentation|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Lucas Gass changed: What|Removed |Added Status|Pushed to master|RESOLVED CC|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #49 from Tomás Cohen Arazi --- (In reply to Aleisha Amohia from comment #45) > (In reply to Tomás Cohen Arazi from comment #42) > > This is looking better now. The changes make sense as well. But now > > > >

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #48 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added Keywords|rel_22_05_candidate | -- You are receiving

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply ---

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #45 from Aleisha Amohia --- (In reply to Tomás Cohen Arazi from comment #42) > This is looking better now. The changes make sense as well. But now > > t/db_dependent/Koha/Item.t is failing for me because the third

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What|Removed |Added Attachment #142693|0 |1 is obsolete|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What|Removed |Added Attachment #142652|0 |1 is obsolete|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #41 from Tomás Cohen Arazi --- (In reply to Aleisha Amohia from comment #40) > I believe the latest patch addresses the Circulation.t tests as well. Thank you! Will review tomorrow -- You are receiving this mail

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #40 from Aleisha Amohia --- I believe the latest patch addresses the Circulation.t tests as well. For anyone testing, only the bottom 2 patches need to be applied. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #39 from Aleisha Amohia --- Created attachment 142693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142693=edit Bug 23012: (follow-up) Fix t/db_dependent/Koha/Items.t -- You are receiving this mail

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #38 from Aleisha Amohia --- I will fix this tomorrow! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #37 from Tomás Cohen Arazi --- TL;DR This patch set broke t/db_dependent/Koha/Items.t Please fix it. I blamed the follow-ups, but that was incorrect as far as I can tell. When you fix it, please verify the Circulation*

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #36 from Aleisha Amohia --- Can someone please let me know what work needs to be done here? I wrote the initial patches but I understand the follow-ups caused test failures? A bit hard to follow the commentary :) --

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 142652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142652=edit Bug 23012: Fix t/db_dependent/Koha/Item.t With the follow-up changes, the return

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #34 from Tomás Cohen Arazi --- I'm reverting it tomorrow, if you provide a fix by tomorrow, I won't. It still has the chance to get in either way. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added Attachment #142575|0 |1 is obsolete|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added Version(s)|22.11.00| released in|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added Keywords|additional_work_needed |rel_22_05_candidate

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #32 from Tomás Cohen Arazi --- Hmm, it feels like Nick's follow-up and mine are to blame. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to master|ASSIGNED -- You are

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #30 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 142575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142575=edit Bug 23012: get_lostreturn_policy returns a scalar On commit

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #28 from Nick Clemens --- Created attachment 142487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142487=edit Bug 23012: (QA follow-up) Add exec flag to db update Signed-off-by: Nick Clemens --

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #27 from Nick Clemens --- Created attachment 142486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142486=edit Bug 23012: (QA follow-up) No need to create and delete rules for branch The tests create

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #26 from Nick Clemens --- Created attachment 142485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142485=edit Bug 23012: (QA follow-up) Combine method to get both values The code for

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #25 from Nick Clemens --- Created attachment 142484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142484=edit Bug 23012: Apply processing fee return policy when lost item found This enhancement gives

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #24 from Nick Clemens --- Created attachment 142483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142483=edit Bug 23012: Set policy for lost item processing fee Signed-off-by: David Nind

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #23 from Nick Clemens --- Created attachment 142482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142482=edit Bug 23012: Show the PROCESSING_FOUND account credit type Signed-off-by: David Nind

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Nick Clemens changed: What|Removed |Added Attachment #142123|0 |1 is obsolete|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What|Removed |Added CC||da...@davidnind.com ---

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What|Removed |Added Attachment #142113|0 |1 is obsolete|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What|Removed |Added Attachment #142048|0 |1 is obsolete|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What|Removed |Added Attachment #142047|0 |1 is obsolete|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What|Removed |Added Attachment #142046|0 |1 is obsolete|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What|Removed |Added Text to go in the||This enhancement gives the

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What|Removed |Added Attachment #142049|0 |1 is obsolete|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #15 from Aleisha Amohia --- Created attachment 142049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142049=edit Bug 23012: Apply processing fee return policy when lost item found TEST PLAN TO COME

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What|Removed |Added Attachment #141629|0 |1 is obsolete|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What|Removed |Added Attachment #141628|0 |1 is obsolete|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What|Removed |Added Attachment #141627|0 |1 is obsolete|

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #11 from Aleisha Amohia --- Still working on this, attaching progress here to pick up tomorrow -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #10 from Aleisha Amohia --- Created attachment 141630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141630=edit Bug 23012: [WIP] Mark processing fee as found when lost item found -- You are

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #9 from Aleisha Amohia --- Created attachment 141629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141629=edit Bug 23012: Set policy for lost item processing fee -- You are receiving this mail

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #8 from Aleisha Amohia --- Created attachment 141628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141628=edit Bug 23012: Show the PROCESSING_FOUND account credit type -- You are receiving this mail

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #7 from Aleisha Amohia --- Created attachment 141627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141627=edit Bug 23012: Database updates for PROCESSING_FOUND account credit type -- You are

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Craig Murdoch changed: What|Removed |Added CC||craig.murd...@aut.ac.nz --

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Michael Spagnuolo changed: What|Removed |Added CC||mspagnu...@nrhtx.com

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Todd Goatley changed: What|Removed |Added CC||tgoat...@gmail.com ---

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Sara Brown changed: What|Removed |Added CC||sbr...@bywatersolutions.com

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #1

[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Marjorie Barry-Vila changed: What|Removed |Added CC|