https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Keywords||release-notes-needed
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Joy Nelson changed:
What|Removed |Added
CC||j...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #86 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Attachment #100225|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Attachment #100108|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Attachment #100224|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #85 from Nick Clemens ---
Created attachment 100263
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100263=edit
Bug 23112: (QA follow-up) Clean up tests, catch warnings
Signed-off-by: Nick Clemens
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Attachment #100107|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Attachment #100105|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Attachment #100104|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Attachment #100102|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Attachment #100103|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Attachment #100106|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Attachment #100100|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Attachment #100101|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #100169|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #73 from Andrew Isherwood ---
Created attachment 100225
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100225=edit
Bug 23112: (follow-up) Unit test fixes
As requested by Nick, fixes unit tests and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #72 from Andrew Isherwood ---
Created attachment 100224
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100224=edit
Bug 23112: (follow-up) Conditionally prevent checkout
As mentioned by Nick in comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #71 from Andrew Isherwood ---
Created attachment 100169
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100169=edit
Bug 23051: (follow-up) Conditionally prevent checkout
As mentioned by Nick in comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #70 from Andrew Isherwood ---
Thanks for this Nick, it is much appreciated. Many thanks for the follow up, I
do wish my editor would not randomly switch to tabs sometimes! Good point about
the Checkout button, I'll
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #68 from Nick Clemens ---
Created attachment 100108
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100108=edit
Bug 23112: (QA follow-up) Fix database update, add filters, remove tabs
Looks like the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #66 from Nick Clemens ---
Created attachment 100106
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100106=edit
Bug 23112: (follow-up) Address QA feedback
As per comment #46
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #67 from Nick Clemens ---
Created attachment 100107
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100107=edit
Bug 23112: (follow-up) Fix test as per feedback
As per comment #48
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #64 from Nick Clemens ---
Created attachment 100104
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100104=edit
Bug 23112: Add unit tests
This patch adds unit test for the new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #65 from Nick Clemens ---
Created attachment 100105
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100105=edit
Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues
In response to the problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #61 from Nick Clemens ---
Created attachment 100101
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100101=edit
Bug 23112: Add circulation to ILL requests
This patch adds the ability to circulate ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #63 from Nick Clemens ---
Created attachment 100103
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100103=edit
Bug 23112: Update request status on return
This patch updates a request's status to RET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #62 from Nick Clemens ---
Created attachment 100102
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100102=edit
Bug 23112: Add permission checks
We only want the ILL circulation functionality to be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Nick Clemens changed:
What|Removed |Added
Attachment #99910|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #59 from Andrew Isherwood ---
Needed rebase due to dependent patch in bug 23384 changing
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #96834|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #95567|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #96870|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #95570|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #95568|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #95569|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #95565|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #95566|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #50 from Andrew Isherwood ---
(In reply to Jonathan Druart from comment #48)
> (In reply to Andrew Isherwood from comment #46)
> > > ::: Koha/Illrequest.pm
> > > @@ +1211,5 @@
> > > > +# For some reason, AddIssue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #49 from Andrew Isherwood ---
Created attachment 96870
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96870=edit
Bug 23112: (follow-up) Fix test as per feedback
As per comment #48
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #48 from Jonathan Druart
---
(In reply to Andrew Isherwood from comment #46)
> > ::: Koha/Illrequest.pm
> > @@ +1211,5 @@
> > > +# For some reason, AddIssue requires an unblessed Patron
> > > +
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #46 from Andrew Isherwood ---
(In reply to Jonathan Druart from comment #45)
> Comment on attachment 95566 [details] [review]
> Bug 23112: Add circulation to ILL requests
>
> Review of attachment 95566 [details]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #47 from Andrew Isherwood ---
Created attachment 96834
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96834=edit
Bug 23112: (follow-up) Address QA feedback
As per comment #46
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #45 from Jonathan Druart
---
Comment on attachment 95566
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95566
Bug 23112: Add circulation to ILL requests
Review of attachment 95566:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #94268|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #94267|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #94269|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #94266|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #94264|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #94265|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #93534|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #93958|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #93531|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #93533|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #93530|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #93532|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #32 from Andrew Isherwood ---
Created attachment 93958
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93958=edit
Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues
In response to the problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #31 from Andrew Isherwood ---
Hi Magnus
I just managed to replicate this on one of our test instances which is running
plack, so I'm wondering if it's a plack thing. I've learnt the hard way not to
try and understand
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Magnus Enger changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #29
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #28 from Magnus Enger ---
Thanks for fixing the number the applicability!
Sorry, I get an error on step 5: "Create a new FreeForm request":
Template process failed: undef error - Undefined subroutine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #27 from Andrew Isherwood ---
Thanks for that Magnus, the bug number is now fixed, as it the failure to apply
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #92004|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #92002|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #92003|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #92000|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #92001|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #22 from Andrew Isherwood ---
Created attachment 93530
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93530=edit
Bug 23112: Add CirculateILL syspref
Sponsored-by: Loughborough University
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #21 from Magnus Enger ---
(In reply to Magnus Enger from comment #20)
> (In reply to Andrew Isherwood from comment #15)
> > Created attachment 92000 [details] [review] [review]
> > Bug 23122: Add CirculateILL syspref
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #20 from Magnus Enger ---
(In reply to Andrew Isherwood from comment #15)
> Created attachment 92000 [details] [review]
> Bug 23122: Add CirculateILL syspref
>
> Sponsored-by: Loughborough University
There is a typo in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Christopher Davis changed:
What|Removed |Added
CC||cgda...@uintah.utah.gov
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Chris Slone changed:
What|Removed |Added
CC||cslone@camdencountylibrary.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #91991|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #91989|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #91990|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #91988|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Attachment #91987|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Status|NEW |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #10 from Andrew Isherwood ---
Created attachment 91988
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91988=edit
Bug 23112: Add circulation to ILL requests
This patch adds the ability to circulate ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #9 from Andrew Isherwood ---
Created attachment 91987
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91987=edit
Bug 23122: Add CirculateILL syspref
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #11 from Andrew Isherwood ---
Created attachment 91989
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91989=edit
Bug 23112: Add permission checks
We only want the ILL circulation functionality to be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #12 from Andrew Isherwood ---
Created attachment 91990
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91990=edit
Bug 23112: Update request status on return
This patch updates a request's status to RET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #13 from Andrew Isherwood ---
Created attachment 91991
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91991=edit
Bug 23112: Add unit tests
This patch adds unit test for the new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Depends on||23384
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Depends on|22818 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Depends on|23336 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Andrew Isherwood changed:
What|Removed |Added
Depends on||22818, 23336
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #8 from Martin Renvoize ---
It's on the wiki
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #6 from Martin Renvoize ---
An alternative specification has been sent to the customer and agreed.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Martin Renvoize changed:
What|Removed |Added
Change sponsored?|--- |Sponsored
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Niamh changed:
What|Removed |Added
CC||niamh.walker-headon@it-tall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
Jonathan Field changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112
--- Comment #5 from Lisette Scheer ---
(In reply to Martin Renvoize from comment #3)
> (In reply to Lisette Scheer from comment #1)
> > In the Step: Places a hold on the item for the patron and marks it ready for
> > collection, I'd
1 - 100 of 110 matches
Mail list logo