[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters (renamed start_date and expiry_date)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters (renamed start_date and expiry_date)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com ---

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters (renamed start_date and expiry_date)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind changed: What|Removed |Added Text to go in the||This patch implements the

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters (renamed start_date and expiry_date)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #32 from Arthur Suzuki --- Yipee! awesome, thanks joubu & martin \o/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters (renamed start_date and expiry_date)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters (renamed start_date and expiry_date)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #31 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters (renamed start_date and expiry_date)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters (renamed start_date and expiry_date)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Martin Renvoize changed: What|Removed |Added Severity|normal |enhancement

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters (renamed start_date and expiry_date)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #29 from Jonathan Druart --- Created attachment 100898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100898=edit Bug 23531: Simplify tests using build_object And build_sample_item. Also remove a

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters (renamed start_date and expiry_date)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Jonathan Druart changed: What|Removed |Added Summary|ILS-DI doesn't implement|ILS-DI doesn't implement

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #28 from Jonathan Druart --- Created attachment 100897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100897=edit Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Jonathan Druart changed: What|Removed |Added Attachment #100294|0 |1 is obsolete|

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #26 from Jonathan Druart --- (In reply to Jonathan Druart from comment #24) > IllegalParameterThe parameter > pickup_expiry_date is illegal. > > Why do I get that? Ok, forget that. -- You are receiving this mail

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #25 from Jonathan Druart --- Created attachment 100895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100895=edit Bug 23531: Simplify tests using build_object And build_sample_item. Also remove a

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #23 from Arthur Suzuki --- \o/ Many thanks for your help and fixing typo :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #22 from David Nind --- In the test plan "the ISL-DI system preference" should be "the ILS-DI system preference"! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #21 from David Nind --- (In reply to Arthur Suzuki from comment #18) > Yup, had some issues with my remotes configuration, just got to learn that > one shall not use gitlab anymore. > Patch should apply now. > Arthur

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind changed: What|Removed |Added Attachment #100222|0 |1 is obsolete|

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind changed: What|Removed |Added Attachment #100221|0 |1 is obsolete|

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #18 from Arthur Suzuki --- (In reply to David Nind from comment #14) > Sorry Arthur, patch no longer applies! Yup, had some issues with my remotes configuration, just got to learn that one shall not use gitlab anymore.

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #17 from Arthur Suzuki --- Created attachment 100222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100222=edit Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What|Removed |Added Attachment #100165|0 |1 is obsolete|

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #15 from Arthur Suzuki --- Hi David, last patch i can see on master is 22816, is it the same on your side?... I use gitlab as my remote : https://gitlab.com/koha-community/Koha I guess I'm doing smthg wrong but can't

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind changed: What|Removed |Added Status|Signed Off |Patch doesn't apply ---

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #13

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What|Removed |Added Attachment #96564|0 |1 is obsolete|

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What|Removed |Added Attachment #96563|0 |1 is obsolete|

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #9 from David Nind --- Bug for DataTables error on patrons hold tab is bug 24769 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 David Nind changed: What|Removed |Added CC||da...@davidnind.com

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Katrin Fischer changed: What|Removed |Added Blocks||11641 Referenced Bugs:

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #6 from Arthur Suzuki --- Created attachment 96563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96563=edit Bug 23531: fix ILSDI non-implemented but documented parameters test plan : 1/ Submit a hold

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #7 from Arthur Suzuki --- Created attachment 96564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96564=edit Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided -- You are

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What|Removed |Added Attachment #93475|0 |1 is obsolete|

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #5 from Katrin Fischer --- (In reply to Arthur Suzuki from comment #4) > needed_before_date is actually stored in the "reservedate", this is just a > way to place a reserve on a future date. > pickup_expiry_date is the

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #4 from Arthur Suzuki --- needed_before_date is actually stored in the "reservedate", this is just a way to place a reserve on a future date. pickup_expiry_date is the date after which the reserve is automatically

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Christophe Croullebois changed: What|Removed |Added Attachment #92538|0 |1 is

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Christophe Croullebois changed: What|Removed |Added Status|Needs Signoff |Signed Off --

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What|Removed |Added Blocks||23669 Referenced Bugs:

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Arthur Suzuki changed: What|Removed |Added Status|NEW |Needs Signoff

[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 --- Comment #1 from Arthur Suzuki --- Created attachment 92538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92538=edit bug23531 : fix ILSDI non-implemented but documented parameters test plan : 1/ Submit a hold