[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #25 from Martin Renvoize --- Nice one.. works great. Signing off the last patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added Attachment #118818|0 |1 is obsolete|

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the|This development adds |This development adds

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #23 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #21) > I could certainly picture > > PUT/patrons/:patron_id/extended_attributes/:extended_attribute_id > > as a future addition to this.. but

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 118818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118818=edit Bug 23666: Add PATCH /patron/:patron_id/extended_attributes/:extended_attribute_id

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added Depends on||28031 Referenced

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #21 from Martin Renvoize --- I could certainly picture PUT/patrons/:patron_id/extended_attributes/:extended_attribute_id as a future addition to this.. but I think for the existing code this is probably OK. --

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added Attachment #118550|0 |1 is obsolete|

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added Attachment #118510|0 |1 is obsolete|

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added Attachment #118509|0 |1 is obsolete|

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added Attachment #118508|0 |1 is obsolete|

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added Depends on|27833 | Referenced Bugs:

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 118550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118550=edit Bug 23666: (QA follow-up) Fix wrong required permissions Signed-off-by: Tomas Cohen

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Joonas Kylmälä from comment #13) > The patch set didn't apply so I had a bit hard time understanding what was > going on. But now even more reading of the code and the patches

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #13

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Joonas Kylmälä from comment #10) > (In reply to Joonas Kylmälä from comment #9) > > I noticed there is no update() function for patron attribute. This would be > > useful in

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #11 from Tomás Cohen Arazi --- (In reply to Joonas Kylmälä from comment #8) > Comment on attachment 118509 [details] [review] > Bug 23666: Add spec > > Review of attachment 118509 [details] [review]: >

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #10 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #9) > I noticed there is no update() function for patron attribute. This would be > useful in case there is mandatory attributes defined for patrons.

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #9 from Joonas Kylmälä --- I noticed there is no update() function for patron attribute. This would be useful in case there is mandatory attributes defined for patrons. Now having to use the overwrite method adds

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #8 from Joonas Kylmälä --- Comment on attachment 118509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118509 Bug 23666: Add spec Review of attachment 118509: -->

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added Blocks||28002 Referenced

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added URL|

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 118510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118510=edit Bug 23666: Add extended attributes routes This patch adds routes to handle patron's

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 118509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118509=edit Bug 23666: Add spec -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 118508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118508=edit Bug 23666: Unit tests -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27857 Referenced

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #4 from Tomás Cohen Arazi --- I'm submitting an RFC proposal, to sumarize: GET/patrons/:patron_id/extended_attributes POST /patrons/:patron_id/extended_attributes PUT/patrons/:patron_id/extended_attributes <-

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added QA Contact|

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added CC||lari.task...@hypernova.fi

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27833 Referenced

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What|Removed |Added Depends on||20443 Referenced

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 --- Comment #1 from Tomás Cohen Arazi --- Hi, Stefan. I think you should add this proposal for discussion and voting here: https://wiki.koha-community.org/wiki/REST_api_RFCs One thing to note is that attributes might be

[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de,