[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_target| -- You are receiving

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #45 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #44 from Tomás Cohen Arazi --- Created attachment 97137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97137=edit Bug 23974: Add test descriptions Signed-off-by: Katrin Fischer Signed-off-by: Tomas

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #42 from Tomás Cohen Arazi --- Created attachment 97135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97135=edit Bug 23974: Test Notes Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #39 from Tomás Cohen Arazi --- Created attachment 97132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97132=edit Bug 23974: both methods should have the same logic/construction Signed-off-by: Martin

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #43 from Tomás Cohen Arazi --- Created attachment 97136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97136=edit Bug 23974: Add tests for issue on closed day Signed-off-by: Katrin Fischer

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 97131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97131=edit Bug 23974: Add tests for days_between Signed-off-by: Martin Renvoize Signed-off-by:

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #41 from Tomás Cohen Arazi --- Created attachment 97134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97134=edit Bug 23974: Add POD for hours_between Add a bit of missing POD whilst we're working in

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 97129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97129=edit Bug 23974: Improve readability This patch does not change anything, just a bit of

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #40 from Tomás Cohen Arazi --- Created attachment 97133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97133=edit Bug 23974: (follow-up) Add same day loan tests Hourly loans can be short enough to not

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 97130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97130=edit Bug 23974: Add new tests for hours_between Signed-off-by: Martin Renvoize

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96786|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96784|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96783|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96785|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96782|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96780|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96781|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96778|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96779|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What|Removed |Added Attachment #95896|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What|Removed |Added Attachment #95895|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What|Removed |Added Attachment #95211|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What|Removed |Added Attachment #95212|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What|Removed |Added Attachment #95894|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What|Removed |Added Attachment #95213|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What|Removed |Added Attachment #95893|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What|Removed |Added Attachment #95889|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What|Removed |Added Attachment #95210|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #25 from Martin Renvoize --- How are we doing here? I think this is close to ready now.. we're well tested for the existing functionality and I think the notes are actually helpful as they for future reference and we

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #23 from Martin Renvoize --- Created attachment 95895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95895=edit Bug 23974: Add tests for issue on closed day -- You are receiving this mail because:

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #24 from Martin Renvoize --- Created attachment 95896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95896=edit Bug 23974: Add test descriptions -- You are receiving this mail because: You are

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Attachment #95891|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Attachment #95890|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #18 from Martin Renvoize --- Created attachment 95890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95890=edit Bug 23974: Add POD for hours_between Add a bit of missing POD whilst we're working in

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #19 from Martin Renvoize --- Created attachment 95891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95891=edit Bug 23974: Test Notes -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Attachment #95214|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Keywords|rel_19_11_candidate |rel_20_05_target -- You

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #14 from Jonathan Druart --- What about the FIXMEs? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #13 from Martin Renvoize --- Brain fuzz, already at signed off.. I meant I think these are safe to push and just improve our test coverage at this point. Would you just check my final followup looks ok Jonathan? --

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #12 from Martin Renvoize --- I think we're safe to push these additional tests as they are. Not sure what more needs discussing at the minute? Can we set to NSO ? -- You are receiving this mail because: You are

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #10 from Martin Renvoize --- Created attachment 95214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95214=edit Bug 23974: (follow-up) Add same day loan tests Hourly loans can be short enough to not

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Attachment #95065|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Attachment #95064|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Attachment #95063|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Attachment #95062|0 |1 is obsolete|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_11_candidate --

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #1 from Jonathan Druart --- Created attachment 95062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95062=edit Bug 23974: Improve readability This patch does not change anything, just a bit of

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #4 from Jonathan Druart --- Created attachment 95065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95065=edit Bug 23974: both methods should have the same logic/construction -- You are receiving

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #2 from Jonathan Druart --- Created attachment 95063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95063=edit Bug 23974: Add new tests for hours_between -- You are receiving this mail because: You

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #3 from Jonathan Druart --- Created attachment 95064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95064=edit Bug 23974: Add tests for days_between -- You are receiving this mail because: You are

[Koha-bugs] [Bug 23974] hours_between and days_between lack tests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Jonathan Druart changed: What|Removed |Added See Also|