https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Katrin Fischer changed:
What|Removed |Added
Attachment #103193|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #24 from Katrin Fischer ---
Created attachment 103193
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103193=edit
Bug 25138: (follow-up) Point of sale should use library instead of branch
Fixes a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Lucas Gass changed:
What|Removed |Added
Status|Pushed to stable|Pushed to oldstable
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Lucas Gass changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Martin Renvoize changed:
What|Removed |Added
Version(s)|19.05.00|20.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #21 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Marcel de Rooy changed:
What|Removed |Added
Attachment #95946|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Marcel de Rooy changed:
What|Removed |Added
Attachment #95945|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Marcel de Rooy changed:
What|Removed |Added
Status|Failed QA |Passed QA
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #18 from Marcel de Rooy ---
The main confusion must have been the grace subtraction. So I will pass qa.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #15 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #13)
> (In reply to Marcel de Rooy from comment #8)
> > my $suspension_days = $deltadays * $finedays;
> > finedays is a number, deltadays is not ?
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #16 from Marcel de Rooy ---
This could be out of scope: But isnt it strange that calculating chargeable
units does not look at FinesIncludeGracePeriod ?
I would expect fine and suspension period should follow the same
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #17 from Marcel de Rooy ---
Using in_units from Duration is not entirely without risk btw.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #14 from Jonathan Druart
---
Also note that I am not modifying anything here, just moving up a code that is
not at the correct place.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #13 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #8)
> my $suspension_days = $deltadays * $finedays;
> finedays is a number, deltadays is not ?
>
> and then:
> floor(
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #12 from Marcel de Rooy ---
But is not really relevant to ask :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #11 from Marcel de Rooy ---
(In reply to Hugo Agud from comment #10)
> because some libraries doesn't suspend 1 day a patron for every day delayed,
> as the same way that not all libraries charge 1 usd per every day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #10 from Hugo Agud ---
because some libraries doesn't suspend 1 day a patron for every day delayed, as
the same way that not all libraries charge 1 usd per every day delayed.
In fact I guess that the majority has "x"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #9 from Marcel de Rooy ---
Why do we need a fine charging interval and a suspension interval btw ?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #8 from Marcel de Rooy ---
my $suspension_days = $deltadays * $finedays;
finedays is a number, deltadays is not ?
and then:
floor( $suspension_days->in_units('days') etc
suspension_days is just a number not a duration?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Marcel de Rooy changed:
What|Removed |Added
QA Contact|martin.renvoize@ptfs-europe |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Hugo Agud changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Hugo Agud changed:
What|Removed |Added
Attachment #95887|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Hugo Agud changed:
What|Removed |Added
Attachment #95886|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #5 from Jonathan Druart
---
Hugo, this patch is only affecting suspension duration for patrons (debarment).
It should not affect the calculation of fines.
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #4 from Hugo Agud ---
I am checking the patch and it is working fine, BUT I have realized that fines
only applies if Fine grace period is applied... it is mandatory add a value,
independtl of the syspref of grace period.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #3 from Martin Renvoize ---
Code looks solid, but it would be good to get Hugo's signoff that he believes
it's working as expected before I QA it.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #2 from Jonathan Druart
---
Created attachment 95887
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95887=edit
Bug 24138: Fix calculation of suspension days when a limit is set
If there is a limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
--- Comment #1 from Jonathan Druart
---
Created attachment 95886
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95886=edit
Bug 24138: Move the calculation out of the sub
No changes expected here. For the next
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138
Jonathan Druart changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You
34 matches
Mail list logo
