[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #49 from Victor Grousset/tuxayo --- Ok this is a though one ^^" After rereading most stuff here: comment 1 mentions that days and months work. After testing: a. the localized value is saved directly in the database[1]

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #48 from Blou --- The previous comment is not clear on what needs to be corrected. Considering Jonathan's objections were previously on architectural principles, I do not think those lines suddenly present the last

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Victor Grousset/tuxayo changed: What|Removed |Added Keywords||no-sandbox --

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Emily-Rose Francoeur changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #46 from Jonathan Druart --- (In reply to Jonathan Druart from comment #14) > Had a look again at this. > > I agree with the changes in subscription-detail.tt, catalogue/detail.tt and > opac-detail.tt > However I am

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele changed: What|Removed |Added Attachment #151330|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele changed: What|Removed |Added Attachment #148921|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #43 from Magnus Enger --- (In reply to Caroline Cyr La Rose from comment #23) > I don't get why we want this to be translatable (and you know I'm usually > for translatability). The numbering is written on the actual

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #42 from Hammat wele --- (In reply to Magnus Enger from comment #40) > Sorry. > > $ git bz apply 24172 > > koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt > CONFLICT (content): Merge conflict in

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Hammat wele changed: What|Removed |Added Attachment #139809|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What|Removed |Added Severity|minor |normal --- Comment #39 from Blou

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What|Removed |Added Attachment #139807|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What|Removed |Added CC||shi-yao.w...@inlibro.com

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What|Removed |Added Attachment #139803|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What|Removed |Added Attachment #139806|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What|Removed |Added Attachment #139804|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What|Removed |Added Attachment #139805|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Shi Yao Wang changed: What|Removed |Added Attachment #100888|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #33 from Katrin Fischer --- (In reply to Katrin Fischer from comment #18) > Blou can you please double check and come back to us? I am not sure about > storing 'translated' values in the db if this wasn't done before.

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #32 from Katrin Fischer --- I can try to look into this one, as I've also tested bug 20511, but since I'll be on vacation next week, it won't be quick. Please switch to needs signoff or signed off (depending on the

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What|Removed |Added Attachment #100332|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What|Removed |Added Attachment #100331|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #29 from Blou --- Bug 20511 doesn't help. Since this patch won't get any support, but we need it, we'll rebase it for our own needs. Including a squash for simplicity sake. -- You are receiving this mail because: You

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #27 from Katrin Fischer --- I can confirm this in 20.11 still. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #25 from

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Jonathan Druart changed: What|Removed |Added QA Contact|jonathan.dru...@bugs.koha-c |

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #23 from Caroline Cyr La Rose --- Hi Jonathan, I don't understand why you would be against this. The community certainly has several institutions who have serials in different languages (here, it's mostly french and

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #22 from Jonathan Druart --- I don't think this specific needs should be merged with the Koha codebase. If you really want it you can handle it with some JS code. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #21 from Blou --- It's very hard to handle fields with translations. Without modification, it will display English words. Definitively what the user does not want. The alternative (here coded) display in French, and

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #20 from Jonathan Druart --- (In reply to Blou from comment #19) > (Sorry, still hadn't come back to it as promessed) > > The goal is really that it it stored in English, always. So we are saying the same thing,

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #19 from Blou --- (Sorry, still hadn't come back to it as promessed) The goal is really that it it stored in English, always. Then translated on display. That's what my patches presume. The problem with saving in a

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #18

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #17 from Katrin Fischer --- It looks like we should always store the English value in the database so that the template code can then translte it to the currently selected language? -- You are receiving this mail

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #16 from Blou --- I wanted the user with the experience to come explain, but the Situation prevents it. I'll take time this week to put my head back into it and explain it. -- You are receiving this mail because: You

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #15 from Jonathan Druart --- (I did not test that it works as I described it, but guessing it is how it works reading the code) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #14 from Jonathan Druart --- Had a look again at this. I agree with the changes in subscription-detail.tt, catalogue/detail.tt and opac-detail.tt However I am still not sure what we are doing in serials-edit.tt is

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #12 from Blou --- Don't know what to tell you. When the user gets to receive the damn serial (bulletiner, en français), it shows up in English, even though all their environment is in French. I explained the logic in

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #10 from Jonathan Druart --- I should have tested the patches before writing the follow-up. I do not understand what is done here, why do we want to modify the value on editing? It means we are going to have "Winter"

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #9 from Jonathan Druart --- Created attachment 100888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100888=edit Bug 24172: Move duplicated code to an include file -- You are receiving this mail

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Martin Renvoize changed: What|Removed |Added Attachment #95996|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Martin Renvoize changed: What|Removed |Added Attachment #96051|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #5 from Blou --- Created attachment 96051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96051=edit Bug 24172: Allow translation of seasons in details.tt and opac-details.tt -- You are receiving this

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What|Removed |Added Attachment #95998|0 |1 is obsolete|

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Blou changed: What|Removed |Added Status|NEW |Needs Signoff

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #3 from Blou --- Created attachment 95998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95998=edit Bug 24172: Allow translation of seasons in details.tt and opac-details.tt -- You are receiving this

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #2 from Blou --- Created attachment 95996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95996=edit Bug 24172: Allow translation of seasons in serials-edit.tt and subscription-detail.tt Seasons are

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 --- Comment #1 from Caroline Cyr La Rose --- I hadn't noticed, but everything works a-ok for month and day names. The problem happens only when using season names. -- You are receiving this mail because: You are the assignee for

[Koha-bugs] [Bug 24172] Locale is ignored when saving season name in the database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172 Caroline Cyr La Rose changed: What|Removed |Added Summary|Locale is ignored when |Locale is ignored