https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Owen Leonard changed:
What|Removed |Added
Keywords|release-notes-needed|
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Bug 24223 depends on bug 28768, which changed state.
Bug 28768 Summary: OPAC reading history page (opac-readingrecord.pl) wont
display news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768
What
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_21_11_candidate |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #93 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Owen Leonard changed:
What|Removed |Added
Blocks||24224
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #92 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #90)
> Is that weird to have OpacNav without OpacNavBottom part of 21.11?
Yes, at least a bit. But these refactoring operations cross release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #91 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #90)
> Is that weird to have OpacNav without OpacNavBottom part of 21.11?
Well, we have OpacNavRight already.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #90 from Jonathan Druart ---
Is that weird to have OpacNav without OpacNavBottom part of 21.11?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #88 from Jonathan Druart ---
Patches rebased and some squashed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Attachment #126487|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Attachment #126486|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Attachment #126485|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Attachment #126492|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Attachment #126489|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Attachment #126491|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Attachment #126490|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Attachment #126488|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Attachment #126484|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Attachment #127338|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #83 from Jonathan Druart ---
Created attachment 127338
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127338=edit
Bug 24223: Fix borrowernumber from opac-readingrecord.tt
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #82 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #81)
> (In reply to Jonathan Druart from comment #80)
> > 1. I may be missing something but I don't understand why we are setting
> > OpacNav from the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #81 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #80)
> 1. I may be missing something but I don't understand why we are setting
> OpacNav from the .tt when we need it in .inc. Why don't we
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Depends on||28768
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Keywords||release-notes-needed
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #78 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #56)
> (In reply to Marcel de Rooy from comment #55)
Coming back to open questions:
> > The following observations are broader than the scope of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #77 from Marcel de Rooy ---
Created attachment 126492
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126492=edit
Bug 24223: (QA follow-up) Link OpacNav to HTML customizations now
In the pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #76 from Marcel de Rooy ---
Created attachment 126491
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126491=edit
Bug 24223: (QA follow-up) Do not copy to other languages
By majority on Bugzilla, we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
Attachment #126147|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
Attachment #126089|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
Attachment #125771|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
Attachment #125770|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
Attachment #125769|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
Attachment #125768|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
Attachment #125767|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #68 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #66)
> (In reply to Jonathan Druart from comment #65)
> > So yes, only 1 entry as "default" would make sense to me as well.
>
> Well, no changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
Status|Failed QA |BLOCKED
--- Comment #67
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #66 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #65)
> So yes, only 1 entry as "default" would make sense to me as well.
Well, no changes needed for that then.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #65 from Jonathan Druart ---
So yes, only 1 entry as "default" would make sense to me as well.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #64 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #63)
> (In reply to Jonathan Druart from comment #62)
> > If it's "en" it must be the default. If it has a specific language prior the
> > upgrade we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #63 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #62)
> If it's "en" it must be the default. If it has a specific language prior the
> upgrade we should use it and copy the content for default (so
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #62 from Jonathan Druart ---
If it's "en" it must be the default. If it has a specific language prior the
upgrade we should use it and copy the content for default (so two entries in
the table). It's what we did on bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #61 from Katrin Fischer ---
(In reply to Owen Leonard from comment #60)
> (In reply to Katrin Fischer from comment #57)
>
> > I think adding only the default would make sense to me.
>
> For what it's worth, the idea
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #60 from Owen Leonard ---
(In reply to Katrin Fischer from comment #57)
> I think adding only the default would make sense to me.
For what it's worth, the idea behind adding to all available languages is to
ensure that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #59 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #56)
> (In reply to Marcel de Rooy from comment #55)
> > Going back from an additional contents item, I should be returning to
> > additional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #58 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #53)
> This is weird:
> Dates got mixed up somewhere. I have 2026-08-01 in
> additional_contents.published_on.
See bug 29254
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #57 from Katrin Fischer ---
(In reply to Marcel de Rooy from comment #54)
> The installer only created a default entry for me. Why didnt he add english
> too?
I think adding only the default would make sense to me. This
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #56 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #55)
> The following observations are broader than the scope of this report. But I
> am mentioning them here anyhow:
>
> Listview shows: See HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #55 from Marcel de Rooy ---
The following observations are broader than the scope of this report. But I am
mentioning them here anyhow:
Listview shows: See HTML customizations. This 'See' is confusing. The toggle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #54 from Marcel de Rooy ---
The installer only created a default entry for me. Why didnt he add english
too?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #53 from Marcel de Rooy ---
This is weird:
Dates got mixed up somewhere. I have 2026-08-01 in
additional_contents.published_on.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #52 from Marcel de Rooy ---
This pref description needs attention:
Show the following HTML on the left hand column of the main page and patron
account on the OPAC, after OpacNav, and before patron account links if
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #51 from Marcel de Rooy ---
Opened bug 29245 for improving getTranslatedLanguages
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #50
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #49 from Marcel de Rooy ---
Coming back here soon
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #48 from Jonathan Druart ---
Created attachment 126147
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126147=edit
Bug 24223: Get languages for OPAC
There were 2 warnings
Use of uninitialized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #46 from Owen Leonard ---
(In reply to Marcel de Rooy from comment #43)
> No blocker, but you might wanna take a look at:
>
> Argument "" isn't numeric in numeric gt (>) at
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #45 from Owen Leonard ---
Created attachment 126089
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126089=edit
Bug 24223: (follow-up) Add missing "return" to atomicupdate
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #44 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #40)
> You do not return a hash, but you start a block with
Hmm. At least it is not right :)
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #43 from Marcel de Rooy ---
No blocker, but you might wanna take a look at:
Argument "" isn't numeric in numeric gt (>) at
/usr/share/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
line 264.
Argument
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #42 from Marcel de Rooy ---
Explaining:
FAIL valid
Useless use of anonymous hash ({}) in void context
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #41 from Marcel de Rooy ---
s/skeleton/atomic update/
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #40 from Marcel de Rooy ---
Skeleton should include a return of a hash like:
return {
bug_number => "BUG_NUMBER",
description => "A single line description",
up => sub {
my ($args) = @_;
my
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Owen Leonard changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Jonathan Druart changed:
What|Removed |Added
Keywords||rel_21_11_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #38 from Owen Leonard ---
Created attachment 125771
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125771=edit
Bug 24223: (follow-up) Do not add id 'opacnav' in navigation.inc
Id attribut will be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #37 from Owen Leonard ---
Created attachment 125770
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125770=edit
Bug 24223: (follow-up) Updates to conform to new practices
- The patch now works with new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #36 from Owen Leonard ---
Created attachment 125769
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125769=edit
Bug 24223: (follow-up) Make logged-in user's branchcode available to template
This patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #35 from Owen Leonard ---
Created attachment 125768
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125768=edit
Bug 24223: (follow-up) Add date to OpacNav additional content entries
This follow-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Owen Leonard changed:
What|Removed |Added
Attachment #125300|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #32 from Fridolin Somers ---
Created attachment 125304
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125304=edit
Bug 24223: (follow-up) Do not add id 'opacnav' in navigation.inc
Id attribut will be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Fridolin Somers changed:
What|Removed |Added
Attachment #124938|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Fridolin Somers changed:
What|Removed |Added
Attachment #124937|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Fridolin Somers changed:
What|Removed |Added
Attachment #124936|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Fridolin Somers changed:
What|Removed |Added
Attachment #124935|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Owen Leonard changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #27 from Owen Leonard ---
Created attachment 124938
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124938=edit
Bug 24223: (follow-up) Updates to conform to new practices
- The patch now works with new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #26 from Owen Leonard ---
Created attachment 124937
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124937=edit
Bug 24223: (follow-up) Make logged-in user's branchcode available to template
This patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #25 from Owen Leonard ---
Created attachment 124936
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124936=edit
Bug 24223: (follow-up) Add date to OpacNav additional content entries
This follow-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Owen Leonard changed:
What|Removed |Added
Attachment #115758|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Owen Leonard changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Bug 24223 depends on bug 27451, which changed state.
Bug 27451 Summary: Split opac_news.lang into two distinct fields for location
and language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27451
What
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #22 from Owen Leonard ---
Created attachment 115760
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115760=edit
Bug 24223: (follow-up) Make logged-in user's branchcode available to template
This patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #21 from Owen Leonard ---
Created attachment 115759
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115759=edit
Bug 24223: (follow-up) Add date to OpacNav news entries
This follow-up modifies the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Owen Leonard changed:
What|Removed |Added
Attachment #113130|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Owen Leonard changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
Josef Moravec changed:
What|Removed |Added
CC||josef.mora...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #17 from Owen Leonard ---
Created attachment 113131
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113131=edit
Bug 24223: (follow-up) Add date to OpacNav news entries
This follow-up modifies the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223
--- Comment #18 from Owen Leonard ---
Created attachment 113132
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113132=edit
Bug 24223: (follow-up) Make logged-in user's branchcode available to template
This patch
1 - 100 of 124 matches
Mail list logo
