[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #25 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #24) > I checked on the use of active_orders_count and it is only used in > parcel.tt. This all looks okay. Do not allow order cancellation with >

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #24 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #22) > Looking at Koha::Acquisition::Orders it feels like I might have mixed > 'current' vs. 'active'. So a terminology problem. And

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #23 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #22) > Looking at Koha::Acquisition::Orders it feels like I might have mixed > 'current' vs. 'active'. So a terminology problem. And

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #17) > A bit late, but wondering why active_orders include completed lines ? Looks > a bit strange to me.. Looking at Koha::Acquisition::Orders it

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #21 from Martin Renvoize --- Not with how the API embeds get translated. The real fix is to fix our database field names and database table names to generally be consistency.. but that would upset everyone with

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #20 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #19) > Adding the orders relation alias is forward thinking for the API here. I > agree with the approach Tomas took Yeah no problem. But couldnt you

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #19 from Martin Renvoize --- Adding the orders relation alias is forward thinking for the API here. I agree with the approach Tomas took -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #18 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #0) > Using the DBIC relationship with aqorders and count, we can get rid of it. You could have used aqorders but added orders? -- You are

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Jonathan Druart changed: What|Removed |Added Blocks||24672 Referenced Bugs:

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Joy Nelson changed: What|Removed |Added Resolution|--- |FIXED CC|

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Bug 24430 depends on bug 24418, which changed state. Bug 24418 Summary: Add Koha::Biblio->suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418 What|Removed |Added

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Blocks||24467 Referenced

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Blocks|24467 | Referenced Bugs:

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Jonathan Druart changed: What|Removed |Added Blocks||24467 Referenced Bugs:

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #15 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Martin Renvoize changed: What|Removed |Added Attachment #97565|0 |1 is obsolete|

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Martin Renvoize changed: What|Removed |Added Attachment #97564|0 |1 is obsolete|

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Martin Renvoize changed: What|Removed |Added Attachment #97563|0 |1 is obsolete|

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Nicolas Legrand changed: What|Removed |Added CC||nicolas.legr...@bulac.fr

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #9 from Nick Clemens --- Created attachment 97564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97564=edit Bug 24430: Add ->orders and ->active_orders_count to Koha::Biblio This patch introduces an

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #10 from Nick Clemens --- Created attachment 97565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97565=edit Bug 24430: Remove CountBiblioInOrders and its traces This patch replaces the only uses of

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Nick Clemens changed: What|Removed |Added Attachment #97446|0 |1 is obsolete|

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Blocks||24435 Referenced

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Depends on||24418 Referenced

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 97446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97446=edit Bug 24430: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 97448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97448=edit Bug 24430: Remove CountBiblioInOrders and its traces This patch replaces the only uses

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Attachment #97415|0 |1 is obsolete|

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 97447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97447=edit Bug 24430: Add ->orders and ->active_orders_count to Koha::Biblio This patch introduces

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Attachment #97414|0 |1 is obsolete|

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Attachment #97443|0 |1 is obsolete|

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Attachment #97416|0 |1 is obsolete|

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Blocks||17628, 20212

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 97414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97414=edit Bug 24430: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 97415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97415=edit Bug 24430: Add ->orders and ->orders_count to Koha::Biblio This patch introduces an

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 97416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97416=edit Bug 24430: Remove CountBiblioInOrders and its traces This patch replaces the only uses

[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com