[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2022-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Bug 24631 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What|Removed

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2022-08-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Bug 24631 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What|Removed

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-12-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Bug 24631 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What|Removed

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Julian Maurice changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #65

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #64 from Julian Maurice --- (In reply to Kyle M Hall from comment #61) > As an FYI, the idea here is to check the database for the metadata to avoid > loading the plugin. If it's not in the database, we load the plugin

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-06-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_11_target -- You

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| CC|

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate |rel_20_11_target -- You

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #63 from David Cook --- (In reply to Julian Maurice from comment #8) > Won't that be a problem if people want to publish their plugins on CPAN ? I've been thinking about this more, and while I was skeptical at first...

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #62 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #60) > > 19) Test that all the plugin methods ( configure, report, tool ) still work > > Report doesn't work or maybe I don't know how to use it.

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #61 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #58) > > Heh, I have no idea what I was thinking when I wrote that part of the test > > plan! If you delete the metadata in the db, and restart

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #60 from Victor Grousset/tuxayo --- > 19) Test that all the plugin methods ( configure, report, tool ) still work Report doesn't work or maybe I don't know how to use it. Whatever, it has surely nothing to do with

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #104266|0 |1 is

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #58 from Victor Grousset/tuxayo --- > Heh, I have no idea what I was thinking when I wrote that part of the test > plan! If you delete the metadata in the db, and restart plack, *of course* > the metadata will get

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #57 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #55) > 5) Browse to plugins home, note that nothing appears to have changed > > Noo I see my changes from KitchenSink.pm . Which isn't

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Attachment #104256|0 |1 is obsolete|

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Martin Renvoize changed: What|Removed |Added Blocks||22832 Referenced Bugs:

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Failed QA ---

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #54 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #52) > I did restart_all again and now I'm getting endless of these errors in the > logs. > > > Use of uninitialized value $bundle_path in

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Attachment #104024|0 |1 is obsolete|

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #52 from Victor Grousset/tuxayo --- I did restart_all again and now I'm getting endless of these errors in the logs. > Use of uninitialized value $bundle_path in concatenation (.) or string at >

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #51 from Victor Grousset/tuxayo --- > 5) Browse to plugins home, note that nothing appears to have changed I still the data from the .pm edited on step 4 > 11) Remove lines 28-40, 47-49 from KitchenSink.pm, this

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #50 from Victor Grousset/tuxayo --- I tried to continue. > 6) Note the metadata in plugin_data has been regenerated Should we expect the original data or the edited version? (from KitchenSink.pm) > 9) Reload the

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Failed QA ---

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #48 from David Cook --- By the way, for https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632, I ended up signing a digest of the KPZ file, so I don't have any concerns about the metadata file affecting that

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Attachment #104023|0 |1 is obsolete|

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #46 from Kyle M Hall --- I should have added to the test plan: 1) Test that you can run the plugin configuration, enable/disable, the plugin, run the tool and report methods, and uninstall the plugin! -- You are

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Attachment #103983|0 |1 is obsolete|

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #44 from Kyle M Hall --- (In reply to David Cook from comment #40) > I'm a bit confused. > > So you're storing metadata in PLUGIN.yml *and* in plugin_data depending on > the scenario? That seems suboptimal. > > Why not

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #43 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #42) > It works :) > > @Kyle: Is there another way to test than modifying the archive? (so the test > plan can be fixed) > It's easy on Linux

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Failed QA ---

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #41 from Victor Grousset/tuxayo --- > So you're storing metadata in PLUGIN.yml *and* in plugin_data depending on > the scenario? That seems suboptimal. I just edited the two sources of data that for debugging. > and

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #40 from David Cook --- I'm a bit confused. So you're storing metadata in PLUGIN.yml *and* in plugin_data depending on the scenario? That seems suboptimal. Why not just use the plugin_data? You could read PLUGIN.yml

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #39 from Victor Grousset/tuxayo --- - change PLUGIN.yml and ../KitchenSink.pm in different ways - checkout to b50d891c099d0f21f2528c5a6d5bbb586cf1612e (master at that time) - apply the old patch with git am - restart_all

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #38 from Victor Grousset/tuxayo --- For some reason I'm not getting any change. Whether from PLUGIN.yml or KitchenSink.pm On a fresh koha-testing-docker after restart_all and flush_memcached The previous version of

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Attachment #103982|0 |1 is obsolete|

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Attachment #103722|0 |1 is obsolete|

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #35 from Kyle M Hall --- I think I've changed my mind about making this a followup bug. The new code for based on Marcel's thoughts is much more elegant. I'm going to post the change there for posterity, then close the

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Blocks||25316 Referenced Bugs:

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #34 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #25) > This part of GetPlugins is rather debatable: > load $plugin_class; > my $plugin = $plugin_class->new({ > enable_plugins

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #33 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #24) > Why not do something like this in a plugin with an our $metadata definition: > sub new { > my ($class, $params) = @_; > return

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #32

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #31 from Victor Grousset/tuxayo --- Yes, bug 25285 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #30 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #29) > Works :D > > I might have found an unrelated bug. When putting a minimum version of Koha > superior to the current one. The warning text

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Victor Grousset/tuxayo changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #29 from Victor Grousset/tuxayo --- Works :D I might have found an unrelated bug. When putting a minimum version of Koha superior to the current one. The warning text is wrong. > Warning: This report was written for a

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #103656|0 |1 is

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #27 from Marcel de Rooy --- And as a final observation, I am seeing lots of methods in the plugin_methods table for an installed class with 2 actual methods. We probably dont need all the imported stuff from Plugin::Base

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #26 from Marcel de Rooy --- Perhaps a bit out of scope, but could we have a Koha/Plugin/Example class that contains the absolute minimum code for a plugin to be usable in our codebase, controlled by the regular QA

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #25 from Marcel de Rooy --- This part of GetPlugins is rather debatable: load $plugin_class; my $plugin = $plugin_class->new({ enable_plugins => $self->{'enable_plugins'} #

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Attachment #103092|0 |1 is obsolete|

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #22 from Kyle M Hall --- (In reply to Kyle M Hall from comment #21) > (In reply to Victor Grousset/tuxayo from comment #19) > > Retested on latest patches. > > > > > 3) Browse to plugins home, note that nothing appears

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #21 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #19) > Retested on latest patches. > > > 3) Browse to plugins home, note that nothing appears to have changed > > Except my screen turned orange

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #18 from Kyle M Hall --- (In reply to David Cook from comment #17) > (In reply to Martin Renvoize from comment #11) > > As for requiring module load prior to reading the yml.. hmm, does feel like > > we should be able to

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #20 from David Cook --- (In reply to Kyle M Hall from comment #18) > Those are some good ideas, a lot of which are more in the scope of > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632 > > Take a look

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Failed QA ---

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #17 from David Cook --- (In reply to Martin Renvoize from comment #11) > As for requiring module load prior to reading the yml.. hmm, does feel like > we should be able to get that path info from the plugin base code

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #16 from Kyle M Hall --- Created attachment 103468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103468=edit Bug 24631: Rename META.yml to PLUGIN.yml -- You are receiving this mail because: You are

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #15 from Kyle M Hall --- (In reply to Martin Renvoize from comment #11) > I'm happy with whatever name.. META.yml probably came out of a discussion > Kyle and I had about using cpan's packaging system for inspiration.. >

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #14 from Kyle M Hall --- Created attachment 103467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103467=edit Bug 24631: Remove the need to 'require' the plugin path -- You are receiving this mail

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #13 from Kyle M Hall --- (In reply to Martin Renvoize from comment #11) > I'm happy with whatever name.. META.yml probably came out of a discussion > Kyle and I had about using cpan's packaging system for inspiration.. >

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #12 from Kyle M Hall --- > But there is a bigger problem IMO: in order to get the path of the yaml > file, the main plugin module is loaded first, which defeats the purpose of > this bug. Isn't there any other way to

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #11 from Martin Renvoize --- I'm happy with whatever name.. META.yml probably came out of a discussion Kyle and I had about using cpan's packaging system for inspiration.. meta.yml, plugin.yml. koha.yml.. I'm not too

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #10 from Julian Maurice --- (In reply to David Cook from comment #9) > That said, maybe META.yml is just too close for comfort. Maybe KMETA.yml or > KPMETA.yml? Just to make it a bit more distinctive? KPMETA.yml is just

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #9 from David Cook --- (In reply to Julian Maurice from comment #8) > (In reply to Kyle M Hall from comment #6) > > (In reply to Julian Maurice from comment #5) > > > Hi Kyle, > > > > > > Can you comment on why you

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #8 from Julian Maurice --- (In reply to Kyle M Hall from comment #6) > (In reply to Julian Maurice from comment #5) > > Hi Kyle, > > > > Can you comment on why you chose to name the file META.yml ? Is it related > > to

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #6 from Kyle M Hall --- (In reply to Julian Maurice from comment #5) > Hi Kyle, > > Can you comment on why you chose to name the file META.yml ? Is it related > to https://metacpan.org/pod/CPAN::Meta::Spec ? You are

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #5 from Julian Maurice --- Hi Kyle, Can you comment on why you chose to name the file META.yml ? Is it related to https://metacpan.org/pod/CPAN::Meta::Spec ? -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate --

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #4 from Martin Renvoize --- Thanks for jumping onto this one Kyle :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au ---

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #2 from Kyle M Hall --- Created attachment 103092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103092=edit Bug 24631: Plugin metadata should be outside the main class Currently, plugin metadata is

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-02-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Julian Maurice changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-02-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Martin Renvoize changed: What|Removed |Added Depends on||23975 Referenced Bugs: