[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Tomás Cohen Arazi changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Lisette Scheer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Aleisha Amohia changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.04

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #39 from Hans Pålsson --- I can only give my humble thanks to all involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #38 from Andrew Nugged --- I will port (also becase Hans Pålsson requested to have it on older version and I already did pre-test port for Hans earlier). -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #37 from Magnus Enger --- Awesome! Hope this can be backported to the stable versions as well. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #36 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Katrin Fischer changed: What|Removed |Added Attachment #107120|0 |1 is obsolete|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Katrin Fischer changed: What|Removed |Added Attachment #107116|0 |1 is obsolete|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Katrin Fischer changed: What|Removed |Added Attachment #107117|0 |1 is obsolete|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Katrin Fischer changed: What|Removed |Added Attachment #107118|0 |1 is obsolete|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Katrin Fischer changed: What|Removed |Added Attachment #107119|0 |1 is obsolete|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Andrew Fuerste-Henry changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Andreas Jonsson changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Jonathan Druart changed: What|Removed |Added Severity|normal |major -- You are

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 clodagh.ke...@educampus.ie changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #30 from Jonathan Druart --- (In reply to Andrew Nugged from comment #28) > (In reply to Jonathan Druart from comment #21) > > Also, we don't need the weird "Koha::Exceptions::UnknownProgramState" > > exception,

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #29 from Andrew Nugged --- (In reply to Agustín Moyano from comment #27) > Great work Andrew! Agustín: :safe_handshake: thanks! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #28 from Andrew Nugged --- (In reply to Jonathan Druart from comment #21) > Also, we don't need the weird "Koha::Exceptions::UnknownProgramState" > exception, C4::Context->interface() is always returning something.

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #25 from Agustín Moyano --- Created attachment 107119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107119=edit Bug 24683: whole test formatted by 'perltidy' This is complementary patch using styling

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #26 from Agustín Moyano --- Created attachment 107120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107120=edit Bug 24683: IsAvailableForItemLevelRequest sub description expanded Signed-off-by:

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Agustín Moyano changed: What|Removed |Added CC||agustinmoy...@theke.io

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #24 from Agustín Moyano --- Created attachment 107118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107118=edit Bug 24683: Fix for take smart rules into account in "if all unavailable" Inside of

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #23 from Agustín Moyano --- Created attachment 107117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107117=edit Bug 24683: Optimize loop in ItemsAnyAvailableAndNotRestricted Add cut-off shortcut

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Agustín Moyano changed: What|Removed |Added Attachment #107072|0 |1 is obsolete|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #21 from Jonathan Druart --- Also, we don't need the weird "Koha::Exceptions::UnknownProgramState" exception, C4::Context->interface() is always returning something. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #20 from Andrew Nugged --- (In reply to Jonathan Druart from comment #10) > Technical comments: > * perltidy a bit the tests done > * add tests in a subtest done > * AddReturn statement is not needed done > * it

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #19 from Andrew Nugged --- Created attachment 107076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107076=edit Bug 24683: IsAvailableForItemLevelRequest sub description expanded -- You are receiving

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Andrew Nugged changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #18 from Andrew Nugged --- Created attachment 107075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107075=edit Bug 24683: whole test formatted by 'perltidy' This is complementary patch using styling

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #17 from Andrew Nugged --- Created attachment 107074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107074=edit Bug 24683: Fix for take smart rules into account in "if all unavailable" Inside of

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Andrew Nugged changed: What|Removed |Added Attachment #105651|0 |1 is obsolete|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #16 from Andrew Nugged --- Created attachment 107073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107073=edit Bug 24683: Optimize loop in ItemsAnyAvailableAndNotRestricted Add cut-off shortcut

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Andrew Nugged changed: What|Removed |Added Status|In Discussion |Failed QA -- You are

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #14 from Katrin Fischer --- I was just wondering, better to use "Failed QA" if you want to fix those things first - In Discussion can be a bit of a dead end at times as it indicated an unresolved disagreement. You could

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #13 from Andrew Nugged --- s/not needed?/not blocks or not that priority?/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #12 from Andrew Nugged --- I thought to hold sign off for a few days and group tests and fix those tech comments Joubu requested... Or not needed? -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #11 from Katrin Fischer --- Why "in discussion"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Andrew Nugged changed: What|Removed |Added Status|Needs Signoff |In Discussion -- You are

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Andrew Nugged changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #9 from Andrew Nugged --- Created attachment 105652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105652=edit Bug 24683: Fix for take smart rules into account in "if all unavailable" Inside of

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #8 from Andrew Nugged --- Created attachment 105651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105651=edit Bug 24683: Subroutine name changed (fix), no code logic changed This is the intermediate

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Andrew Nugged changed: What|Removed |Added CC||slavashish...@gmail.com,

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Andrew Nugged changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |nug...@gmail.com

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #7 from Hans Pålsson --- In version 18.11 we successfully tried adding the following section of code to lines 1191 to 1193 in Reserves.pm, however the same code is not used in the current installation. It might be of

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #6 from Hans Pålsson --- Thank you Katrin. Yes, we need a solution in some way, will continue working on this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|NEW CC|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Hans Pålsson changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED -- You are

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Nick Clemens changed: What|Removed |Added Attachment #100966|0 |1 is obsolete|

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Hans Pålsson changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Hans Pålsson changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply ---

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #3 from Magnus Enger --- Nick: Wrong bug? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #2 from Nick Clemens --- Created attachment 100966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100966=edit Bug 24683: Add description of QueryFuzzy support in ES to syspref description To test:

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #1 from Hans Pålsson --- The problem can be reproduced by doing the following; The basic assumption is that no on shelf holds are allowed ("if all unavailable"), regardless of item type. No holds on Item level. Setting

[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --