https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Joy Nelson changed:
What|Removed |Added
Version(s)|20.05.00|20.05.00, 19.11.05
rele
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #22 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #19)
> *** Bug 24753 has been marked as a duplicate of this bug. ***
No, bug 24753 has been pushed. Follow-up removed. The QAed version of the
patches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Marcel de Rooy changed:
What|Removed |Added
Attachment #99752|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #21 from David Cook ---
(In reply to Martin Renvoize from comment #9)
> That's awesome diligent work there David, thanks so much for checking it out
> and adding the enhanced test on top I was seeing of but unsure where t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #20 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing li
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Marcel de Rooy changed:
What|Removed |Added
Depends on|24753 |
Referenced Bugs:
https:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Bug 24739 depends on bug 24753, which changed state.
Bug 24753 Summary: Typo in filepath for test t/Koha/Middlware/RealIP.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24753
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Marcel de Rooy changed:
What|Removed |Added
CC||dc...@prosentient.com.au
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Marcel de Rooy changed:
What|Removed |Added
Attachment #99749|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Marcel de Rooy changed:
What|Removed |Added
Attachment #99748|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #17 from Marcel de Rooy ---
Created attachment 99752
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99752&action=edit
Bug 24739: (QA follow-up) Get rid of Middlware
I like Middleware better ;)
Signed-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #18 from Marcel de Rooy ---
(In reply to David Cook from comment #4)
> Ah crumbs... just realized I made a typo in the path for the test...
> t/Koha/Middlware/RealIP.t should be t/Koha/Middleware/RealIP.t...
Follow-up
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Passed QA
Patch complexi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #14 from Marcel de Rooy ---
Tested a Buster container too. Looks good.
=== D10
ok 1 - use Koha::Middleware::RealIP;
ok 2 - There is no X-Forwarded-For header, so just use the remote address
ok 3 - Don't trust 1.1.1.1 as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Martin Renvoize changed:
What|Removed |Added
Attachment #99730|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Martin Renvoize changed:
What|Removed |Added
Attachment #99729|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #9 from Martin Renvoize ---
That's awesome diligent work there David, thanks so much for checking it out
and adding the enhanced test on top I was seeing of but unsure where to go
with.
I'll work through testing it today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #8 from David Cook ---
Ok I signed off your patch (forgot to update the patch title).
I also enhanced your patch with a patch of my own, so that it tests IPv6
support if Net::Netmask is a version that supports IPv6 and s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #7 from David Cook ---
Created attachment 99730
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99730&action=edit
Bug 24739: Perform IPv6 tests only if Net::Netmask is correct version
Test plan:
0. Appl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
David Cook changed:
What|Removed |Added
Attachment #99690|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #5 from David Cook ---
(In reply to Martin Renvoize from comment #2)
> I think my patch is wrong.. What I'm not sure about is whether the Koha side
> would handle IPv6 addresses correctly yet and as such whether the failu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
David Cook changed:
What|Removed |Added
Depends on||24753
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #4 from David Cook ---
Ah crumbs... just realized I made a typo in the path for the test...
t/Koha/Middlware/RealIP.t should be t/Koha/Middleware/RealIP.t...
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #3 from David Cook ---
My bad. I should have looked more closely at that.
I suppose the IPv6 handling would be useful if the reverse proxy is trusted,
because then it doesn't pass that IP address on to the rest of Koha,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Martin Renvoize changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Martin Renvoize changed:
What|Removed |Added
CC||k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #2 from Martin Renvoize ---
I think my patch is wrong.. What I'm not sure about is whether the Koha side
would handle IPv6 addresses correctly yet and as such whether the failure is
flagging more work Koha side rather tha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
--- Comment #1 from Martin Renvoize ---
Created attachment 99690
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99690&action=edit
Bug 24739: Skip tests when IPv6 support is found
--
You are receiving this mail be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Martin Renvoize changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Martin Renvoize changed:
What|Removed |Added
Assignee|ch...@bigballofwax.co.nz|dc...@prosentient.com.au
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24739
Martin Renvoize changed:
What|Removed |Added
Severity|enhancement |normal
--
You are receiv
35 matches
Mail list logo
