[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.06

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate,|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #31 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Nick Clemens changed: What|Removed |Added Attachment #103432|0 |1 is obsolete|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Nick Clemens changed: What|Removed |Added Attachment #103431|0 |1 is obsolete|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Nick Clemens changed: What|Removed |Added Attachment #103430|0 |1 is obsolete|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 David Nind changed: What|Removed |Added CC||da...@davidnind.com ---

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 David Nind changed: What|Removed |Added Attachment #103327|0 |1 is obsolete|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 David Nind changed: What|Removed |Added Attachment #103325|0 |1 is obsolete|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 David Nind changed: What|Removed |Added Attachment #103326|0 |1 is obsolete|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Martin Renvoize changed: What|Removed |Added Attachment #103276|0 |1 is obsolete|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Martin Renvoize changed: What|Removed |Added Attachment #103235|0 |1 is obsolete|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Martin Renvoize changed: What|Removed |Added Attachment #102826|0 |1 is obsolete|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #20 from Martin Renvoize --- I've now obsoleted patch three as discussed. Test plan wise, the Unit tests effectively emulate the plan in Nicks first comment. It's never a bad idea to give it a go manually as a double

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Martin Renvoize changed: What|Removed |Added Attachment #103253|0 |1 is obsolete|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #18 from Jonathan Druart --- Yes, that's definitely the way to go! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate,

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #17 from Martin Renvoize --- Final alternative.. use the existing Koha::Number::Price->round method for the comparison -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs:

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Martin Renvoize changed: What|Removed |Added Attachment #103249|0 |1 is obsolete|

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #16 from Martin Renvoize --- Created attachment 103276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103276=edit Bug 25127: Use Koha::Number::Price->round for comparison -- You are receiving this

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #15 from Jonathan Druart --- (In reply to Katrin Fischer from comment #14) > We might have to treat this as configurable. We are supporting 2 decimals, it's hardcoded all over our codebase I think. -- You are

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #14 from Katrin Fischer --- (In reply to Martin Renvoize from comment #12) > Using sprintf isn't a bad solution.. it limits us to 2 currencies using only > 2 decimal places though.. I'd be interested to know if there are

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #13 from Jonathan Druart --- (In reply to Martin Renvoize from comment #12) > Using sprintf isn't a bad solution.. it limits us to 2 currencies using only > 2 decimal places though.. I'd be interested to know if there

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #12 from Martin Renvoize --- Using sprintf isn't a bad solution.. it limits us to 2 currencies using only 2 decimal places though.. I'd be interested to know if there are any Koha users out there actually using 3 or more

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > Created attachment 103253 [details] [review] > Bug 25127: Compare with 2 decimals This is what I meant. (alternative patch for "Crude float

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #10 from Jonathan Druart --- Created attachment 103253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103253=edit Bug 25127: Compare with 2 decimals -- You are receiving this mail because: You are

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #9 from Martin Renvoize --- Long term, we should really switch away from `decimal(28,6)` to `int` or `smallint` at the database level and then set a rounding routine for anywhere we end up with parts of a penny/cent/etc.

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #8 from Jonathan Druart --- You usually need to "$integer + 0.0" to compare it with floats. It's what we do in tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #7 from Martin Renvoize --- Not entirely happy with my fix, but it's the best I've come up with to date and does appear to work for all existing test cases. -- You are receiving this mail because: You are the assignee

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #6 from Martin Renvoize --- Created attachment 103249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103249=edit Bug 25127: Crude float fix -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #5 from Martin Renvoize --- Man I hate rounding maths using Floats :( 7.2 (maxfine) - 7.2 (total_amount_other) = 8.88178419700125e-16 (  ) -- You are receiving this mail because: You are the assignee for the bug. You

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #3 from Martin Renvoize --- Created attachment 103235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103235=edit Bug 25127: Correction to tests -- You are receiving this mail because: You are

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #4 from Martin Renvoize --- Aha.. I think that update to the tests clarifies it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #2 from Martin Renvoize --- I'm confused.. are your libraries literally doing step 2? By skipping UpdateFine for the test data you're ending up with 'fines' without an associated issue.. which shouldn't be possible. If

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Nick Clemens changed: What|Removed |Added CC||and...@bywatersolutions.com

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 --- Comment #1 from Nick Clemens --- Created attachment 102826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102826=edit Bug 25127: Unit tests -- You are receiving this mail because: You are the assignee for

[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Nick Clemens changed: What|Removed |Added Depends on||25123 Referenced Bugs: