[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com ---

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added Blocks|23185 | Referenced Bugs:

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master -- You

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #20 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #19 from Jonathan Druart --- Created attachment 104027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104027=edit Bug 25303: Add a test for ->reset -- You are receiving this mail because: You are

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #17) > (In reply to Jonathan Druart from comment #16) > > Created attachment 104018 [details] [review] [review] > > Bug 25303: Call ->reset

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #17 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #16) > Created attachment 104018 [details] [review] > Bug 25303: Call ->reset before iterate on the set > > In case we already started to iterate.

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Attachment #103998|0 |1 is obsolete|

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #15 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #14) > This follow-up is doing this: > > -$holds->delete; > +$biblio->holds->delete; > > I was not expected such behaviour changes, it's

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #14 from Jonathan Druart --- This follow-up is doing this: -$holds->delete; +$biblio->holds->delete; I was not expected such behaviour changes, it's not as easy as fixing the tests. Did you check the

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to master|ASSIGNED -- You are

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 103998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103998=edit Bug 25303: (QA follow-up) Fix test construction The test called ->delete on the

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #8) > Don't push this, the tests never finish (infinite loop). Good catch, I wonder why it passed for me. -- You are receiving this mail

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #9 from Jonathan Druart --- Created attachment 103941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103941=edit Bug 25303: Effectively delete the city to avoid endless loop -- You are receiving

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Status|Passed QA |ASSIGNED --- Comment #8

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 103865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103865=edit Bug 25303: Make Koha::Objects->delete loop on the object set If we call

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 103864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103864=edit Bug 25303: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103859|0 |1 is obsolete|

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master QA

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Blocks||23185 Referenced Bugs:

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added Attachment #103855|0 |1 is obsolete|

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #3 from Tomás Cohen Arazi --- It all comes down to the DB triggers discussion... I agree we could enforce people overriding Koha::Thing->delete to take care of implementing and overriden Koha::Things->delete that is

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #2 from Martin Renvoize --- This is more similar to bug 23185 than bug 21761. For performance reasons I'm not so sure about always forcing a loop rather than allowing a fast path.. I think I would rather see checks for

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #1 from Jonathan Druart --- Created attachment 103855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103855=edit Bug 25303: Make Koha::Objects->delete loop on the object set If we call

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Summary|Koha::Objects->delete |Koha::Objects->delete