https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #29 from David Cook ---
With bug 31064, it might be a bit easier.
Admittedly I'm targeting a scenario where I insert a button using OpacUserJS to
point to custom/plugin code.
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Resolution|--- |INVALID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #28 from Lucas Gass ---
> Admittedly, my interest in this is personal rather than business. I suppose
> having multiple auth options doesn't really make sense for a library OPAC.
> Maybe we should mark this one as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #27 from David Cook ---
(In reply to Lucas Gass from comment #26)
> (In reply to David Cook from comment #25)
> > Still working on this one, Lucas?
>
> I'm not sure if this bug is still valid now that we have the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #26 from Lucas Gass ---
(In reply to David Cook from comment #25)
> Still working on this one, Lucas?
I'm not sure if this bug is still valid now that we have the 'OPACShibOnly'
pref from Bug 18506
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #25 from David Cook ---
Still working on this one, Lucas?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #23 from David Cook ---
(In reply to Lucas Gass from comment #21)
> Yes, we need to add auth.tt next and there is a bit more to untangle with
> cas, shib, and GoogleOpenIDConnect. I file another bug to do so.
Sounds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
David Cook changed:
What|Removed |Added
Attachment #116350|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
David Cook changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #21 from Lucas Gass ---
> Oh, although opac-auth.tt still shows Shibboleth without the span, and it
> could use the same HTML construct as the modal... mmm maybe that can just be
> a follow-up bug, as it would be nice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #20 from Lucas Gass ---
Created attachment 116350
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116350=edit
Bug 25405: clean up some CSS
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #19 from David Cook ---
With my patch, I tested out relabeling the option in the console:
$(".shibboleth_login_name").text('Keycloak');
Worked so nicely.
--
Oh, although opac-auth.tt still shows Shibboleth without
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #18 from David Cook ---
I've signed off your patch, Lucas. So if you sign off mine, I think we can move
this to Signed Off.
:D
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #17 from David Cook ---
Created attachment 116349
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116349=edit
Bug 25405: Make it easier to add additional identity providers
Signed-off-by: David Cook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
David Cook changed:
What|Removed |Added
Attachment #116346|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #15 from David Cook ---
This is looking so good!
I'm sorry but I just have a couple more things. This is so so close.
In "div#external_login", the "a" element should be encapsulated within
"div#external_login_button".
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Attachment #114754|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #13 from David Cook ---
Of course, this actually reminds me of work I want to do for adding identity
providers via the staff admin...
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #12 from David Cook ---
Cheers, Lucas. I think that this is looking quite nice.
I do have a few suggestions though.
1. I'd change "shibboleth_login" to something more generic like
"external_login" (or idp_login or
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Blocks||27318
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Attachment #104520|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #10 from David Cook ---
(In reply to Lucas Gass from comment #9)
> I also like the GitLab login, I'll have another go at this patch ASAP
Champion! Looking forward to it.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #9 from Lucas Gass ---
I also like the GitLab login, I'll have another go at this patch ASAP
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Fridolin SOMERS changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #6 from Lucas Gass ---
Created attachment 104522
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104522=edit
Modal with updated CSS
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #5 from Lucas Gass ---
I think so problems can be addressed by changing some CSS and I supplied a new
patch that does. But if this idea is generally disliked I'm 100% willing to
abandon the idea.
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Attachment #104464|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #3 from Owen Leonard ---
Created attachment 104516
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104516=edit
Screenshot of the revised interface
I don't think this is working well. The login form is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Attachment #104464|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Attachment #104465|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Attachment #104464|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Summary|Make separation of |Make separation of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
--- Comment #1 from Lucas Gass ---
Created attachment 104464
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104464=edit
Bug 25405: Seperate Shib and Local log in for OPAC modal
1. Enable shibboleth in your
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405
Lucas Gass changed:
What|Removed |Added
Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com
--
45 matches
Mail list logo
