https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Victor Grousset/tuxayo changed:
What|Removed |Added
Version(s)|20.11.00, 20.05.07 |20.11.00,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #37 from David Cook ---
(In reply to Agustín Moyano from comment #36)
> This fix is more awesome than you realized, ;)
That's a good way to start the day!
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Agustín Moyano changed:
What|Removed |Added
CC||agustinmoy...@theke.io
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #35 from Tomás Cohen Arazi ---
This did actually break sql reports with empty parameters.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #34 from Tomás Cohen Arazi ---
(In reply to Victor Grousset/tuxayo from comment #33)
> Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.
It is needed!
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Bug 25548 depends on bug 7607, which changed state.
Bug 7607 Summary: Advanced search: Index and search term don't match when
leaving fields empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607
What
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Pushed to stable|Pushed to oldstable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #31 from Jonathan Druart
---
Pushed to master for 20.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Jonathan Druart changed:
What|Removed |Added
Version(s)||20.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
David Cook changed:
What|Removed |Added
Depends on||7607
Status|In
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #29 from David Cook ---
(In reply to Jonathan Druart from comment #27)
>
> I don't think we should push this patch without having both sides happy.
David Nind and I have signed off on Nick's patch on Bug 7607. Once QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #28 from David Cook ---
(In reply to Jonathan Druart from comment #27)
> (In reply to David Cook from comment #24)
> > (In reply to Nick Clemens from comment #20)
> > > Would it be reasonable to clear empty inputs with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |In Discussion
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
David Cook changed:
What|Removed |Added
Status|In Discussion |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #26 from David Cook ---
I am tempted to move this back to "Passed QA" because it actually resolves the
problem from Bug 7607.
While it makes for uglier URLs, it is functionally superior.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #25 from David Cook ---
(In reply to Katrin Fischer from comment #23)
> (In reply to Jonathan Druart from comment #22)
> > Who is volunteering?
>
> Hm, just clearning the inputs won't fix the problem of bug 7607 I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #24 from David Cook ---
(In reply to Nick Clemens from comment #20)
> Would it be reasonable to clear empty inputs with javascript before the
> submission?
On reflection, that won't work the way you think it would work.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #23 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #22)
> Who is volunteering?
Hm, just clearning the inputs won't fix the problem of bug 7607 I think? The
problem is, that people leave search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #22 from Jonathan Druart
---
Who is volunteering?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #21 from David Cook ---
(In reply to Nick Clemens from comment #20)
> Would it be reasonable to clear empty inputs with javascript before the
> submission?
I like your thinking here, Nick. It would be better to prevent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #20 from Nick Clemens ---
(In reply to Katrin Fischer from comment #19)
> (In reply to Marcel de Rooy from comment #18)
> > (In reply to Jonathan Druart from comment #15)
> > > /cgi-bin/koha/catalogue/search.
> > >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #19 from Katrin Fischer ---
(In reply to Marcel de Rooy from comment #18)
> (In reply to Jonathan Druart from comment #15)
> > /cgi-bin/koha/catalogue/search.
> > pl?advsearch=1=kw=ti=kw==kw=
> > mit=_by=relevance
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #18 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #15)
> /cgi-bin/koha/catalogue/search.
> pl?advsearch=1=kw=ti=kw==kw=
> mit=_by=relevance
>
> That's starting to be ugly.
I agree that it is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #17 from Marcel de Rooy ---
> I dont understand it. You say here that the number of empty parameters
> increases?
OK Sleeping :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #16 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #15)
> (In reply to David Cook from comment #0)
> > It means that every simple search to /cgi-bin/koha/opac-search.pl from the
> > masthead will
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #14 from David Cook ---
(In reply to Marcel de Rooy from comment #13)
> Looks good to me too. But a rather intriguing question is: is there some
> script somewhere that depended somehow on the logic of removed empty
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Julian Maurice changed:
What|Removed |Added
Status|Signed Off |Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Julian Maurice changed:
What|Removed |Added
Attachment #110985|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Julian Maurice changed:
What|Removed |Added
Attachment #110986|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #10 from David Cook ---
(In reply to Fridolin SOMERS from comment #9)
> Looks like this rewite is disabled in koha-httpd.conf since Koha 3.12 ^^
I think that you and I were the ones who did that one back in the day!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #9 from Fridolin SOMERS ---
Looks like this rewite is disabled in koha-httpd.conf since Koha 3.12 ^^
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #8 from Fridolin SOMERS ---
(In reply to Katrin Fischer from comment #4)
> Frido, maybe a sign-off then? :)
Allez ;)
Tested on Strech with Koha 20.05
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Fridolin SOMERS changed:
What|Removed |Added
Attachment #110984|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Fridolin SOMERS changed:
What|Removed |Added
Attachment #105136|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Fridolin SOMERS changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #5 from Fridolin SOMERS ---
Created attachment 110984
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110984=edit
Bug 25548: (follow-up) Remove those rewrite redirects in koha-httpd.conf
In
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #4 from Katrin Fischer ---
Frido, maybe a sign-off then? :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
Fridolin SOMERS changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
David Cook changed:
What|Removed |Added
Status|NEW |Needs Signoff
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
David Cook changed:
What|Removed |Added
CC||mi...@abunchofthings.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #2 from David Cook ---
Created attachment 105136
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105136=edit
Bug 25548: Remove Apache rewrite directives that trigger redirects
Historically, we have
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #1 from David Cook ---
Also, if you have a reverse proxy in front of Apache and you proxy using HTTP
rather than HTTPS, Apache will generate fully qualified HTTP URLs for the
Redirect, which cause one of the two
47 matches
Mail list logo
