[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement adds

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed --

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #33 from Lucas Gass --- after consideringthis bug for 20.05.x I have decided not to backport this enhancement -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #31 from Jonathan Druart --- Failures reported on bug 26108 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added Blocks||26108 Referenced Bugs:

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #30 from Jonathan Druart --- Also 1. t/db_dependent/Reserves.t .. 2/63 Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Circulation.pm line 2209. 2. t/db_dependent/Circulation/issue.t .. 21/46 Use

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #29 from Jonathan Druart --- kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/SIP/Message.t t/db_dependent/SIP/Message.t .. 2/7 # Looks like you planned 29 tests but ran 5. # Failed test 'Checkin

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #28 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added Blocks||26063 Referenced Bugs:

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #27 from Tomás Cohen Arazi --- I decided to keep the 'payload' parameter so if bug 25938 adds more information we don't change the API. I hope it fulfils your requirement, Jonathan. -- You are receiving this mail

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107251|0 |1 is obsolete|

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 107251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107251=edit Bug 25855: (QA follow-up) Simplify payload This patch makes the hook be passed the

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #24 from Jonathan Druart --- At this point I'd privilege robustness and maintainability over extra calls :) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #23 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #19) > A couple of questions: > > 1. Why do we have the hook before UpdateStats and logaction? > We could imagine a plugin that want to deal with

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #20) > Additional question: what happens (and what is the expected behaviour) if > the plugin fails? They are eval-ed. -- You are receiving this

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #21 from Jonathan Druart --- (In reply to Jonathan Druart from comment #20) > Additional question: what happens (and what is the expected behaviour) if > the plugin fails? Related with patch "Bug 24031: Add safety

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #20 from Jonathan Druart --- Additional question: what happens (and what is the expected behaviour) if the plugin fails? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize changed: What|Removed |Added Blocks||25938 Referenced Bugs:

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #18 from Martin Renvoize --- I'll file a bug... it's not a trivial addition and currently, we don thave a clear use case for it.. just a 'nice to have'. Leaving this as PQA :) -- You are receiving this mail because:

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #17 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #16) > Hmm, One final question actually.. now I've started to look into utilising > the hook for AddIssue. > > Do we need to add a 'type'

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize changed: What|Removed |Added Summary|Add after_circ_hook in |Add hook to AddRenewal