https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to main |Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
--- Comment #52 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Pushed to main
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Katrin Fischer changed:
What|Removed |Added
Keywords|additional_work_needed |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
--- Comment #51 from Katrin Fischer ---
Follow-up will be pushed to main.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
--- Comment #50 from Martin Renvoize ---
Last patch attached needed on main Katrin
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Martin Renvoize changed:
What|Removed |Added
Status|ASSIGNED|Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Martin Renvoize changed:
What|Removed |Added
Status|Pushed to main |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
--- Comment #49 from Martin Renvoize ---
Created attachment 165827
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165827=edit
Bug 26297: (RM follow-up) Fix specification file
We had a duplicate 'description' key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Martin Renvoize changed:
What|Removed |Added
Keywords||additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
--- Comment #47 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Katrin Fischer changed:
What|Removed |Added
Version(s)||24.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||17505
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
--- Comment #46 from Tomás Cohen Arazi ---
*** Bug 34007 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #165453|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Tomás Cohen Arazi changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
--- Comment #44 from Pedro Amorim ---
Created attachment 165453
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165453=edit
Bug 26297: (QA follow-up): Update tests
prove t/db_dependent/api/v1/patron_categories.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Pedro Amorim changed:
What|Removed |Added
Blocks||36453
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
--- Comment #43 from Tomás Cohen Arazi ---
Pedro, I think this is missing:
* The tests shouldn't delete all data, this is bad. They should probably use
`q=` to constraint the resultset instead. And if we are trying to test the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #161487|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #161488|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #161496|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
--- Comment #42 from Tomás Cohen Arazi ---
Created attachment 165393
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165393=edit
Bug 26297: (QA follow-up) Spec fixes
This patch fixes some spec misses. To test:
1.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #161486|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #161485|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #161484|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
--- Comment #38 from Tomás Cohen Arazi ---
(In reply to Tomás Cohen Arazi from comment #36)
> * We should use Koha::V1::Patron::Categories, double plural sounds wrong
> (i.e. Patrons).
We did this all the time, nevermind :-D
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
--- Comment #37 from Tomás Cohen Arazi ---
* The change on the required permissions broke the tests
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
--- Comment #36 from Tomás Cohen Arazi ---
I've reviewed this and have a few remarks.
* I felt tempted to submit all this squashed (minor/tiny thing)
* The tests shouldn't delete all data, this is bad. They should probably use
`q=`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
Tomás Cohen Arazi changed:
What|Removed |Added
Summary|Rest API: add a route to|Add a route to list
32 matches
Mail list logo