[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_05_candidate | -- You are receiving

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2021-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Joonas Kylmälä changed: What|Removed |Added Depends on|27032 | Referenced Bugs:

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2021-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Joonas Kylmälä changed: What|Removed |Added Resolution|--- |DUPLICATE

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2021-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Joonas Kylmälä changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2021-03-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target|rel_21_05_candidate --

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Joonas Kylmälä changed: What|Removed |Added Depends on||27032 Referenced Bugs:

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 --- Comment #13 from Joonas Kylmälä --- It appears I cannot fix this bug in efficient manner until C4/Circulation.pm and C4/Reserves.pm are refactored to be more understandable. I will open new bug reports for the different

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 --- Comment #12 from Joonas Kylmälä --- The current code also doesn't check properly whether the other items can fill hold based on the transfer rules / pickup branch so gotta fix that too. -- You are receiving this mail because:

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Joonas Kylmälä changed: What|Removed |Added Assignee|joonas.kylm...@helsinki.fi

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Jonathan Druart changed: What|Removed |Added Keywords||rel_20_11_target -- You

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| --- Comment #10 from

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 --- Comment #9 from Hans Pålsson --- Yes, there are scenarios when multiple reserves has to be made on one biblio, to put it short. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 --- Comment #8 from Joonas Kylmälä --- While doing the refactoring I came across this comment > # If the count of the union of the lists of reservable items for each borrower > # is equal or greater than the number of borrowers, we

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 --- Comment #7 from Joonas Kylmälä --- (In reply to Nick Clemens from comment #6) > Trying to read the code, but there is a lot happening here, I feel this > needs unit tests > > The check for 'OK' makes sense, but some of the

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Chris Cormack changed: What|Removed |Added Attachment #111522|0 |1 is obsolete|

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Hans Pålsson changed: What|Removed |Added CC||hans.pals...@hkr.se -- You

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 --- Comment #4 from Joonas Kylmälä --- This bug seem to have been already existing when the AllowRenewalIfOtherItemsAvailable syspref was introduced in bug 11634. Already back then there was incorrect check > if (

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Joonas Kylmälä changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Joonas Kylmälä changed: What|Removed |Added Attachment #111517|0 |1 is obsolete|

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Joonas Kylmälä changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #2

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Joonas Kylmälä changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 --- Comment #1 from Joonas Kylmälä --- Created attachment 111517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111517=edit Bug 26659: Fix incorrect comparison in checkout renewability The syntax used here was

[Koha-bugs] [Bug 26659] An item can be renewed even if there are holds waiting to be filled

2020-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659 Jonathan Druart changed: What|Removed |Added CC|