[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added Status|Failed QA |In Discussion -- You

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #30 from Fridolin Somers --- (In reply to Jonathan Druart from comment #29) > Note that we should not fetch the report if ReportsLog is off. Correct. I see in execute_query() : my ( $is_sql_valid, $errors ) =

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #29 from Jonathan Druart --- Note that we should not fetch the report if ReportsLog is off. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #28 from Jonathan Druart --- There is no difficulty in writing the require tests. Let me know if you need guidance however. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #27 from Katrin Fischer --- Could we get some help here with the unit tests? Would make a real nice addition. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #26 from David Cook --- (In reply to Fridolin Somers from comment #25) > We need a unit test. > Maybe in t/db_dependent/Log.t. > > Actually there are no test for other reports actions right ? That's what I was

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #25 from Fridolin Somers --- We need a unit test. Maybe in t/db_dependent/Log.t. Actually there are no test for other reports actions right ? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au ---

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added Keywords|release-notes-needed| Version(s)|

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #22 from Katrin Fischer --- Also checked that these can be found with the log viewer tool. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Katrin Fischer changed: What|Removed |Added Attachment #118955|0 |1 is obsolete|

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Katrin Fischer changed: What|Removed |Added Attachment #118954|0 |1 is obsolete|

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Katrin Fischer changed: What|Removed |Added Attachment #118953|0 |1 is obsolete|

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added Attachment #117358|0 |1 is obsolete|

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added Attachment #117357|0 |1 is obsolete|

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added Attachment #117356|0 |1 is obsolete|

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added Attachment #117355|0 |1 is obsolete|

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #15 from Fridolin Somers --- Mhh strange rebase does not work. I simply fix my commit : Bug 27432: Update ReportsLog system preference description With patch (manually set to obsolete) : Bug 27432: (follow-up) Correct

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #14 from Katrin Fischer --- I've tried to apply patches 2 3 4 as attached, but I still have a conflict that needs to be solved by the dev: Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 27432: Add report run to

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #13 from Fridolin Somers --- (In reply to Katrin Fischer from comment #12) > I feel something is out of order here - patches don't apply in the current > sequence. > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying:

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply ---

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Kelly McElligott changed: What|Removed |Added Attachment #115927|0 |1 is obsolete|

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Kelly McElligott changed: What|Removed |Added Attachment #115926|0 |1 is obsolete|

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Kelly McElligott changed: What|Removed |Added Attachment #115184|0 |1 is obsolete|

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #8 from Owen Leonard --- Created attachment 117355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117355=edit Bug 27432: (follow-up) Correct grammar of preference description -- You are receiving

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #7 from Fridolin Somers --- (In reply to Katrin Fischer from comment #4) > Hi Frido, > > we have a fail in the QA tools here: > > FAIL C4/Reports/Guided.pm >FAIL critic > #

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #6 from Fridolin Somers --- Created attachment 115927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115927=edit Bug 27432: Update ReportsLog system preference description -- You are receiving this

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #5 from Fridolin Somers --- Created attachment 115926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115926=edit Bug 27432: (QA follow-up) fix if report_id -- You are receiving this mail because: You

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #115162|0 |1 is

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #2 from Fridolin Somers --- If accepted I'll create a patch to edit ReportsLog syspref description -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #1 from Fridolin Somers --- Created attachment 115162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115162=edit Bug 27432: Add report run to action logs Reports run should be logged in action logs.

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added Depends on||14024 Referenced Bugs:

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED

[Koha-bugs] [Bug 27432] Add report run to action logs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 Fridolin Somers changed: What|Removed |Added CC||th...@lib.auth.gr --