https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Fridolin Somers changed:
What|Removed |Added
Blocks||34689
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
Blocks||31179
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Victor Grousset/tuxayo changed:
What|Removed |Added
Blocks||30717
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Andrew Fuerste-Henry changed:
What|Removed |Added
Blocks||30909
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Fridolin Somers changed:
What|Removed |Added
Blocks||30178
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Owen Leonard changed:
What|Removed |Added
Blocks||29962
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
Blocks||29662
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
Blocks||29496
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #142 from Jonathan Druart ---
Last two patches pushed to master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #141 from Jonathan Druart ---
Created attachment 127032
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127032=edit
Bug 27526: Fix SubfieldsToUseWhenPrefill
my $a = "z";
my @x = split ( ' ', $a ) ||
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #140 from Andrew Nugged ---
Created attachment 127025
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127025=edit
Bug 27526: Fix for prefill preventing duplication 2
Prefill feature should not be in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #139 from Andrew Nugged ---
thanks! Now I am doing my build for piloting library, production, let's see
what else pops-up! :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
Keywords|additional_work_needed |
--- Comment #138 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #137 from Jonathan Druart ---
(In reply to Andrew Nugged from comment #136)
> (In reply to Jonathan Druart from comment #125)
> > Created attachment 126034 [details] [review] [review]
> > Bug 27526: Correct NULL vs empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #136 from Andrew Nugged ---
(In reply to Jonathan Druart from comment #125)
> Created attachment 126034 [details] [review]
> Bug 27526: Correct NULL vs empty string when editing
looks like we lost this one from master.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #135 from Jonathan Druart ---
Last 3 patches pushed to master!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #134 from Andrew Nugged ---
JD: we still "hotfixing" so I adding a link to the chain with your hotfixes,
this one above made it working at last on our live server.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #133 from Andrew Nugged ---
Created attachment 126393
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126393=edit
Bug 27526: Fix for prefill preventing duplication
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #132 from Jonathan Druart ---
Created attachment 126144
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126144=edit
Bug 27526: Fix 'add & duplicate item'
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #131 from Jonathan Druart ---
Created attachment 126143
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126143=edit
Bug 27526: Fix 'duplicate item'
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #130 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #129)
> Created attachment 126051 [details] [review]
> Bug 27526: (follow-up) Remove uneeded call to TransformMarcToKoha
Patch pushed to master.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #129 from Jonathan Druart ---
Created attachment 126051
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126051=edit
Bug 27526: (follow-up) Remove uneeded call to TransformMarcToKoha
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Andrew Nugged changed:
What|Removed |Added
CC||nug...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #128 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #127)
> (In reply to Jonathan Druart from comment #125)
> > When an item is edit we must keep the NULL values in DB if the input
> > have been left
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #127 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #125)
> When an item is edit we must keep the NULL values in DB if the input
> have been left empty.
I saw that before? It is presented as a fact,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #125 from Jonathan Druart ---
Created attachment 126034
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126034=edit
Bug 27526: Correct NULL vs empty string when editing
When an item is edit we must
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Kyle M Hall changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_21_11_candidate,|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
jmbroust changed:
What|Removed |Added
CC||jean-manuel.broust@univ-lyo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #124 from Jonathan Druart ---
Last 3 patches pushed to master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #123 from Jonathan Druart ---
Created attachment 125863
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125863=edit
Bug 27526: Improve robustness of tests
* Could fail if not using the original sample
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #122 from Tomás Cohen Arazi ---
Created attachment 125839
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125839=edit
Bug 27526: (QA follow-up) Wrap tests in transaction
Signed-off-by: Tomas Cohen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #121 from Jonathan Druart ---
Created attachment 125818
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125818=edit
Bug 27526: Fix perlcritic in tests
Problem while critiquing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #120 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
Blocks||26351
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
Blocks||29111
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #119 from Martin Renvoize ---
Great to see this one PQA :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #118 from Tomás Cohen Arazi ---
Ok, I already tested and signed this before.
Tests were added as requested and they pass.
All found issues by testers addressed in follow-up patches.
No QA issues.
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #117 from Tomás Cohen Arazi ---
Created attachment 125620
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125620=edit
Bug 27526: Add tests for columns_to_str and host_items
Signed-off-by: Tomas Cohen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #116 from Tomás Cohen Arazi ---
Created attachment 125619
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125619=edit
Bug 27526: Add missing POD
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #115 from Tomás Cohen Arazi ---
Created attachment 125618
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125618=edit
Bug 27526: Fix cn_source display
For an unknown reason
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #114 from Tomás Cohen Arazi ---
Created attachment 125617
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125617=edit
Bug 27526: Fix encoding issue on subfield
If you have a "é" subfield it should
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #113 from Tomás Cohen Arazi ---
Created attachment 125616
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125616=edit
Bug 27526: Remove uneeded call to TransformMarcToKoha
And also clean some imports.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #112 from Tomás Cohen Arazi ---
Created attachment 125615
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125615=edit
Bug 27526: Fix empty string vs undef
Empty strings must be removed, not inserted as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #111 from Tomás Cohen Arazi ---
Created attachment 125614
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125614=edit
Bug 27526: Fix incorrect condition
The barcode was always prefilled!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #110 from Tomás Cohen Arazi ---
Created attachment 125613
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125613=edit
Bug 27526: Fix Add multiple copies
This has been moved to Koha::Item->store by bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #109 from Tomás Cohen Arazi ---
Created attachment 125612
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125612=edit
Bug 27526: Fix Add & duplicate
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #108 from Tomás Cohen Arazi ---
Created attachment 125611
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125611=edit
Bug 27526: Fix PrefillItem
We are basically adding:
$current_item =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #107 from Tomás Cohen Arazi ---
Created attachment 125610
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125610=edit
Bug 27526: Fix mandatory and important checks
The input names have been changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #106 from Tomás Cohen Arazi ---
Created attachment 125609
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125609=edit
Bug 27526: Fix repeatable more subfields
We retrieved always the first value.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #105 from Tomás Cohen Arazi ---
Created attachment 125608
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125608=edit
Bug 27526: Improve grep for date fields
'replacementpricedate' should not catch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #104 from Tomás Cohen Arazi ---
Created attachment 125607
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125607=edit
Bug 27526: Adjust code to use Koha::Items
Not that we removed all the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #103 from Tomás Cohen Arazi ---
Created attachment 125606
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125606=edit
Bug 27526: Remove AddItemFromMarc from additem
Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #102 from Tomás Cohen Arazi ---
Created attachment 125605
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125605=edit
Bug 27526: Remove ModItemFromMarc from additem
Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123771|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123770|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123769|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123768|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123767|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123766|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123765|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123764|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123763|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123762|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123761|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123760|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123759|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123758|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123757|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #125069|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
Attachment #123772|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #100 from Martin Renvoize ---
I tested pretty thoroughly but will admit this isn't an area I'm most familiar
with.
Added my SO line to all the patches.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #123415|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #123329|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #123110|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #123007|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #123006|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #122959|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #122958|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #122954|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #122953|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #122952|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #122951|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #122950|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #122949|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #122948|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #122947|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Martin Renvoize changed:
What|Removed |Added
Attachment #122946|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Nick Clemens changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #83 from Jonathan Druart ---
txn_begin was missing.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
Attachment #123372|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #81 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #79)
> I will provide the missing tests next week. Thanks for the reminder!
Done!
And I found a bug, so tests++ :)
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #80 from Jonathan Druart ---
Created attachment 123372
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123372=edit
Bug 27526: Add tests for columns_to_str and host_items
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #79 from Jonathan Druart ---
I will provide the missing tests next week. Thanks for the reminder!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #78 from Jonathan Druart ---
Created attachment 123329
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123329=edit
Bug 27526: Add missing POD
--
You are receiving this mail because:
You are watching
1 - 100 of 202 matches
Mail list logo
