[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.04

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #45 from Jonathan Druart --- follow-up pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #44 from Martin Renvoize --- Created attachment 117476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117476=edit Bug 27680: (QA follow-up) Update test for dbic_merge_sorting The order_by handling

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #43 from Jonathan Druart --- We have a test that is failing: # Failed test 'exact match for JSON Pointer "/order_by"' # at t/Koha/REST/Plugin/Query.t line 338. # Structures begin differing at: #

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #42 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #41 from Jonathan Druart --- Created attachment 117442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117442=edit Bug 27680: Add support for param[] syntax While not that common nowadays, it is the

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #40 from Jonathan Druart --- Created attachment 117441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117441=edit Bug 27680: Allow traditional multi-params to work This patch allows the preceeding

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #39 from Jonathan Druart --- Created attachment 117440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117440=edit Bug 27680: Add tests for various ways of passing multi-params This patch adds unit

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #38 from Jonathan Druart --- Created attachment 117439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117439=edit Bug 27680: Add support for sorting fields with multiple data points This patch adds

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Jonathan Druart changed: What|Removed |Added Attachment #117389|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 117394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117394=edit Bug 27680: (QA follow-up) Minor perlcritic issue Signed-off-by: Tomas Cohen Arazi

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 117393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117393=edit Bug 27680: Add support for param[] syntax While not that common nowadays, it is the

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 117392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117392=edit Bug 27680: Allow traditional multi-params to work This patch allows the preceeding

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 117391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117391=edit Bug 27680: Add tests for various ways of passing multi-params This patch adds unit

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 117390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117390=edit Bug 27680: Add support for sorting fields with multiple data points This patch adds

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 117389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117389=edit Bug 27680: Take first order column for ordering Signed-off-by: Tomas Cohen Arazi

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Tomás Cohen Arazi changed: What|Removed |Added Attachment #117335|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Tomás Cohen Arazi changed: What|Removed |Added Attachment #117339|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Tomás Cohen Arazi changed: What|Removed |Added Attachment #117338|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Tomás Cohen Arazi changed: What|Removed |Added Attachment #117337|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Tomás Cohen Arazi changed: What|Removed |Added Attachment #117336|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Blocks||27807 Referenced Bugs:

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #29 from Martin Renvoize --- I've moved the followup bugs to try and render exceptions more cleanly to another bug now.. I'd really like to get this bug unblocked so the dependant cash management bug can start moving

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #117375|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #117340|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Blocks||27806 Referenced Bugs:

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #117341|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #27 from Martin Renvoize --- Created attachment 117341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117341=edit Bug 27680: (follow-up) Attempt to catch the exception Help: I'm struggling to catch

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #26 from Martin Renvoize --- Created attachment 117340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117340=edit Bug 27680: (follow-up) Add Koha::Exception for bad queries This patch adds a

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #116846|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #116845|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #116843|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #116844|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #116795|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #20 from Martin Renvoize --- This is the most pragmatic solution I could come up with. * We set the datatable wrapper to send _order_by as a comma delimited string of fields. * We update the collectionFormat spec to

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #116833|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #116832|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #19 from Martin Renvoize --- Created attachment 116846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116846=edit Bug 27680: Allow traditional multi-params to work This patch allows the preceeding

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #116834|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #17 from Martin Renvoize --- Created attachment 116844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116844=edit Bug 27680: Add support for sorting fields with multiple data points This patch adds

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #116831|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #15 from Jonathan Druart --- Actually I forgot to restart_all. Now the table does not display at all OpenAPI <<< GET api/v1/cities [{"message":"Expected array - got string.","path":"\/_order_by"}] -- You are

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #14 from Jonathan Druart --- It does not work for me. https://snipboard.io/tzlfnE.jpg generates: /api/v1/cities?&_page=1&_per_page=20=%5B%5D&_match=contains&_order_by=-me.city_id -- You are receiving this mail

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added CC||agustinmoy...@theke.io,

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #13 from Martin Renvoize --- As the final tests expose.. this raises a question. What form of 'multi-param' sending do we actually want to support? Prior to my patches we were "in theory" limiting to pipe delimited

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Status|NEW |In Discussion -- You

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #12 from Martin Renvoize --- Created attachment 116834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116834=edit Bug 27680: Add tests for various ways of passing multi-params -- You are receiving

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #11 from Martin Renvoize --- Created attachment 116833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116833=edit Bug 27680: Make collectionFormat open for order_by -- You are receiving this mail

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #116829|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Attachment #116796|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #8 from Martin Renvoize --- Still working here.. I found a series of little bugs and am writing some extra unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #7 from Martin Renvoize --- Created attachment 116829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116829=edit Bug 27680: Add multi-field support -- You are receiving this mail because: You are the

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > (In reply to Jonathan Druart from comment #3) > > Created attachment 116796 [details] [review] [review] > > Bug 27680: Take first order column

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #5 from Martin Renvoize --- (In reply to Jonathan Druart from comment #4) > (In reply to Jonathan Druart from comment #3) > > Created attachment 116796 [details] [review] [review] > > Bug 27680: Take first order column

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > Created attachment 116796 [details] [review] > Bug 27680: Take first order column for ordering We can go with this patch for now. Are the

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Jonathan Druart changed: What|Removed |Added Attachment #116794|0 |1 is obsolete|

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #2 from Jonathan Druart --- Created attachment 116795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116795=edit Bug 27680: [DO NOT PUSH] Example patch on cities -- You are receiving this mail

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #1 from Jonathan Druart --- Created attachment 116794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116794=edit :x Bug 27680: Take first order column for ordering -- You are receiving this mail

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added Blocks||26273 Referenced Bugs:

[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Martin Renvoize changed: What|Removed |Added CC|