https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Andrew Fuerste-Henry changed:
What|Removed |Added
Blocks||30909
Referenced Bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Nick Clemens changed:
What|Removed |Added
Blocks||28832
Referenced Bugs:
htt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Andrew Fuerste-Henry changed:
What|Removed |Added
Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Fridolin Somers changed:
What|Removed |Added
Version(s)|21.05.00|21.05.00,20.11.06
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #49 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #48 from Jonathan Druart ---
Last patch will be squashed when pushed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #46 from Martin Renvoize ---
Created attachment 121052
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121052&action=edit
Bug 27837: (QA follow-up) Minor Spelling/Typo correction
Signed-off-by: Martin R
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Martin Renvoize changed:
What|Removed |Added
Attachment #120832|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Martin Renvoize changed:
What|Removed |Added
Attachment #120629|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Martin Renvoize changed:
What|Removed |Added
Attachment #120616|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Martin Renvoize changed:
What|Removed |Added
Attachment #120566|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Martin Renvoize changed:
What|Removed |Added
Attachment #120565|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Martin Renvoize changed:
What|Removed |Added
Attachment #120564|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Martin Renvoize changed:
What|Removed |Added
Attachment #120563|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Martin Renvoize changed:
What|Removed |Added
Attachment #120562|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #37 from Nick Clemens ---
Created attachment 120832
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120832&action=edit
Bug 27837: (follow-up) Do not check subfield unless tag defined
This was causing ex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #36
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Nick Clemens changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Kyle M Hall changed:
What|Removed |Added
Attachment #120628|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #34 from Kyle M Hall ---
Created attachment 120628
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120628&action=edit
Bug 27837: Always pass permanent location from items editor if it was defined
By alw
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #33 from Kyle M Hall ---
Created attachment 120616
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120616&action=edit
Bug 27837: Check the MARC directly, not the transformed item
If permanent location i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #32 from Nick Clemens ---
(In reply to Katrin Fischer from comment #26)
> (In reply to Jonathan Druart from comment #20)
> > Can you explain this follow-up, Kyle?
> > What's the use case, how did you find it?
> > We certa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #31 from Nick Clemens ---
Created attachment 120566
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120566&action=edit
Bug 27837: Permanent location to be empty string, check if key exists
Signed-off-by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #30 from Nick Clemens ---
Created attachment 120565
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120565&action=edit
Bug 27837: Unit tests for blank permanent location
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #29 from Nick Clemens ---
Created attachment 120564
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120564&action=edit
Bug 27837: Prevent the tests to fail is the field is mapped
Signed-off-by: Tomas Co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #28 from Nick Clemens ---
Created attachment 120563
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120563&action=edit
Bug 27837: Add unit tests
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Rhond
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Nick Clemens changed:
What|Removed |Added
Attachment #120361|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #26
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What|Removed |Added
Attachment #117738|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What|Removed |Added
Attachment #117730|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What|Removed |Added
Attachment #117729|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What|Removed |Added
Attachment #117728|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
Patch complexi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #21 from Katrin Fischer ---
I've tested, QA script and unit tests pass.
Also the following test plan checks out:
Test plan:
1 - Map permanent_location to a marc field
2 - Expose that field in the item editor
3 - Edit a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #20 from Jonathan Druart
---
Can you explain this follow-up, Kyle?
What's the use case, how did you find it?
We certainly need a couple of tests to cover it.
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Kyle M Hall changed:
What|Removed |Added
Attachment #117735|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Kyle M Hall changed:
What|Removed |Added
Status|Passed QA |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #18 from Kyle M Hall ---
Created attachment 117735
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117735&action=edit
Bug 27837: Permanent location to be empty string, check if defined
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #17 from Tomás Cohen Arazi ---
Created attachment 117730
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117730&action=edit
Bug 27837: Prevent the tests to fail is the field is mapped
Signed-off-by: Tom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #16 from Tomás Cohen Arazi ---
Created attachment 117729
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117729&action=edit
Bug 27837: Add unit tests
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #15 from Tomás Cohen Arazi ---
Created attachment 117728
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117728&action=edit
Bug 27837: Update permanent location if passed into ModItemFromMarc
Signed-off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #117628|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #117627|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #117634|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #13 from Jonathan Druart
---
Created attachment 117634
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117634&action=edit
Bug 27837: Prevent the tests to fail is the field is mapped
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #12 from Jonathan Druart
---
Indeed, bug 27545 is only about item creation!
The fix looks a bit weird but I didn't find some better, I've tried to fix at
Koha::Item->store level but we definitely need to tell the column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #117626|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #117625|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #117570|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #117572|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comme
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Andrew Fuerste-Henry changed:
What|Removed |Added
CC||and...@bywatersolutio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #4 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #1)
> Can you have a look at bug 27545? I feel like the second patch will fix this.
It does not. I ran some manual tests that failed, and also ran the uni
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #3 from Kyle M Hall ---
Created attachment 117572
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117572&action=edit
Bug 27837: Add unit tests
--
You are receiving this mail because:
You are watching a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
--- Comment #2 from Kyle M Hall ---
Created attachment 117570
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117570&action=edit
Bug 27837: Update permanent location if passed into ModItemFromMarc
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837
Nick Clemens changed:
What|Removed |Added
Depends on||23463
Assignee|koh
66 matches
Mail list logo