[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Jonathan Druart changed: What|Removed |Added Blocks||31032 Referenced Bugs:

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Nick Clemens changed: What|Removed |Added Blocks||31005 Referenced Bugs:

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Jonathan Druart changed: What|Removed |Added Blocks||28516 --- Comment #40

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #39 from Jonathan Druart --- Master_D9_My8 586 Docker_7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #38 from Jonathan Druart --- Got it locally t/db_dependent/Koha/Patrons.t ... 28/42 # No tests run! #

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #37 from Jonathan Druart --- Hum, failure on Jenkins Master_D9 run 1663 11:41:11 koha_1 | [0m[92mKoha::Exceptions::Patron::MissingMandatoryExtendedAttribute[0m { 11:41:11 koha_1 | Parents

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu --

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #35 from Jonathan Druart --- Last two patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #34 from Jonathan Druart --- Created attachment 119938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119938=edit Bug 27857: Remove unecessary âttribute_type3 var It could be created with mandatory=1

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #33 from Jonathan Druart --- Created attachment 119937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119937=edit Bug 27857: Start a transaction foreach subtest There is a random failure #

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #32 from Jonathan Druart --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #31 from Jonathan Druart --- Created attachment 119443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119443=edit Bug 27857: Fix Pseudonymization.t t/db_dependent/Koha/Pseudonymization.t .. 2/3 #

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #30 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 119040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119040=edit Bug 27857: (follow-up) Use a more fine-grained exception for mandatory attributes On

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Tomás Cohen Arazi changed: What|Removed |Added Attachment #119009|0 |1 is obsolete|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 119038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119038=edit Bug 27857: Get the right column This patch makes the search for mandatory attribute

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 119009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119009=edit Bug 27857: (use-it-in-real-life follow-up) Use a more fine-grained exception for

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Tomás Cohen Arazi changed: What|Removed |Added Depends on||28056 Referenced

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Tomás Cohen Arazi changed: What|Removed |Added Blocks||28009 Referenced

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Tomás Cohen Arazi changed: What|Removed |Added Blocks||23666 Referenced

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27956 Referenced

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #26 from Jonathan Druart --- I don't know exactly what needs to be done, but there are check above, see the block with "ERROR_extended_unique_id_failed_code". Also the repeatable is not checked in the controller, only

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #25 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #22) > It does not convince me. > > members/memberentry.pl > 592 $patron->extended_attributes($extended_patron_attributes); > > may

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #24 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #18) > (In reply to Martin Renvoize from comment #17) > > I'm happy to PQA on Tomas's patches but would like him to verify my final > > followup.

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #23 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #22) > It does not convince me. > > members/memberentry.pl > 592 $patron->extended_attributes($extended_patron_attributes); > > may

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #22 from Jonathan Druart --- It does not convince me. members/memberentry.pl 592 $patron->extended_attributes($extended_patron_attributes); may raise an uncaught exceptions. -- You are receiving this

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #21 from Martin Renvoize --- (In reply to Jonathan Druart from comment #20) > Aren't we going to adjust the controllers? I had a brief check of these at the time.. I believe currently the case is that the controller

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #20 from Jonathan Druart --- Aren't we going to adjust the controllers? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #17) > I'm happy to PQA on Tomas's patches but would like him to verify my final > followup. I like the follow-up. Go ahead! -- You are

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #17 from Martin Renvoize --- I'm happy to PQA on Tomas's patches but would like him to verify my final followup. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Martin Renvoize changed: What|Removed |Added Attachment #117953|0 |1 is obsolete|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Martin Renvoize changed: What|Removed |Added Attachment #117947|0 |1 is obsolete|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Martin Renvoize changed: What|Removed |Added Attachment #117946|0 |1 is obsolete|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Martin Renvoize changed: What|Removed |Added Attachment #117945|0 |1 is obsolete|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Martin Renvoize changed: What|Removed |Added Attachment #117948|0 |1 is obsolete|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 David Nind changed: What|Removed |Added Attachment #117938|0 |1 is obsolete|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 David Nind changed: What|Removed |Added Attachment #117711|0 |1 is obsolete|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 David Nind changed: What|Removed |Added Attachment #117710|0 |1 is obsolete|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 David Nind changed: What|Removed |Added Attachment #117709|0 |1 is obsolete|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #7 from Martin Renvoize --- Created attachment 117938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117938=edit Bug 27857: Add handling for globally mandatory attributes This patch adds handling for

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #6 from Martin Renvoize --- The more I think about this, the more I think perhaps that 'mandatory' is a purely UI concept in this case. I can see all sorts of reasons you may have added mandatory attributes.. but

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #5 from Martin Renvoize --- # Get a list of required attributes my $required_attribute_types = Koha::Patron::Attribute::Types->search_with_library_limits( { mandatory => 1 }, {},

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Martin Renvoize changed: What|Removed |Added Depends on|27833 | Referenced Bugs:

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 117711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117711=edit Bug 27857: Make Koha::Patron->extended_attributes validate data This patch makes the

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 117710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117710=edit Bug 27857: Regression tests This patch adds regression tests for the changed

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 117709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117709=edit Bug 27857: Move extended_attributes tests to Koha/Patron.t They really belong here.

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27858 Referenced

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27833 Referenced

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27853 Referenced