[Koha-bugs] [Bug 27944] Add new stages to the article request process

2022-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Caroline Cyr La Rose changed: What|Removed |Added Keywords|Manual |

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 David Nind changed: What|Removed |Added Keywords||Manual CC|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-10-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #97 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #96) > Created attachment 125813 [details] [review] > Bug 27944: Add fr-FR AR_REQUESTED notice > > This patch adds the missing notice. > >

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #96 from Tomás Cohen Arazi --- Created attachment 125813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125813=edit Bug 27944: Add fr-FR AR_REQUESTED notice This patch adds the missing notice.

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29182 Referenced

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #94 from Jonathan Druart --- Created attachment 125762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125762=edit Bug 27944: Fix t/db_dependent/AuthorisedValues.t # Failed test 'The second category

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #93 from Jonathan Druart --- xt/sample_notices.t 1/? # Failed test 'No sample notice to add' # at xt/sample_notices.t line 86. # Sample notices to add in fr-FR/1-Obligatoire/sample_notices.sql:

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #92 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #91 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #90) > (In reply to Jonathan Druart from comment #84) > > 4. Not a big deal (not blocker of course) but > > $reason = $av->lib_opac ?

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #90 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #84) > 1. Missing POD in Koha::ArticleRequest Done. > 2. Koha::ArticleRequest->request is not covered by tests Done. > 3. Changes to

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125565|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Passed QA -- You are

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #88 from Tomás Cohen Arazi --- Created attachment 125565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125565=edit Bug 27944: Add missing tests Signed-off-by: Tomas Cohen Arazi -- You are

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #87 from Jonathan Druart --- Can be done on a follow-up bug, yes. But I will wait for the tests to push. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #86 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #84) > 1. Missing POD in Koha::ArticleRequest > > 2. Koha::ArticleRequest->request is not covered by tests > > 3. Changes to

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #85 from Tomás Cohen Arazi --- Created attachment 125544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125544=edit Bug 27944: (follow-up) Add POD The library didn't contain real POD. This patch adds

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #83 from Marcel de Rooy --- Our old friend: FAIL valid_template Attempt to reload Koha/Template/Plugin/Biblio.pm aborted. Compilation failed in require at

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #82 from Tomás Cohen Arazi --- Created attachment 125158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125158=edit Bug 27944: (QA follow-up) Make atomic update idempotent This patch checks the DB

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27945 Depends

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #81 from Tomás Cohen Arazi --- (In reply to Nick Clemens from comment #80) > (In reply to Marcel de Rooy from comment #68) > > If bug 27945 might pass before this one, we could add here: > > > > +++ b/Koha/Patron.pm > >

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27945 Referenced

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed --

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #80 from Nick Clemens --- (In reply to Marcel de Rooy from comment #68) > If bug 27945 might pass before this one, we could add here: > > +++ b/Koha/Patron.pm > @@ -975,7 +975,7 @@ sub can_request_article { > > -

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #79 from Nick Clemens --- Created attachment 124976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124976=edit Bug 27944: (QA follow-up) Add span to fix pipe separator Signed-off-by: Nick Clemens --

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123952|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123951|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123950|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123949|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123948|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123947|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123946|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123945|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123944|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Attachment #123943|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #68 from Marcel de Rooy --- If bug 27945 might pass before this one, we could add here: +++ b/Koha/Patron.pm @@ -975,7 +975,7 @@ sub can_request_article { -{ borrowernumber => $self->borrowernumber, status => {

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Attachment #123712|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Attachment #123711|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Attachment #123710|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Attachment #122990|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Attachment #122989|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Attachment #122988|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Attachment #122987|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Attachment #122986|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Attachment #122985|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Attachment #122984|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #57 from Katrin Fischer --- Hm, I am not sure how clear that is from the naming, although I understand the intention better now. A little worried about the terminology clashing with what we have for holds in translation.

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #56 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #55) > Been following the comments here all day and keep wondering - what are the > new status named? > > I have seen new and pending - but they kind

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #55 from Katrin Fischer --- Been following the comments here all day and keep wondering - what are the new status named? I have seen new and pending - but they kind of are the same to me? -- You are receiving this

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #54 from Tomás Cohen Arazi --- Marcel, I think I addressed the issues you highlighted. - Tests pass (they weren't passing) - Renamed 'open' to set_pending/pending. We could even open a new bug report to refactor the

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #53 from Tomás Cohen Arazi --- Created attachment 123712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123712=edit Bug 27944: (QA follow-up) Make staff home page show new article requests As exposed

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #52 from Tomás Cohen Arazi --- Created attachment 123711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123711=edit Bug 27944: (QA follow-up) Rename ->open for ->set_pending Signed-off-by: Tomas Cohen

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #51 from Tomás Cohen Arazi --- Created attachment 123710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123710=edit Bug 27944: REQUESTED is the new default status Signed-off-by: Tomas Cohen Arazi --

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #50 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #48) > (In reply to Tomás Cohen Arazi from comment #47) > > (In reply to Marcel de Rooy from comment #46) > > > > > > But note also that Agustin

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #49 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #46) > But note also that Agustin still needs to respond to comment41. This is not > fixed yet. Or comment31 ? -- You are receiving this mail

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #48

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff ---

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #46 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #45) Thx for giving it another try! My first qa tools run here again: Attempt to reload Koha/Template/Plugin/Biblio.pm aborted. Compilation failed

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-08-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #45 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #18) > Last question before I really let this go: Should we actually allow includes > to do [% USE Biblio %] etc. or should we 'use' them already

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #44 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #43) > (In reply to Jonathan Druart from comment #42) > > Tomas asked me to look at the following QA errors: > > > > Prototype mismatch: sub

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #43 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #42) > Tomas asked me to look at the following QA errors: > > Prototype mismatch: sub Koha::ArticleRequest::Status::Completed: none vs () > at

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #42 from Jonathan Druart --- Tomas asked me to look at the following QA errors: Prototype mismatch: sub Koha::ArticleRequest::Status::Completed: none vs () at /usr/share/perl/5.28/constant.pm line 171.

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #41 from Marcel de Rooy --- (In reply to Agustín Moyano from comment #39) > > TODO The staff home page does no longer show New requests. It shows pending > > requests. > > Hi Marcel, sorry about that.. Set request as

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #40 from Marcel de Rooy --- FAIL valid_template Attempt to reload Koha/Template/Plugin/Biblio.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #39 from Agustín Moyano --- (In reply to Marcel de Rooy from comment #31) > Note comment24 (maybe Tomas could have a look too?) > Note comment29 > > And a few other points needing attention still: > > TODO Behavior of

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #38 from Agustín Moyano --- Created attachment 122990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122990=edit Bug 27944: (follow-up) Move statuses to constants -- You are receiving this mail

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #37 from Agustín Moyano --- Created attachment 122989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122989=edit Bug 27944: (follow-up) Move existing statuses, rename idempotent -- You are receiving

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #36 from Agustín Moyano --- Created attachment 122988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122988=edit Bug 27944: (follow-up) Improving consistency between notice names -- You are receiving

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #35 from Agustín Moyano --- Created attachment 122987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122987=edit Bug 27944: Add missing Status module Test plan: perl -c the module or run qa tools

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #34 from Agustín Moyano --- Created attachment 122986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122986=edit Bug 27944: Add "requested" stage in article request process This patch adds the stage

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #33 from Agustín Moyano --- Created attachment 122985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122985=edit Bug 27944: Add AR_REQUESTED message in sample_notices.yml and modify AR_PENDING -- You

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Agustín Moyano changed: What|Removed |Added Attachment #122836|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #31

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #30 from Marcel de Rooy --- Created attachment 122857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122857=edit Bug 27944: (follow-up) Move statuses to constants -- You are receiving this mail

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #29 from Marcel de Rooy --- The 'open' function is in both the perl code and the js code, now refers to setting to pending status. I think that this will lead to confusion and potential future bugs. Why not call it

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #28 from Marcel de Rooy --- -`name` = 'Article requested' +`name` = REPLACE(name, '- open', '- new') Might be safer when touching translated notices. Added a follow-up for making the names

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |BLOCKED -- You are

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #27 from Marcel de Rooy --- Changing status temporarily, finishing this tomorrow -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #26 from Marcel de Rooy --- Created attachment 122843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122843=edit Bug 27944: (follow-up) Move existing statuses, rename idempotent -- You are receiving

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #25 from Marcel de Rooy --- Created attachment 122842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122842=edit Bug 27944: (follow-up) Improving consistency between notice names -- You are receiving

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #24 from Marcel de Rooy --- We still have this stubborn warn from qa tools and unfortunately it is still unclear what the exact cause is: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt FAIL

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #23 from Agustín Moyano --- Created attachment 122839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122839=edit Bug 27944: Add missing Status module Test plan: perl -c the module or run qa tools

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #22 from Agustín Moyano --- Created attachment 122838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122838=edit Bug 27944: Add "requested" stage in article request process This patch adds the stage

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #21 from Agustín Moyano --- Created attachment 122837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122837=edit Bug 27944: Add AR_REQUESTED message in sample_notices.yml and modify AR_PENDING -- You

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Agustín Moyano changed: What|Removed |Added Attachment #119020|0 |1 is obsolete|

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #19 from Marcel de Rooy --- Created attachment 122673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122673=edit Bug 27944: Add missing Status module Test plan: perl -c the module or run qa tools

[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #18 from Marcel de Rooy --- Last question before I really let this go: Should we actually allow includes to do [% USE Biblio %] etc. or should we 'use' them already earlier in the process, in other words at the top of

  1   2   >