https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #47 from Marcel de Rooy ---
+{ borrowernumber => $self->borrowernumber, status => { '!=' =>
['CANCELED','COMPLETED'] } },
[2021/08/31 12:59:03] [WARN] SQL::Abstract::belch():
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #46 from Marcel de Rooy ---
There is a functional dependency between this report and 27944.
See bug 27944#68
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #45 from Marcel de Rooy ---
(In reply to Agustín Moyano from comment #43)
> Hi Marcel,
>
> I removed dependency on bug 27946, implemented the check in comment 25 (with
> a minor modification), and addressed issues in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #44
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #43 from Agustín Moyano ---
Hi Marcel,
I removed dependency on bug 27946, implemented the check in comment 25 (with a
minor modification), and addressed issues in comment 26 (that I believe it was
due to a merge when I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Agustín Moyano changed:
What|Removed |Added
Attachment #124078|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #41 from Agustín Moyano ---
Created attachment 124078
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124078=edit
Bug 27945: (follow-up) fix limit check in Patron.pm, regexp in categories.pl
and removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #40 from Agustín Moyano ---
Created attachment 124077
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124077=edit
Bug 27945: (follow-up) Fix column header title and edit form label
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #39 from Agustín Moyano ---
Created attachment 124076
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124076=edit
Bug 27945: (QA follow-up) Fix exception POD
Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #38 from Agustín Moyano ---
Created attachment 124075
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124075=edit
Bug 27945: Add limit article request feature
This patch makes it possible to limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #37 from Agustín Moyano ---
Created attachment 124074
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124074=edit
Bug 27945: [DO NOT PUSH] Update DBIx schema
Signed-off-by: David Nind
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #36 from Agustín Moyano ---
Created attachment 124073
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124073=edit
Bug 27945: Add article_request_limit in categories table
Signed-off-by: David Nind
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Agustín Moyano changed:
What|Removed |Added
Attachment #124066|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Agustín Moyano changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Agustín Moyano changed:
What|Removed |Added
Depends on|27946 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #34 from Agustín Moyano ---
Created attachment 124071
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124071=edit
Bug 27945: (follow-up) Fix column header title and edit form label
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #33 from Agustín Moyano ---
Created attachment 124070
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124070=edit
Bug 27945: (QA follow-up) Fix exception POD
Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #32 from Agustín Moyano ---
Created attachment 124069
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124069=edit
Bug 27945: Add limit article request feature
This patch makes it possible to limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #31 from Agustín Moyano ---
Created attachment 124068
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124068=edit
Bug 27945: [DO NOT PUSH] Update DBIx schema
Signed-off-by: David Nind
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #30 from Agustín Moyano ---
Created attachment 124067
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124067=edit
Bug 27945: Add article_request_limit in categories table
Signed-off-by: David Nind
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Agustín Moyano changed:
What|Removed |Added
Attachment #123774|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #28 from Marcel de Rooy ---
Overall: Looks good to me.
Discussion item in comment25.
Needs a few small adjustments for comment24, comment26 and comment27.
Note that the dependency on 27946 is unfortunate. This could
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #27 from Marcel de Rooy ---
} elsif ($article_request_limit ne '' && $article_request_limit !~ /\d+/) {
If I add 2a in the limit field (fool proof), the form says that I successfully
updated the record. But actually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #26 from Marcel de Rooy ---
diff --git a/Koha/ArticleRequest.pm b/Koha/ArticleRequest.pm
index e79e01610c..078f00bc70 100644
--- a/Koha/ArticleRequest.pm
+++ b/Koha/ArticleRequest.pm
@@ -27,7 +27,9 @@ use Koha::Items;
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #25 from Marcel de Rooy ---
Side note
Currently we use the following custom check to limit numbers:
my $compdate = dt_from_string->add( days => -1 );
my $count = Koha::ArticleRequests->search([
{ borrowernumber =>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #24 from Marcel de Rooy ---
Koha::Patron
+my $count = Koha::ArticleRequests->search({
+borrowernumber => $self->borrowernumber,
+status => {'!=' => 'CANCELED'},
+created_on => {
+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #23 from Marcel de Rooy ---
FAIL Koha/Exceptions/ArticleRequest.pm
FAIL pod coverage
POD is missing for 'description'
False negative
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #22 from Agustín Moyano ---
Created attachment 123820
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123820=edit
Bug 27945: (follow-up) Fix column header title and edit form label
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #21 from Agustín Moyano ---
(In reply to David Nind from comment #20)
> One minor thing I noted after signing off.
>
> The column heading in patron categories is 'Maximum request limit' and the
> edit form says 'Maximum
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #20 from David Nind ---
One minor thing I noted after signing off.
The column heading in patron categories is 'Maximum request limit' and the edit
form says 'Maximum article scan requests'.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
David Nind changed:
What|Removed |Added
Text to go in the||This enhancement lets you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
David Nind changed:
What|Removed |Added
Attachment #123715|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
David Nind changed:
What|Removed |Added
Attachment #123714|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
David Nind changed:
What|Removed |Added
Attachment #123219|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
David Nind changed:
What|Removed |Added
Attachment #123218|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
David Nind changed:
What|Removed |Added
Attachment #123217|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #14 from Tomás Cohen Arazi ---
Created attachment 123715
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123715=edit
Bug 27945: (QA follow-up) Fix exception POD
Signed-off-by: Tomas Cohen Arazi
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #123220|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #12 from Marcel de Rooy ---
FAIL opac/opac-request-article.pl
OK critic
FAIL forbidden patterns
forbidden pattern: Use of Data::Printer, should only be used
for devlopment purpose (line 85)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #11 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #10)
> (In reply to Marcel de Rooy from comment #9)
> > On top of 27946:
> >
> > Applying: Bug 27945: Add tests
> > Using index info to reconstruct a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Marcel de Rooy changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Agustín Moyano changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #5 from Tomás Cohen Arazi ---
Maybe 'article_request_daily_limit'?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #4 from Agustín Moyano ---
Created attachment 123220
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123220=edit
Bug 27945: Add limit article request feature
This patch makes it possible to limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #3 from Agustín Moyano ---
Created attachment 123219
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123219=edit
Bug 27945: [DO NOT PUSH] Update DBIx schema
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #2 from Agustín Moyano ---
Created attachment 123218
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123218=edit
Bug 27945: Add article_request_limit in categories table
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #1 from Agustín Moyano ---
Created attachment 123217
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123217=edit
Bug 27945: Add tests
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Agustín Moyano changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Agustín Moyano changed:
What|Removed |Added
Depends on||27946
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Agustín Moyano changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Tomás Cohen Arazi changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Tomás Cohen Arazi changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Nick Clemens changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
61 matches
Mail list logo
