[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #39 from Lucas Gass --- > That's really odd.. that should be an idempotent action surely!? I opened Bug 35950 to continue to discuss this. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #38 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #37) > In hindsight it seems very strange to me to put an AddReturn in a sub that > you should use to just know if a book can be issued? See

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What|Removed |Added Blocks||35840 Referenced Bugs:

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Emily Lamancusa changed: What|Removed |Added Blocks||35751 Referenced Bugs:

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Pedro Amorim changed: What|Removed |Added Resolution|--- |FIXED CC|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #36 from Fridolin Somers --- Fixed test suite, AddIssue still uses unblessed patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #35 from Fridolin Somers --- Created attachment 158900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158900=edit Bug 27992: [23.05] (follow-up) Fix unit test with unblessed patron -- You are

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Fridolin Somers changed: What|Removed |Added Version(s)|23.11.00|23.11.00,23.05.06

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #33 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #32 from Katrin Fischer --- Created attachment 158465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158465=edit Bug 27992: (QA follow-up) Terminology: returned -> checked in Signed-off-by: Katrin

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #31 from Katrin Fischer --- Created attachment 158464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158464=edit Bug 27992: (QA follow-up) Perltidy Signed-off-by: Katrin Fischer -- You are

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer changed: What|Removed |Added Attachment #158217|0 |1 is obsolete|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer changed: What|Removed |Added Attachment #158216|0 |1 is obsolete|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #28 from Katrin Fischer --- 1) Perltidied in a follow-up to make the tests pass. Please remember to run QA test tools and perltidy your code. 2) Ternary operator needed? +my $block_lost_return =

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Emily Lamancusa changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Emily Lamancusa changed: What|Removed |Added Attachment #158086|0 |1 is obsolete|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Emily Lamancusa changed: What|Removed |Added Attachment #158073|0 |1 is obsolete|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What|Removed |Added Attachment #128633|0 |1 is obsolete|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What|Removed |Added Attachment #158011|0 |1 is obsolete|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What|Removed |Added Attachment #146041|0 |1 is obsolete|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #21 from Emily Lamancusa --- Ooh, good point. I was thinking that AddReturn had all of that covered, but the last time I looked at this I missed the fact that AddReturn would only get called if the item had a current

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #20 from Lucas Gass --- I'm finding plenty of other issues here that I think might need to be addressed when checking out to a statistical patron: 1. If there is a hold on the item that is checked in to a stats patron

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #19

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #18 from Emily Lamancusa --- It sounds like the plan to (1) respect BlockReturnOfLostItems, (2) ask for confirmation when recording local use on a lost item if it is not blocked, and (3) resolve any return claims on the

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Emily Lamancusa changed: What|Removed |Added CC|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Felicity Brown changed: What|Removed |Added CC|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #16 from Donna --- (In reply to Lucas Gass from comment #15) > > In marked my item lost using the 'claims returned' feature. With this change > > the item will be returned and the claim remains unresolved. Is this an >

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |In Discussion -- You are

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #15 from Lucas Gass --- > In marked my item lost using the 'claims returned' feature. With this change > the item will be returned and the claim remains unresolved. Is this an issue? In this case should we return the

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What|Removed |Added Attachment #128634|0 |1 is obsolete|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What|Removed |Added Status|Failed QA |Patch doesn't apply ---

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #12

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Nick Clemens changed: What|Removed |Added Attachment #127189|0 |1 is obsolete|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #10 from Nick Clemens --- Created attachment 128633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128633=edit Bug 27992: Unit test Signed-off-by: Nick Clemens -- You are receiving this mail

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Martin Renvoize changed: What|Removed |Added Attachment #126865|0 |1 is obsolete|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #6 from Donna --- Works as expected! Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Donna changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #5 from Lucas Gass --- Created attachment 126865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126865=edit Bug 27992: Call AddReturn if borrower is statistical patron To test: 1. Create a Statistical

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Andrew Fuerste-Henry changed: What|Removed |Added CC|

[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer changed: What|Removed |Added Summary|when recording local use|When recording local use