https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #50 from Marcel de Rooy ---
*** Bug 28700 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #49 from Marcel de Rooy ---
(In reply to Kyle M Hall from comment #48)
> Doesn't apply to 21.05.x. Please rebase and let me know if you think this
> should be backported.
It really should have :) My 20.11 logs were
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Kyle M Hall changed:
What|Removed |Added
Status|Pushed to master|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_21_11_candidate |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #47 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Jonathan Druart changed:
What|Removed |Added
Version(s)||21.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #46 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #32)
> (In reply to Marcel de Rooy from comment #30)
> > Created attachment 127577 [details] [review] [review]
> > Bug 28962: (QA follow-up) Fix test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #45 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #34)
> Comments 25 and 26 need more attention, and tests are missing.
>
> Help welcomed.
Added tests.
It seems to me that we should postpone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #44 from Marcel de Rooy ---
Created attachment 127649
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127649=edit
Bug 28692: (follow-up) Add tests
Test plan:
Run t/db_dependent/Log.t
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
Attachment #127642|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
Attachment #127640|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
Attachment #127639|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
Attachment #127574|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
Attachment #127641|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #38 from Marcel de Rooy ---
Created attachment 127641
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127641=edit
Bug 28692: (QA follow-up) Fix test for objects
Fix the bug where object is first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #37 from Marcel de Rooy ---
Created attachment 127640
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127640=edit
Bug 28692: (QA follow-up) Sort hash keys of unblessed
Trivial add. Reads much better.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
Attachment #127575|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #35 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #34)
> Comments 25 and 26 need more attention, and tests are missing.
>
> Help welcomed.
Revisiting it now
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #33 from Jonathan Druart ---
Created attachment 127630
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127630=edit
Bug 28692: Correctly prefix "item " for Koha::Item MODIFY logs
or the isa won't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #32 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #30)
> Created attachment 127577 [details] [review]
> Bug 28962: (QA follow-up) Fix test for objects
>
> Simpler to check the ref instead of isa.
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #31 from Marcel de Rooy ---
Development and testing seems to be done too hastily. Three follow-ups ;)
Comment25 and 26 leaving open.
Note that I didnt have time to add some additional test for logaction. But you
are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #30 from Marcel de Rooy ---
Created attachment 127577
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127577=edit
Bug 28962: (QA follow-up) Fix test for objects
Simpler to check the ref instead of isa.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #29 from Marcel de Rooy ---
Created attachment 127576
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127576=edit
Bug 28962: (QA follow-up) Sort hash keys of unblessed
Trivial add. Reads much better.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #28 from Marcel de Rooy ---
Created attachment 127575
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127575=edit
Bug 28962: (QA follow-up) Add module
Signed-off-by: Marcel de Rooy
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
Attachment #127446|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Passed QA
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #26 from Marcel de Rooy ---
-my $result = $self->SUPER::store;
if ( $log_action && C4::Context->preference("CataloguingLog") ) {
$action eq 'create'
? logaction( "CATALOGUING", "ADD",
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #25 from Marcel de Rooy ---
Koha::Item
Not sure if there was an idea to log the item version before we store
(get_from_storage call) but we only save the current stage:
my $result = $self->SUPER::store;
if (
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #24 from Marcel de Rooy ---
+$infos = Dumper( $infos->unblessed );
+
+if ( $infos->isa('Koha::Item') && $modulename eq 'CATALOGUING' &&
$actionname eq 'MODIFY' ) {
Ha. If you change the variable to a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #23 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #20)
> Great, this is a good first step and enough at this late stage in the cycle
> for the next release in my opinion.
>
> I'd have been tempted to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #22 from Marcel de Rooy ---
Promising: Undefined subroutine ::Log::Dumper called at
/usr/share/koha/C4/Log.pm line 81
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #21
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Martin Renvoize changed:
What|Removed |Added
Attachment #127289|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #19 from Martin Renvoize ---
Created attachment 127446
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127446=edit
Bug 28692: Get from storage before log actions
To make sure we have logging the values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Jonathan Druart changed:
What|Removed |Added
Keywords|RM_priority |rel_21_11_candidate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Jonathan Druart changed:
What|Removed |Added
Attachment #125692|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #16 from Martin Renvoize ---
I think we should grab the more general handling from the middle two patches on
bug 28700 for here.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #15 from Martin Renvoize ---
and see
https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
for the jsdiff based diff we display.
Removing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #14 from Martin Renvoize ---
See
https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/Patron.pm#L307-L348
for the JSON 'changed field' structure we opted for.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #13 from Martin Renvoize ---
The 'infos' parameter of logaction is really inconsistent in general.. I'd love
to see it consistently be JSON myself.. as a universally easy thing to
encode/decode with handling built-in at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #12 from Marcel de Rooy ---
I tend to think that we should solve this issue and the unblessed-thing on bug
28700 together.
if ( ref $infos eq 'Koha::Hold' ) {
$varname = 'hold';
} elsif ( ref $infos eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #10 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #3)
Looking again here, thx for responding :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Peter Vashchuk changed:
What|Removed |Added
Attachment #122782|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Peter Vashchuk changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Joonas Kylmälä changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #5 from Andrew Nugged ---
Note: Jonathan, Bug 28700 has much bigger impact on logs records size
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Jonathan Druart changed:
What|Removed |Added
Keywords|release-notes-needed|RM_priority
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Jonathan Druart changed:
What|Removed |Added
Severity|enhancement |major
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Peter Vashchuk changed:
What|Removed |Added
Attachment #122683|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Andrew Nugged changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Peter Vashchuk changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |stalkern...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Peter Vashchuk changed:
What|Removed |Added
CC||nug...@gmail.com,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
--- Comment #1 from Peter Vashchuk ---
Created attachment 122683
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122683=edit
Bug 28692 - log without indentation to decrease DB action_log table size
Indentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692
Peter Vashchuk changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
65 matches
Mail list logo
