[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #27 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Martin Renvoize changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Martin Renvoize changed: What|Removed |Added Attachment #137687|0 |1 is obsolete|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #24 from David Nind --- Testing notes (using koha-testing-docker): - Patch still applies. - Things work as per the test plan. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 David Nind changed: What|Removed |Added Attachment #127098|0 |1 is obsolete|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Fridolin Somers changed: What|Removed |Added Depends on||30409 Referenced Bugs:

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Fridolin Somers changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #22 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #19) > The barcodedecode does the trimming, please remove the regexes. I'm testing but this does not work. I don't see a trim in barcodedecode().

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Blocks|29375 | --- Comment #21 from

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Blocks||29375 Referenced

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Attachment #127075|0 |1 is obsolete|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #19

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #18 from Marcel de Rooy --- (In reply to Owen Leonard from comment #16) > (In reply to Marcel de Rooy from comment #8) > > Created attachment 125816 [details] [review] [review] > > Bug 29114: (QA follow-up) Carriage

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Owen Leonard changed: What|Removed |Added Attachment #126896|0 |1 is obsolete|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #16 from Owen Leonard --- (In reply to Marcel de Rooy from comment #8) > Created attachment 125816 [details] [review] > Bug 29114: (QA follow-up) Carriage return is whitespace too > > Signed-off-by: Marcel de Rooy

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Owen Leonard changed: What|Removed |Added Attachment #125816|0 |1 is obsolete|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Attachment #126868|0 |1 is obsolete|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Attachment #126867|0 |1 is obsolete|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Attachment #125815|0 |1 is obsolete|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #12 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #10) > Shouldn't we actually call C4::Circulation::barcodedecode here? Fine with me. -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion ---

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #9 from Marcel de Rooy --- (In reply to Fridolin Somers from comment #6) > PS : > In the future, we may make this trim inside > Koha::Items->find({barcode => $barcode}) Not sure if we should btw. Probably not. --

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #8 from Marcel de Rooy --- Created attachment 125816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125816=edit Bug 29114: (QA follow-up) Carriage return is whitespace too Signed-off-by: Marcel de

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Marcel de Rooy changed: What|Removed |Added Attachment #125753|0 |1 is obsolete|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #6 from Fridolin Somers --- PS : In the future, we may make this trim inside Koha::Items->find({barcode => $barcode}) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #5 from Fridolin Somers --- (In reply to Fridolin Somers from comment #2) > A agree 100%, but I think we should trim also trailing whitespaces, like in > check-out : >

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 David Nind changed: What|Removed |Added Attachment #125752|0 |1 is obsolete|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Attachment #125369|0 |1 is obsolete|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #1 from Andrii Veremeienko --- Created attachment 125369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125369=edit Bug 29114: Trim whitespace before the barcode The solution was to add regexp which

[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andriive...@gmail.com