https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #40 from David Cook ---
(In reply to Julian Maurice from comment #39)
> (In reply to David Cook from comment #38)
> > By iterating through all the enabled plugins, loading them, and using
> > $_->can($method), we've creat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #39 from Julian Maurice ---
(In reply to David Cook from comment #38)
> By iterating through all the enabled plugins, loading them, and using
> $_->can($method), we've created the scenario which causes the problem
> descr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #38 from David Cook ---
(In reply to David Cook from comment #17)
> That way, you're just caching a list of plugins for methods that are used.
> That means every call of "$_->can($method)" *should* be true, so there
> sho
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #36 from Tomás Cohen Arazi ---
Pushed to master for 22.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||22.11.00
release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #35 from Kyle M Hall ---
Created attachment 142923
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142923&action=edit
Bug 29672: (QA followup) Add POD
Signed-off-by: Kyle M Hall
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #34 from Kyle M Hall ---
Created attachment 142922
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142922&action=edit
Bug 29672: Fix test t/db_dependent/Koha/Plugins/Plugins.t
Table plugin_data was not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #33 from Kyle M Hall ---
Created attachment 142921
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142921&action=edit
Bug 29672: Clear cache of enabled plugins when a plugin's state change
Signed-off-by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #32 from Kyle M Hall ---
Created attachment 142920
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142920&action=edit
Bug 29672: Increase performance of Koha::Plugins->call
Make use of Koha::Cache::Memo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Kyle M Hall changed:
What|Removed |Added
Attachment #142844|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Julian Maurice changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #30 from Julian Maurice ---
Created attachment 142916
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142916&action=edit
Bug 29672: Fix test t/db_dependent/Koha/Plugins/Plugins.t
Table plugin_data was n
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
David Nind changed:
What|Removed |Added
Attachment #135704|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
David Nind changed:
What|Removed |Added
Attachment #135660|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
David Nind changed:
What|Removed |Added
Attachment #135661|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Kyle M Hall changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Julian Maurice changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #25 from Julian Maurice ---
Created attachment 135704
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135704&action=edit
Bug 29672: Clear cache of enabled plugins when a plugin's state change
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Julian Maurice changed:
What|Removed |Added
Status|Failed QA |ASSIGNED
--- Comment #24 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #23
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Julian Maurice changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Julian Maurice changed:
What|Removed |Added
Attachment #128377|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Julian Maurice changed:
What|Removed |Added
Attachment #128376|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Patch doesn't apply
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #20
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #19 from David Cook ---
(In reply to Julian Maurice from comment #18)
> Is it really less efficient ? We have to de-reference the list at some point
> to iterate over it anyway. I will be happy to change that if you can s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #18 from Julian Maurice ---
(In reply to David Cook from comment #16)
> 1) Why does get_enabled_plugins return the array rather than an array
> reference? (I suppose it might not matter much since the array will just be
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #17 from David Cook ---
(In reply to David Cook from comment #16)
> I think that would maek sense since what we're really trying to do here is
> "get_enabled_plugins_with_method", right?
Actually, why not create "get_ena
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #16 from David Cook ---
I like the concept.
A few questions:
1) Why does get_enabled_plugins return the array rather than an array
reference? (I suppose it might not matter much since the array will just be a
list of re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #15 from Tomás Cohen Arazi ---
I like the approach of using the Lite cache and avoid subsequent queries.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #14 from Kyle M Hall ---
> I guess you're talking about the is_enabled method (which calls
> retrieve_data) ?
> I think we should not ask the plugin itself if it's enabled because a plugin
> can override this method.
> It
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Jonathan Druart changed:
What|Removed |Added
CC||k...@bywatersolutions.com,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #12 from Julian Maurice ---
(In reply to Jonathan Druart from comment #9)
> Julian, I am not sure, you are bypassing Koha::Plugin::Base->retrieve_data
> that is used in other places. As we are actually looking at caching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #11 from Fridolin Somers ---
(In reply to Jonathan Druart from comment #10)
> (In reply to Fridolin Somers from comment #8)
> > Ah OK thanks.
> >
> > get_enabled_plugins () is a private method ? maybe rename
> > _get_ena
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #10 from Jonathan Druart ---
(In reply to Fridolin Somers from comment #8)
> Ah OK thanks.
>
> get_enabled_plugins () is a private method ? maybe rename
> _get_enabled_plugins()
>
> Best regards,
It's a class method, l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #8 from Fridolin Somers ---
Ah OK thanks.
get_enabled_plugins () is a private method ? maybe rename
_get_enabled_plugins()
Best regards,
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Fridolin Somers changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #7 from Julian Maurice ---
(In reply to Fridolin Somers from comment #6)
> Instead of creating get_enabled_plugins(),
> Why not adding a param "only_enabled" in GetPlugins() ?
GetPlugins already returns only enabled plug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #6 from Fridolin Somers ---
Instead of creating get_enabled_plugins(),
Why not adding a param "only_enabled" in GetPlugins() ?
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Fridolin Somers changed:
What|Removed |Added
Patch complexity|--- |Small patch
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #5 from Fridolin Somers ---
(In reply to Fridolin Somers from comment #4)
> I see it returns undef when plugins are disabled.
> It should return empty array non ?
>
> In order to allow :
>
> my @plugin_responses = Koha:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #4 from Fridolin Somers ---
I see it returns undef when plugins are disabled.
It should return empty array non ?
In order to allow :
my @plugin_responses = Koha::Plugins->call(
'opac_results_xslt_variables',
{
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Fridolin Somers changed:
What|Removed |Added
Blocks||7923
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Julian Maurice changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #3 from Julian Maurice ---
Times I get on master:
1 call(s): Elapsed 0.670997 seconds
10 call(s): Elapsed 0.049056 seconds
100 call(s): Elapsed 0.468099 seconds
1000 call(s): Elapsed 4.762553 seconds
Times I get with th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Julian Maurice changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #2 from Julian Maurice ---
Created attachment 128377
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128377&action=edit
Bug 29672: [DO NOT PUSH] Test script
Run test-plugins-call.pl without arguments wi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #1 from Julian Maurice ---
Created attachment 128376
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128376&action=edit
Bug 29672: Increase performance of Koha::Plugins->call
Make use of Koha::Cache::Me
56 matches
Mail list logo
