[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Fridolin Somers changed: What|Removed |Added Blocks||35980 Referenced Bugs:

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #86 from David Cook --- (In reply to Katrin Fischer from comment #85) > Pushed for 24.05! > > Well done everyone, thank you! Great news! Hope that we can get this into 23.11 as well since it's still quite fresh. --

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #85 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #84 from Katrin Fischer --- > 2) Please add view to the permission descriptions in the SQL and template > file: > > +"INSERT IGNORE INTO permissions (module_bit, code, description) > VALUES (4,

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added Blocks||29509 Referenced Bugs:

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #83 from Martin Renvoize --- The filtering code was getting in the way of the tests.. the weird 'view_borrower_infos_from_any_libraries' sub-permission that's not entirely a permission in the same way all others are.

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA -- You are

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added Attachment #161246|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added Attachment #161245|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA -- You are

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Signed Off --- Comment

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #79 from Martin Renvoize --- Created attachment 161246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161246=edit Bug 30230: (QA follow-up) Also add list_borrowers to the singular endpoint -- You are

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #78 from Martin Renvoize --- Created attachment 161245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161245=edit Bug 30230: (QA follow-up) Add unit tests for API definition change -- You are

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #77 from Martin Renvoize --- Hold off.. I'm writing API tests for this now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added Status|Passed QA |ASSIGNED -- You are

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added QA Contact|dc...@prosentient.com.au

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added Attachment #161068|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added Attachment #159992|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added Attachment #159991|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Martin Renvoize changed: What|Removed |Added Attachment #159990|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #71 from Thibaud Guillot --- Created attachment 161068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161068=edit Bug 30230: (follow-up) Add list permission on home-search include and update atomic

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #70 from Katrin Fischer --- *ping* Still waiting for the follow-up! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #69 from Victor Grousset/tuxayo --- Hi :) change needed when bug 35517 (passed QA) is pushed to master (so soon unless a surprise comes up): Look at the patch:

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #68

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 David Cook changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #67

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #66 from Katrin Fischer --- > How does it work in combination with view_borrower_infos_from_any_libraries? Or more: how does it relate to this one? I am just trying to get a clear picture on how this works. Please

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #65 from David Cook --- (In reply to Katrin Fischer from comment #64) > 1) Should we update existing staff patron accounts to make this change more > convenient? Should everyone having edit_borrowers also have

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #64 from Katrin Fischer --- This doesn't look like too big a change and I think the permission will be useful for other use cases that we still need to target. So yay! BUT: I got questions. 1) Should we update existing

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #63

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #62 from Victor Grousset/tuxayo --- Thanks David for your help in reviewing :) > It is tempting to add a Selenium test Run, you fool! it's a trap! => Bug 29285 (In reply to Jonathan Druart from comment #61) > In

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #61 from Jonathan Druart --- (In reply to David Cook from comment #60) > It is tempting to add a Selenium test, but I'm not sure what it would prove. > Would it prove that it could list borrowers or that it can't edit

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #60 from David Cook --- I'm pretty happy with how this one has turned out. Just added a simple unit test fix follow-up. It is tempting to add a Selenium test, but I'm not sure what it would prove. Would it prove that

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 David Cook changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |dc...@prosentient.com.au

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #59 from David Cook --- Created attachment 159992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159992=edit Bug 30230: (follow-up) fix unit test Signed-off-by: David Cook -- You are receiving this

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 David Cook changed: What|Removed |Added Attachment #159989|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 David Cook changed: What|Removed |Added Attachment #159988|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 David Cook changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #56 from Victor Grousset/tuxayo --- It works :) including fixing the issue in comment 45 Main test plan done with minimal permissions at the start (catalogue, circulate_remaining_permissions) And also with maximal

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #159933|0 |1 is

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #159667|0 |1 is

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #159668|0 |1 is

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #52 from Victor Grousset/tuxayo --- Created attachment 159933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159933=edit Bug 30230: (follow-up) Fix display issue on search bar -- You are receiving

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #51 from Andrew Fuerste-Henry --- (In reply to Thibaud Guillot from comment #50) > Thank you all for this time of testing and feedback. I think I've managed to > fix the display problem Andrew was talking about. Thanks!

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #50 from Thibaud Guillot --- Thank you all for this time of testing and feedback. I think I've managed to fix the display problem Andrew was talking about. -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #49 from Thibaud Guillot --- Created attachment 159668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159668=edit Bug 30230 : (follow-up) Fix display issue on search bar -- You are receiving this

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #48 from Emmi Takkinen --- Signing off, since this change is much needed and patch works as described. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Emmi Takkinen changed: What|Removed |Added Attachment #159654|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 ByWater Sandboxes changed: What|Removed |Added Attachment #159633|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #45 from Andrew Fuerste-Henry --- > Normally I've taken your comments into account and removed the "Search > patrons" link from the main search bar... it's only accessible to members > with 'catalog' permission. Unless

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #44 from Thibaud Guillot --- (In reply to David Cook from comment #42) > I would've been happy to sign this off, but looks like there is a little > perltidy problem with the database update. > > If you perltidy that

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What|Removed |Added Attachment #159613|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #42

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #41 from David Cook --- (In reply to Lucas Gass from comment #32) > As this stands no borrowers/staff will get the new permission on update. > That is a change in behavior that needs to be avoided. Originally, I was

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #40 from David Cook --- Sounds good! I've got something on at the moment, but I'll try to look at this later. Thanks, Thibaud for your hard work on this one! -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #39 from Thibaud Guillot --- Hello, I've added the 'list_borrowers' permission on moremember.pl, as it seemed more logical, I had included it initially but removed it later. A member with only the list_borrowers

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What|Removed |Added Attachment #159427|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #37 from David Cook --- (In reply to Lucas Gass from comment #36) > > This permission is only there to allow search and list view of members, no > > access to the details of each member (moremember.pl) and therefore in

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #36 from Lucas Gass --- (In reply to Thibaud Guillot from comment #35) > (In reply to Lucas Gass from comment #32) > > As this stands no borrowers/staff will get the new permission on update. > > That is a change in

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #35 from Thibaud Guillot --- (In reply to Lucas Gass from comment #32) > As this stands no borrowers/staff will get the new permission on update. > That is a change in behavior that needs to be avoided. > > I think we

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #34 from Thibaud Guillot --- (In reply to Andrew Fuerste-Henry from comment #31) > Created attachment 159559 [details] > Link to be removed > > This latest patch addresses all of my concerns except for the "Search >

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #33 from David Cook --- *** Bug 35381 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Failed QA CC|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #31 from Andrew Fuerste-Henry --- Created attachment 159559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159559=edit Link to be removed This latest patch addresses all of my concerns except for the

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #30 from Thibaud Guillot --- (In reply to Andrew Fuerste-Henry from comment #28) > With this new patch, I did the following: > - create a user with catalogue, circulate_remaining_permissions, and > list_borrowers

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #29 from Thibaud Guillot --- Created attachment 159517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159517=edit Bug 30230 : (follow-up) Fix permission on /patrons api route -- You are receiving

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA ---

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #27 from Thibaud Guillot --- (In reply to Andrew Fuerste-Henry from comment #22) > I feel like this permission should be grouped with the other borrowers > permissions, rather than set off as its own top-level

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What|Removed |Added Attachment #159409|0 |1 is obsolete|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #25 from David Cook --- (In reply to Andrew Fuerste-Henry from comment #22) > I feel like this permission should be grouped with the other borrowers > permissions, rather than set off as its own top-level permission. +1

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 David Nind changed: What|Removed |Added CC||da...@davidnind.com

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #23 from Andrew Fuerste-Henry --- Created attachment 159412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159412=edit screenshot of confusing interface -- You are receiving this mail because: You

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #22 from Andrew Fuerste-Henry --- I feel like this permission should be grouped with the other borrowers permissions, rather than set off as its own top-level permission. I created a user with only catalogue,

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #21 from Thibaud Guillot --- I've noted that this bug is related to bug 29509 (maybe even the same one, as Jonathan says), but I've been working more on the interface functionality than on what the route could change

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #20 from Thibaud Guillot --- Created attachment 159409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159409=edit Bug 30230: Add new 'list_borrowers' permission When a patron search is performed only

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #19 from David Cook --- (In reply to David Cook from comment #18) > Actually, something like /api/v1/circ/search/patrons might be better. > (Jonathan's ERM and preservation have shown how it's useful to organise >

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #18 from David Cook --- (In reply to David Cook from comment #12) > In theory, the REST API was a good idea, but I think we've approached it a > bit naively. > > Rather than search using GET /api/v1/patrons, I reckon

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Katrin Fischer changed: What|Removed |Added CC||michaela.sie...@kit.edu

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #17 from David Cook --- (In reply to George Williams (NEKLS) from comment #16) > I don't think removing these things from the search resultswould be terribly > difficult if the staff user doesn't have edit_borrower

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #16 from George Williams (NEKLS) --- What I'd like to see in the borrower search is, if the staff user doesn't have edit_borrower permission, then 1. the link to the borrower's details page in the "Name" column is

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #15 from David Cook --- (In reply to Jonathan Druart from comment #14) > This is actually a duplicate of bug 29509 I think. I think you might be right. Or at least there is a lot of overlap. I think bug 29509 is already

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #13 from David Cook --- (In reply to Thibaud Guillot from comment #7) > No problem, what would be the best solution to correct this behavior ? tl;dr Someone can add "view_borrowers" and add that to member.pl, the

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #12 from David Cook --- Except that doesn't work either because of the whacky REST API permissions that also require edit_borrowers. In theory, the REST API was a good idea, but I think we've approached it a bit

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #11 from David Cook --- (In reply to David Cook from comment #10) > Note the autocomplete also gives a 403... {"error":"Authorization failure. Missing required

[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #10 from David Cook --- Note the autocomplete also gives a 403... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

  1   2   >