https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #46 from David Cook ---
PS I don't mean to be a buzz kill and I very much appreciate your
contributions, Martin! :D <3
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #45 from David Cook ---
(In reply to Martin Renvoize from comment #44)
> I've added an alternative approach to bug 30897 that uses the proposed
> getppid and kill approach.
>
> It's not tested yet, but hopefully can get
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #44 from Martin Renvoize ---
I've added an alternative approach to bug 30897 that uses the proposed getppid
and kill approach.
It's not tested yet, but hopefully can get this one moving again.
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
Martin Renvoize changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
Martin Renvoize changed:
What|Removed |Added
Priority|P5 - low|P1 - high
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
Martin Renvoize changed:
What|Removed |Added
CC||k...@trust-box.at
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
Martin Renvoize changed:
What|Removed |Added
CC||d...@plix.at
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
Martin Renvoize changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #43 from Victor Grousset/tuxayo ---
(In reply to Martin Renvoize from comment #26)
> Adding this here for reference so I don't forget.. we might be able to use
> https://perldoc.perl.org/functions/getppid to find the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
Victor Grousset/tuxayo changed:
What|Removed |Added
Severity|enhancement |normal
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #41 from David Cook ---
(In reply to Victor Grousset/tuxayo from comment #40)
> I didn't know that bug 20630 would be necessary. I though it was already
> done in the wild by some providers tweaking their setup to manage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #40 from Victor Grousset/tuxayo ---
(In reply to David Cook from comment #39)
> (In reply to Martin Renvoize from comment #38)
> > Are tenants not isolated already? Plugins, by default, go into
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #39 from David Cook ---
(In reply to Martin Renvoize from comment #38)
> Are tenants not isolated already? Plugins, by default, go into
> /var/lib/Koha/site/... and run under the instance user.
Yeah, currently they're
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #38 from Martin Renvoize ---
Are tenants not isolated already? Plugins, by default, go into
/var/lib/Koha/site/... and run under the instance user.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #37 from David Cook ---
(In reply to Victor Grousset/tuxayo from comment #36)
> Ok since the multi-tenant case isn't a problem here, one Koha instance will
> always have a reasonable number of workers vs the number of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #36 from Victor Grousset/tuxayo ---
(In reply to David Cook from comment #35)
> 8 CPUs and 400 workers is an extreme example.
>
> If you're multi-tenanted, you'll have fewer workers. But if you're not
> multi-tenanted,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #35 from David Cook ---
(In reply to Victor Grousset/tuxayo from comment #34)
> (In reply to David Cook from comment #33)
> > Everything would be configuration driven, so you could still have people
> > upload plugins,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #34 from Victor Grousset/tuxayo ---
(In reply to David Cook from comment #33)
> Everything would be configuration driven, so you could still have people
> upload plugins, and Koha could put them in the right place.
If
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #33 from David Cook ---
(In reply to Victor Grousset/tuxayo from comment #32)
> In that case of multi-tenancy with shared workers, allowing plugin
> management via UI would be a no anyway, right?
Everything would be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #32 from Victor Grousset/tuxayo ---
(In reply to David Cook from comment #29)
> We'd need to "preload" the base code, which we don't currently do in Koha,
> in order to get that benefit of compiling once and then forking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #31 from David Cook ---
So there's another problem with the concept of automatically reloading Starman
on install/upgrade/uninstall.
The "background_tasks" hook is run in background_jobs_worker.pl which also
loads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #30 from David Cook ---
Personally, I've moved to only allowing plugins installed via the CLI, which
makes managing this issue fairly trivial. I'll install a plugin and start the
necessary processes for the necessary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #29 from David Cook ---
(In reply to Victor Grousset/tuxayo from comment #28)
> :( Too bad. Thanks for the real world knowledge. I was hopping the actual
> compile would happen on the 1st request.
The "plack.psgi" file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #28 from Victor Grousset/tuxayo ---
(In reply to David Cook from comment #27)
> If you ran ./misc/devel/install_plugins.pl against all instances, it would
> be a paralyzing load on a large shared hosting server, yes.
:(
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #27 from David Cook ---
(In reply to Victor Grousset/tuxayo from comment #25)
> (In reply to Martin Renvoize from comment #23)
> > I had a look to see if there was any obvious way to get the instance name or
> > track up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #26 from Martin Renvoize ---
Adding this here for reference so I don't forget.. we might be able to use
https://perldoc.perl.org/functions/getppid to find the Starman master pid.. I'm
going to run a few tests using that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #25 from Victor Grousset/tuxayo ---
(In reply to Martin Renvoize from comment #23)
> I had a look to see if there was any obvious way to get the instance name or
> track up to find the parent PID so we could call the HUP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #24 from David Cook ---
(In reply to Martin Renvoize from comment #23)
> I'm considering coming back to option 1 in David's suggestions... do you
> think you're likely to have any time to work through this early next
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #22 from David Cook ---
While Plack::Middleware::Refresh wouldn't work for bug 31729, it could
potentially cover the plugin scenario, since we don't use .pl scripts in
plugins.
But it is designed for development and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #21 from David Cook ---
Actually, another problem with this whole proposal is that it only takes into
account the main plugin .pm file.
A plugin can contain many Perl modules, which also need to be updated. Often,
these
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #20 from David Cook ---
Created attachment 152463
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152463=edit
[DO NOT PUSH] - Plugin for testing
Just increment the VERSION number in the main file so
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #19 from David Cook ---
(In reply to Olivier Hubert from comment #16)
> Note that I was unable to recreate the potential issue with only one worker
> seeing the changes once Module::Refresh does its job.
I just
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #18 from David Cook ---
(In reply to Olivier Hubert from comment #16)
> I'm reactivating this as I would like to have it solves once and for all.
I'll take another look now, as it would be good to get something done for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #17 from Katrin Fischer ---
*** Bug 30897 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074
--- Comment #16 from Olivier Hubert ---
I'm reactivating this as I would like to have it solves once and for all.
Note that I was unable to recreate the potential issue with only one worker
seeing the changes once Module::Refresh
38 matches
Mail list logo
