[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC|

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 144824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144824=edit Bug 31086: (follow-up) There's no ->fill in 21.11 Signed-off-by: Tomas Cohen Arazi

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #36 from Katrin Fischer --- (In reply to Martin Renvoize from comment #35) > I don't understand how running the exact same SQL as is in the update itself > can resolve this problem. Fixed on bug 31673. -- You are

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #35 from Martin Renvoize --- I don't understand how running the exact same SQL as is in the update itself can resolve this problem. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Katrin Fischer changed: What|Removed |Added Blocks||31673 Referenced Bugs:

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 José Anjos changed: What|Removed |Added Status|REOPENED|RESOLVED

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 José Anjos changed: What|Removed |Added Status|RESOLVED|REOPENED

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to stable|RESOLVED

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #31 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Arthur Suzuki changed: What|Removed |Added Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #28 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 138051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138051=edit Bug 31086: (QA follow-up) Use plain SQL in db_rev Signed-off-by: Tomas Cohen Arazi

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #25 from Nick Clemens --- Created attachment 138018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138018=edit Bug 31086: Notify of problematic holds during upgrade -- You are receiving this mail

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #26 from Martin Renvoize --- I like nicks addition to my follow-up.. best of all worlds -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #24 from Martin Renvoize --- Created attachment 138006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138006=edit Bug 31086: (QA follow-up) Improve atomicupdate to be more resilient We now populate

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #23 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #22) > Our database updates are better now in terms of not silently ignoring > issues, but I do think we as Devs aught to try and cater for more of

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #22 from Martin Renvoize --- Good points raised there Tomas.. I was perhaps a little hasty in PQA. We could do better; as you highlighted we could be catching the constraint failure rather than testing before hitting

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #20 from Martin Renvoize --- All good now with the minor follow-ups.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #19 from Martin Renvoize --- Created attachment 137642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137642=edit Bug 31086: (QA follow-up) Add unit tests This patch adds the unit tests for the change

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #18 from Martin Renvoize --- Created attachment 137641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137641=edit Bug 31086: (QA follow-up) Fix failing tests This test was missed first time around,

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #17 from Martin Renvoize --- Created attachment 137640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137640=edit Bug 31086: (QA follow-up) Remove DEFAULT from column There's no need to have a default

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize changed: What|Removed |Added Attachment #137258|0 |1 is obsolete|

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize changed: What|Removed |Added Attachment #137257|0 |1 is obsolete|

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize changed: What|Removed |Added Attachment #137256|0 |1 is obsolete|

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize changed: What|Removed |Added Attachment #137255|0 |1 is obsolete|

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize changed: What|Removed |Added Attachment #137254|0 |1 is obsolete|

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #11 from Martin Renvoize --- Comment on attachment 137254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137254 Bug 31086: DB update Review of attachment 137254: -->

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 David Nind changed: What|Removed |Added Attachment #137026|0 |1 is obsolete|

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 David Nind changed: What|Removed |Added Attachment #136987|0 |1 is obsolete|

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 David Nind changed: What|Removed |Added Attachment #136986|0 |1 is obsolete|

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 David Nind changed: What|Removed |Added Attachment #136984|0 |1 is obsolete|

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 David Nind changed: What|Removed |Added Attachment #136983|0 |1 is obsolete|

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Carolyn Hughesman changed: What|Removed |Added CC||chughes...@cclsny.org

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #5 from Nick Clemens --- Created attachment 137026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137026=edit Bug 31086: Update existing unit tests -- You are receiving this mail because: You are

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #4 from Nick Clemens --- Created attachment 136987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136987=edit Bug 31086: DO NOT PUSH: Schema updates -- You are receiving this mail because: You are

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #3 from Nick Clemens --- Created attachment 136986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136986=edit Bug 31086: Prevent placing hold with no pickup location To test: 1 - Apply patch 2 -

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #2 from Nick Clemens --- Created attachment 136984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136984=edit Bug 31086: Throw an exception when a hold is stored with no branchcode To test: 1 - Apply

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #1 from Nick Clemens --- Created attachment 136983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136983=edit Bug 31086: DB update This update sets branchcode as NOT NULL default set to 0 as

[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch