https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Aleisha Amohia changed:
What|Removed |Added
CC||alei...@catalyst.net.nz
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Arthur Suzuki changed:
What|Removed |Added
Status|Pushed to stable|Pushed to oldstable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Lucas Gass changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords|additional_work_needed |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
--- Co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Patch doesn't apply |Passed QA
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #33
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Marcel de Rooy changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Marcel de Rooy changed:
What|Removed |Added
Status|Pushed to master|ASSIGNED
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Marcel de Rooy changed:
What|Removed |Added
Attachment #141974|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Marcel de Rooy changed:
What|Removed |Added
Attachment #141973|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #30 from Marcel de Rooy ---
Thanks. Looking here now
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #28 from Jonathan Druart ---
Created attachment 141974
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141974&action=edit
Bug 31154: Avoid unecessary loop
We don't need to loop over the subfield and ent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #27 from Jonathan Druart ---
Created attachment 141973
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141973&action=edit
Bug 31154: Add test
--
You are receiving this mail because:
You are watching al
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #26 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #25)
> This changes forgot to add unit tests btw.
We have t/db_dependent/Koha/UI/Form/Builder/Item.t, but generate_subfield_form
is not tested directl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #25 from Jonathan Druart ---
This changes forgot to add unit tests btw.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #24 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #22)
> Jonathan, left comment17 and comment19 for your consideration :)
Why didn't you add that on the original bug report? :)
(In reply to Marcel de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #23 from Tomás Cohen Arazi ---
Pushed to master for 22.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||22.11.00
release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #22 from Marcel de Rooy ---
Jonathan, left comment17 and comment19 for your consideration :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #21 from Marcel de Rooy ---
Created attachment 140695
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140695&action=edit
Bug 31154: (QA follow-up) Fix UI form builder
The change in batchMod.pl is not ne
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Marcel de Rooy changed:
What|Removed |Added
Attachment #140602|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
St
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Marcel de Rooy changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #19 from Marcel de Rooy ---
We are really wasting resources here.
First we do:
my %itemdata = map { lc($_->{barcode}) => $_->{itemnumber} } @{
Koha::Items->search({ barcode => { -in => \@barcodelist } }, { columns => [
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #18 from Marcel de Rooy ---
$biblionumber = Koha::Items->find($itemnumbers[0])->unblessed->{biblionumber}
if $itemnumbers[0];
Emmi, you should probably not change this parameter. It is passed in, although
I guess normall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #17 from Marcel de Rooy ---
=head3 new
my $form = Koha::UI::Form::Builder::Item->new(
{
biblionumber => $biblionumber,
item => $current_item,
}
);
Constructor.
biblionumbe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
David Nind changed:
What|Removed |Added
Attachment #140518|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Emmi Takkinen changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Emmi Takkinen changed:
What|Removed |Added
Attachment #138124|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #13 from Emmi Takkinen ---
Well this is confusing. I was able to repeat this bug again by adding a value
in syspref "itemcallnumber" e.g. 084a. This triggers if-statement in
Koha/Koha/UI/Form/Builder/Item.pm starting from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #12 from Emmi Takkinen ---
It seems this patch reawakens bug 21141. I'll rework this if needed since it
might be that some other patch already fixed this.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Amanda Campbell changed:
What|Removed |Added
CC||acampb...@hmcpl.org
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Rachael changed:
What|Removed |Added
CC||rachael.lar...@inlibro.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #10 from Emmi Takkinen ---
(In reply to Katrin Fischer from comment #9)
> I can no longer replicate the problem with the test plan that worked before
> :(
Hmm, how about if you save authorised value for 952$8?
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #9 from Katrin Fischer ---
I can no longer replicate the problem with the test plan that worked before :(
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #8 from Emmi Takkinen ---
(In reply to Caroline Cyr La Rose from comment #7)
> I cannot reproduce the problematic behaviour either in a sandbox nor on my
> local dev install with the steps from comment 4. In all cases, I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Caroline Cyr La Rose changed:
What|Removed |Added
CC||caroline.cyr-la-rose@
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #6 from Katrin Fischer ---
Thx for the patch!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-communi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Emmanuel Bétemps changed:
What|Removed |Added
CC||e.bete...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Emmi Takkinen changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |emmi.takki...@koha-suomi.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Katrin Fischer changed:
What|Removed |Added
Severity|normal |major
--- Comment #4 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #3 from Emmi Takkinen ---
(In reply to Katrin Fischer from comment #1)
> I can't confirm on master. Which version did you test with Emmi?
I tested on both master and 21.11 which we use.
It seems this happens because in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #2 from Katrin Fischer ---
Oh, and maybe check the logs - there could be a more meaningful error there.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
--- Comment #1 from Katrin Fischer ---
I can't confirm on master. Which version did you test with Emmi?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154
Katrin Fischer changed:
What|Removed |Added
Severity|enhancement |normal
--
You are receivi
52 matches
Mail list logo