https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Blocks||36875
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords|additional_work_needed |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #132 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #130)
> Please wait for Nick's comment this time ;)
Please mark it as BLOCKED in such situations. Sometimes I already went through
a bug and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Owen Leonard changed:
What|Removed |Added
Blocks||35154
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Owen Leonard changed:
What|Removed |Added
Blocks||35153
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Owen Leonard changed:
What|Removed |Added
Blocks||35152
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Owen Leonard changed:
What|Removed |Added
Blocks||35151
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Owen Leonard changed:
What|Removed |Added
Blocks||35065
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Owen Leonard changed:
What|Removed |Added
Blocks||35063
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Owen Leonard changed:
What|Removed |Added
Blocks||35048
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Owen Leonard changed:
What|Removed |Added
Blocks||34894
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Nick Clemens changed:
What|Removed |Added
Attachment #157741|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #130 from Jonathan Druart ---
Please wait for Nick's comment this time ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #129 from Jonathan Druart ---
Created attachment 157741
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157741=edit
Bug 31383: (follow-up) Remove get_opac_news_by_id
Keep the same behaviour, but
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Owen Leonard changed:
What|Removed |Added
Blocks||35136
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords|additional_work_needed |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #128 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #119)
> Created attachment 157640 [details] [review]
> Bug 31383: (bug 29691 follow-up) Remove get_opac_news_by_id
>
> We can simply use get here
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #127 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #125)
> This should not work either I guess?
>
> sub get_opac_news_by_id {
> my ( $self, $params ) = @_;
>
> my $news_id =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #126 from Owen Leonard ---
(In reply to Owen Leonard from comment #123)
> If I delete any notices which have a branchcode from the letters table
> before I run the database update the update runs without error.
I think
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #125 from Tomás Cohen Arazi ---
This should not work either I guess?
sub get_opac_news_by_id {
my ( $self, $params ) = @_;
my $news_id = $params->{news_id};
my $content =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #124 from Tomás Cohen Arazi ---
(In reply to Owen Leonard from comment #123)
> If I delete any notices which have a branchcode from the letters table
> before I run the database update the update runs without error.
So,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #123 from Owen Leonard ---
If I delete any notices which have a branchcode from the letters table before I
run the database update the update runs without error.
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #122 from Marcel de Rooy ---
Did not see it myself:
Upgrade to 23.06.00.041 [11:42:55]: Bug 31383 - Split the additional_contents
table
Renamed additional_contents.idnew with 'id'
Added new table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #121 from Owen Leonard ---
I'm getting an error from updatedatabase:
ERROR - {UNKNOWN}: Not a HASH reference at
/kohadevbox/koha/installer/data/mysql/db_revs/230600041.pl line 130. at
/kohadevbox/koha/C4/Installer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #119 from Jonathan Druart ---
Created attachment 157640
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157640=edit
Bug 31383: (bug 29691 follow-up) Remove get_opac_news_by_id
We can simply use get
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Jonathan Druart changed:
What|Removed |Added
Keywords|additional_work_needed |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #118 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #117)
> Created attachment 157585 [details] [review]
> Bug 31383: Fix the DB upgrade process
>
> This patch fixes misc4dev/run_tests.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #117 from Jonathan Druart ---
Created attachment 157585
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157585=edit
Bug 31383: Fix the DB upgrade process
This patch fixes misc4dev/run_tests.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #116 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #114)
> This breaks Koha_Master, which tries to re-apply all the updates in an
> attempt to test db_revs to be idempotent.
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #115 from Tomás Cohen Arazi ---
Created attachment 157580
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157580=edit
Bug 31383: Fix kohastructure.sql
Signed-off-by: Tomas Cohen Arazi
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords||additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||34869
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||34889
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #113 from Tomás Cohen Arazi ---
Pushed to master for 23.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #112 from Jonathan Druart ---
Created attachment 157550
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157550=edit
Bug 31383: (QA follow-up) Tidy
Signed-off-by: Martin Renvoize
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #111 from Jonathan Druart ---
Created attachment 157549
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157549=edit
Bug 31383: Fix dbrevs
We need to remove duplicate entries.
Signed-off-by: Marcel de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #110 from Jonathan Druart ---
Created attachment 157548
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157548=edit
Bug 31383: Fix URLs on staff AC detail view
No real need anymore for showing a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #109 from Jonathan Druart ---
Created attachment 157547
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157547=edit
Bug 31383: Use one query in search_for_display instead of four
Benchmarking does
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #108 from Jonathan Druart ---
Created attachment 157546
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157546=edit
Bug 31383: Check lang and use right column in search_for_display
We should check if
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #107 from Jonathan Druart ---
Created attachment 157545
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157545=edit
Bug 31383: (QA follow-up) Do not return 0 in ->get
The last statement evaluated is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #106 from Jonathan Druart ---
Created attachment 157544
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157544=edit
Bug 31383: Restore updated_on for individual content
Sponsored-by: Rijksmuseum,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #105 from Jonathan Druart ---
Created attachment 157543
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157543=edit
Bug 31383: DBIC specific
Sponsored-by: Rijksmuseum, Netherlands
Signed-off-by: Marcel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #104 from Jonathan Druart ---
Created attachment 157542
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157542=edit
Bug 31383: DBIC changes
Sponsored-by: Rijksmuseum, Netherlands
Signed-off-by: Marcel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #103 from Jonathan Druart ---
Created attachment 157541
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157541=edit
Bug 31383: DB changes
Sponsored-by: Rijksmuseum, Netherlands
Signed-off-by: Marcel de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #102 from Jonathan Druart ---
Created attachment 157540
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157540=edit
Bug 31383: Adjust and add tests
Sponsored-by: Rijksmuseum, Netherlands
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Jonathan Druart changed:
What|Removed |Added
Attachment #156265|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Katrin Fischer changed:
What|Removed |Added
Blocks|34482 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Katrin Fischer changed:
What|Removed |Added
Blocks||34482
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #98 from Martin Renvoize ---
Created attachment 156276
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156276=edit
Bug 31383: (QA follow-up) Tidy
Signed-off-by: Martin Renvoize
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
Attachment #156058|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
Attachment #156057|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
Attachment #156056|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
Attachment #156055|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
Attachment #156054|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
Attachment #156053|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
Attachment #156052|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
Attachment #156051|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
Attachment #156050|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
Attachment #156049|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
Attachment #156048|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #86 from Martin Renvoize ---
Awesome, thanks Jonathan, if missed that comment.
This all seems good to me, I could find any regressions. I'll upload the
designed patches in the morning and amend to PQA.
Thanks for the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #83 from Jonathan Druart ---
Trivial rebase.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #82 from Jonathan Druart ---
Created attachment 156058
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156058=edit
Bug 31383: Fix dbrevs
We need to remove duplicate entries.
Signed-off-by: Marcel de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #81 from Jonathan Druart ---
Created attachment 156057
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156057=edit
Bug 31383: Fix URLs on staff AC detail view
No real need anymore for showing a Default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #80 from Jonathan Druart ---
Created attachment 156056
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156056=edit
Bug 31383: Use one query in search_for_display instead of four
Benchmarking does
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #79 from Jonathan Druart ---
Created attachment 156055
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156055=edit
Bug 31383: Check lang and use right column in search_for_display
We should check if
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #78 from Jonathan Druart ---
Created attachment 156054
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156054=edit
Bug 31383: (QA follow-up) Do not return 0 in ->get
The last statement evaluated is the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #77 from Jonathan Druart ---
Created attachment 156053
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156053=edit
Bug 31383: Restore updated_on for individual content
Sponsored-by: Rijksmuseum,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #76 from Jonathan Druart ---
Created attachment 156052
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156052=edit
Bug 31383: DBIC specific
Sponsored-by: Rijksmuseum, Netherlands
Signed-off-by: Marcel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #75 from Jonathan Druart ---
Created attachment 156051
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156051=edit
Bug 31383: DBIC changes
Sponsored-by: Rijksmuseum, Netherlands
Signed-off-by: Marcel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #74 from Jonathan Druart ---
Created attachment 156050
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156050=edit
Bug 31383: DB changes
Sponsored-by: Rijksmuseum, Netherlands
Signed-off-by: Marcel de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #73 from Jonathan Druart ---
Created attachment 156049
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156049=edit
Bug 31383: Adjust and add tests
Sponsored-by: Rijksmuseum, Netherlands
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Jonathan Druart changed:
What|Removed |Added
Attachment #153666|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Attachment #153013|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Attachment #152669|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Attachment #152668|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Attachment #152667|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Attachment #152666|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Attachment #152665|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Attachment #152664|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Attachment #152663|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Attachment #152662|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Attachment #152661|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Attachment #152660|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #60 from Marcel de Rooy ---
Needed small rebase on fa pencil stuff
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #59 from Marcel de Rooy ---
dbrev does no longer crash, still checking results
DEV atomic update
/usr/share/koha/installer/data/mysql/atomicupdate/bug_31383.pl [14:29:24]: Bug
31383 - Split the additional_contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #58 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #44)
> This was my add contents test table:
>
> | news| News_1 | NULL |
> | news| News_2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #57 from Jonathan Druart ---
Created attachment 153013
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153013=edit
Bug 31383: Fix dbrevs
We need to remove duplicate entries.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383
--- Comment #56 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #53)
> Created attachment 152668 [details] [review]
> Bug 31383: Use one query in search_for_display instead of four
>
> Benchmarking does however
1 - 100 of 164 matches
Mail list logo