https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Pedro Amorim changed:
What|Removed |Added
Blocks||33880
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Arthur Suzuki changed:
What|Removed |Added
CC||arthur.suz...@biblibre.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Lucas Gass changed:
What|Removed |Added
Keywords|rel_22_05_candidate,|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Lucas Gass changed:
What|Removed |Added
Version(s)|22.11.00|22.11.00, 22.05.07
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #26 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #23)
> Status now reflects where we are.
Thanks :-D
I was waiting for more reviews and debugging to take place today.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||22.11.00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #23 from Marcel de Rooy ---
Status now reflects where we are.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Marcel de Rooy changed:
What|Removed |Added
Status|Passed QA |Pushed to master
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #22 from Marcel de Rooy ---
Okay, convinced :) This will probably get us out of trouble in most cases.
Perhaps we should have a look at limiting the secret length at some point.
So Selenium is just fantastic :) Ugghh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #21 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #18)
> otpauth://totp/BtwjEx:
> BtwjEx_wp9YPWXB91qaOkkwuxT9GydFBV9cMeUlHOLMDrn0?secret=qxiff74gn7jtdiengrfnpr
> eywu=BtwjEx
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #20 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #17)
> Try with a very long userid.
Yeah, still looking for that spot in the code where we build the secret ;) But
its length is the culprit.
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #19 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #16)
> (In reply to Jonathan Druart from comment #13)
> > Lol, they are very strong and caught a bug here, so... We have some shitty
> > selenium/www
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #18 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #17)
> Try with a very long userid.
otpauth://totp/QcQ4WNT:QcQ4WNT_QAQDfB8?secret=3ml253y4p3er7axhrwdlz6by2e=QcQ4WNT
vs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #17 from Jonathan Druart ---
Try with a very long userid.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #16 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #13)
> Lol, they are very strong and caught a bug here, so... We have some shitty
> selenium/www tests, but those ones are great IMO.
No reason to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #15 from Marcel de Rooy ---
If I am corrent, a normal secret will give values like:
Version 10 Module 4
L104: 228 1728
Version 8 Module 4
L104: 220 1232
where L104 is a debug line in QRcode.pm:
warn "L104: $iTotalBits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #14 from Marcel de Rooy ---
Doing some debugging now with:
use Modern::Perl;
use Convert::Base32;
use GD::Barcode;
use Koha::AuthUtils;
my $duplicate_secret = 4;
foreach( 1.. 50) {
my $secret =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #13 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #8)
> Without this patch on commit fd7bc8a9b8de5a8fdea36b046e4621760366dbf0, 2FA
> seems to work just fine on Debian 11 via the interface.
>
> The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #12 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #7)
> (In reply to Tomás Cohen Arazi from comment #6)
> > I cannot run it on the laptop right now, but I've pushed it. Will continue
> > tomorrow.
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #11 from Jonathan Druart ---
Yes, it's coming from GD::Barcode::QRcode
310 sub _calcVersion($$$) {
311 my ($oSelf, $iTtlBits, $raPlusWords) = @_;
312
313 my %hMaxDatBits= (
314 'M' =>[ 0,
315
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #10 from Marcel de Rooy ---
GD::Barcode::QRcode
elsif ($iTotalBits > $iMaxDatBits){
die "Overflow error. version $oSelf->{Version}\n" .
"total bits: $iTotalBits max bits: $iMaxDatBits\n";
}
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #9 from Marcel de Rooy ---
Tested both Enable and Enforced btw.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |BLOCKED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #8 from Marcel de Rooy ---
Without this patch on commit fd7bc8a9b8de5a8fdea36b046e4621760366dbf0, 2FA
seems to work just fine on Debian 11 via the interface.
The Selenium stuff is another story. But it should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #7 from Marcel de Rooy ---
(In reply to Tomás Cohen Arazi from comment #6)
> I cannot run it on the laptop right now, but I've pushed it. Will continue
> tomorrow.
I dont understand that. I am looking now here. But this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Jonathan Druart changed:
What|Removed |Added
Keywords||rel_22_11_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Jonathan Druart changed:
What|Removed |Added
Keywords||rel_22_05_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #5 from Jonathan Druart ---
Tests ran 50x without failure. Looks good!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #4 from Jonathan Druart ---
Sometimes seeing a 500 in Koha logs which is suspect:
Can't use string ("Koha::Patron") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/Koha/Object.pm line 830
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #3 from Jonathan Druart ---
*** Bug 32010 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Jonathan Druart changed:
What|Removed |Added
Attachment #142696|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
--- Comment #1 from Jonathan Druart ---
Created attachment 142696
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142696=edit
Bug 32011: 2FA - Prevent qr_code to not be generated
Caught by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011
Jonathan Druart changed:
What|Removed |Added
See Also|
39 matches
Mail list logo
