https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Lucas Gass changed:
What|Removed |Added
Status|Pushed to stable|RESOLVED
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #41 from Matt Blenkinsop ---
Nice work everyone!
Pushed to stable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Matt Blenkinsop changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #40 from Tomás Cohen Arazi ---
Pushed to master for 23.05.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #39 from Jonathan Druart ---
Created attachment 149637
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149637=edit
Bug 32418: Remove useless statement
Signed-off-by: Jonathan Druart
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #38 from Jonathan Druart ---
Created attachment 149636
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149636=edit
Bug 32418: (follow-up) Remove jQuery, Fix typos in url, add biblio as template
param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Jonathan Druart changed:
What|Removed |Added
Attachment #149626|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
David Nind changed:
What|Removed |Added
Attachment #149591|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
David Nind changed:
What|Removed |Added
Attachment #149092|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #34 from Paul Derscheid ---
Created attachment 149591
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149591=edit
Bug 32418: (follow-up) Remove jQuery, Fix typos in url, add biblio as template
param
To
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
David Nind changed:
What|Removed |Added
Attachment #146944|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #31 from Paul Derscheid ---
Hi Katrin, this is ready for retesting.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #30 from Katrin Fischer ---
Is this ready for retesting?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Attachment #145505|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #28 from Fridolin Somers ---
(In reply to Fridolin Somers from comment #15)
> Great code Paul ;)
>
> If I may :
>
> I didnt saw there is a method output_and_exit_if_error() that manages
> incorrect patron + biblio.
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #27 from Fridolin Somers ---
(In reply to Marcel de Rooy from comment #24)
> FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>FAIL filters
> wrong_html_filter at line 71 (
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #26 from Fridolin Somers ---
(In reply to Paul Derscheid from comment #18)
> The second patch relies on changes in the first.
> Works correctly if you apply both.
In this cas you need to add "(follow-up)" in second
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #25
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #24 from Marcel de Rooy ---
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
FAIL filters
wrong_html_filter at line 71 (Add a new item or go to the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Marcel de Rooy changed:
What|Removed |Added
Attachment #145306|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #22 from Marcel de Rooy ---
Two patches with the same commit name. Will squash them.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #21 from David Nind ---
Created attachment 145307
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145307=edit
Bug 32418 - Can't call method 'unblessed' on an undefined value at
cataloguing/additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
David Nind changed:
What|Removed |Added
Attachment #144794|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #19 from David Nind ---
(In reply to Paul Derscheid from comment #18)
> The second patch relies on changes in the first.
> Works correctly if you apply both.
Thanks Paul. I have done that now and will sign off.
I was a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #18 from Paul Derscheid ---
The second patch relies on changes in the first.
Works correctly if you apply both.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #16 from Paul Derscheid ---
Created attachment 144812
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144812=edit
Bug 32418 - Can't call method 'unblessed' on an undefined value at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #15 from Fridolin Somers ---
Great code Paul ;)
If I may :
I didnt saw there is a method output_and_exit_if_error() that manages incorrect
patron + biblio.
Maybe it would be nice to move you check on item in it ?
Is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Attachment #144643|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Attachment #144640|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #11 from Marcel de Rooy ---
+if (!$current_item) { $nextop = "additem"; return; }
Return ?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Attachment #144641|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #10 from Marcel de Rooy ---
(In reply to Paul Derscheid from comment #9)
> Created attachment 144641 [details] [review]
> Bug 32420: Set focus for cursor to barcode input box in batch item
> modification
>
> This should
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #9 from Paul Derscheid ---
Created attachment 144641
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144641=edit
Bug 32420: Set focus for cursor to barcode input box in batch item modification
This
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #8 from Paul Derscheid ---
This time I actually tested it. Should work now. But still open for ideas.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |paul.dersch...@lmscloud.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Attachment #144639|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #7 from Paul Derscheid ---
Created attachment 144640
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144640=edit
Bug 32418: Can't call method 'unblessed' on an undefined value at
cataloguing/additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Attachment #144571|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #5 from Paul Derscheid ---
Yeah, sorry. Fixin' it now.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #3 from Marcel de Rooy ---
+$current_item = Koha::Items->find($itemnumber)->unblessed or undef;
This does not work. The find will not return an opbject. So the unblessed still
crashes.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #2 from Marcel de Rooy ---
Just nagging:
Assignee not filled.
QA tools warn: * Commit title does not start with 'Bug X: ' - 672a0dd335
--
You are receiving this mail because:
You are the assignee for the bug.
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
Paul Derscheid changed:
What|Removed |Added
Status|NEW |Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418
--- Comment #1 from Paul Derscheid ---
Created attachment 144571
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144571=edit
Add fallback redirect to additem op if \$current_item is undefined
--
You are receiving
59 matches
Mail list logo