https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Katrin Fischer changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||34016
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #41 from Tomás Cohen Arazi ---
Follow-up pushed to master. Thanks, Jonathan.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Jonathan Druart changed:
What|Removed |Added
Attachment #156102|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #39 from Jonathan Druart ---
Created attachment 156102
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156102=edit
Bug 32496: Fix t/db_dependent/SIP/ILS.t
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #38 from Tomás Cohen Arazi ---
Created attachment 156099
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156099=edit
Bug 32496: (follow-up) Fix t/db_dependent/SIP/Message.t
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #37 from Tomás Cohen Arazi ---
Pushed to master for 23.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Marcel de Rooy changed:
What|Removed |Added
Attachment #156061|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Marcel de Rooy changed:
What|Removed |Added
Attachment #156060|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Marcel de Rooy changed:
What|Removed |Added
Attachment #156059|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Passed QA
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #33
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #31 from Jonathan Druart ---
Created attachment 156061
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156061=edit
Bug 32496: (QA follow-up) Fix POD and DateTime use
FAIL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #30 from Jonathan Druart ---
Created attachment 156060
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156060=edit
Bug 32496: Some fixes
This can be squashed
Signed-off-by: Jonathan Druart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Jonathan Druart changed:
What|Removed |Added
Attachment #153517|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #28 from Katrin Fischer ---
I am not sure what/how to test... but I just started anyway :)
1) QA test tools
FAIL t/db_dependent/Koha/Object.t
FAIL forbidden patterns
forbidden pattern: Use of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #27 from Katrin Fischer ---
Created attachment 153519
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153519=edit
Bug 32496: (QA follow-up) Fix POD and DateTime use
FAIL t/db_dependent/Koha/Object.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Katrin Fischer changed:
What|Removed |Added
Attachment #153018|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Katrin Fischer changed:
What|Removed |Added
Attachment #153017|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Andreas Roussos changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #24 from Jonathan Druart ---
Created attachment 153018
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153018=edit
Bug 32496: Some fixes
This can be squashed
Signed-off-by: Jonathan Druart
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Jonathan Druart changed:
What|Removed |Added
Attachment #150614|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Emily Lamancusa changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Jonathan Druart changed:
What|Removed |Added
CC||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Jonathan Druart changed:
What|Removed |Added
Blocks||33746
Depends
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Mason James changed:
What|Removed |Added
CC||m...@kohaaloha.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Jonathan Druart changed:
What|Removed |Added
Depends on||33746
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Bug 32496 depends on bug 31735, which changed state.
Bug 31735 Summary: Avoid re-fetching objects from database by passing them down
instead of object ids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #20 from David Gustafsson ---
Tests seems to pass, so again ready for signoff.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Status|Needs Signoff |In Discussion
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Attachment #147162|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Attachment #147158|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Attachment #145027|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #14 from David Gustafsson ---
Ok, there are other lines exceeding that line number in that file, but should
in that case I would have formatted it as
C4::Circulation::ReturnLostItem(
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #13 from Jonathan Druart ---
(In reply to David Gustafsson from comment #12)
> Fixing the formatting of
> C4::Circulation::ReturnLostItem( $self->borrowernumber,
> $debit->itemnumber );
> feels like
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #12 from David Gustafsson ---
Ok, thanks for spotting that. The changes pertaining to CheckReserves have not
been moved to bug 31735. In Koha/Hold.pm now using the fully qualified sub name
for CheckResvere, there is a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Attachment #145024|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #10 from Jonathan Druart ---
And, sorry again. I actually mixed the 2 reviews, I had the patches from the 2
bugs applied, reviewed 31735 and compared with the code with both applied.
The missing unblessed calls comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #9 from Jonathan Druart ---
Sorry those 2 last comments were for the first patch of bug 31735.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #8 from Jonathan Druart ---
As well as:
* unrelated change: item_issued_to_other_patron
*
-my $issue = AddIssue( $patron_borrower->unblessed, $item_1->barcode);
+my $issue = AddIssue( $patron->unblessed,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #7 from Jonathan Druart ---
I like the idea, but the patch contains unrelated changes that may slow down
its integration.
For instance:
-C4::Circulation::ReturnLostItem( $self->borrowernumber,
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Attachment #144804|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #5 from David Gustafsson ---
Found tests that still needs fixing, working on this and then should be ready
for review.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Attachment #144789|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Attachment #144722|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Attachment #144723|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #2 from David Gustafsson ---
Created attachment 144723
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144723=edit
Bug 32496: Optimize OPAC checkouts view
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
--- Comment #1 from David Gustafsson ---
Created attachment 144722
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144722=edit
Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm
Refactor the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
Owen Leonard changed:
What|Removed |Added
Depends on|21996 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496
David Gustafsson changed:
What|Removed |Added
Depends on||21996, 31735
62 matches
Mail list logo
