https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||36613
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||36565
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Zeno Tajoli changed:
What|Removed |Added
Text to go in the||A new endpoint of REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Zeno Tajoli changed:
What|Removed |Added
Documentation|A new endpoint |
submission|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Zeno Tajoli changed:
What|Removed |Added
Documentation||A new endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Martin Renvoize changed:
What|Removed |Added
Blocks||29392
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #51 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #50 from Katrin Fischer ---
Fixed some small conflicts in Biblio.t caused by the adding of other unit tests
meanwhile.
Easy to verify for unit tests that you got things right at least :)
I notice this adds a lot of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #49 from Jonathan Druart ---
Created attachment 160472
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160472=edit
Bug 33036: Improve REST API controller
Signed-off-by: Jonathan Druart
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #48 from Jonathan Druart ---
Created attachment 160471
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160471=edit
Bug 33036: Use Koha::Objects
Better to use Koha::Objects everywhere and have the same
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #47 from Jonathan Druart ---
Created attachment 160470
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160470=edit
Bug 33036: Add more tests
Signed-off-by: Jonathan Druart
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #46 from Jonathan Druart ---
Created attachment 160469
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160469=edit
Bug 33036: Improve merge_with tests
Signed-off-by: Jonathan Druart
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jonathan Druart changed:
What|Removed |Added
Attachment #159191|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #44 from Zeno Tajoli ---
I check the patches of Jonathan and for me are OK.
I add a new little patch because there is a new test inside
t/db_dependent/API/v1/biblios.t (bug 35574).
Now there is only JSON for inputting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #43 from Zeno Tajoli ---
Created attachment 160302
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160302=edit
Update of test number
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #42 from Mark Hofstetter ---
looks ok to me
for testing/using please don't forget to activate RESTBasicAuth
/cgi-bin/koha/admin/preferences.pl?op=search=RESTBasicAuth
cheers and thx to all
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #41 from Jonathan Druart ---
1. Added some improvements and missing unit tests
2. Wondering if we should not support more than json for the marc record. Not
considering blocker however (can be done later if needed).
3.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #40 from Jonathan Druart ---
Created attachment 159829
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159829=edit
Bug 33036: Improve REST API controller
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #39 from Jonathan Druart ---
Created attachment 159828
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159828=edit
Bug 33036: Use Koha::Objects
Better to use Koha::Objects everywhere and have the same
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #38 from Jonathan Druart ---
Created attachment 159827
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159827=edit
Bug 33036: Add more tests
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #37 from Jonathan Druart ---
Created attachment 159826
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159826=edit
Bug 33036: Improve merge_with tests
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Zeno Tajoli changed:
What|Removed |Added
Attachment #159011|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Zeno Tajoli changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #35
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jan Kissig changed:
What|Removed |Added
Attachment #159120|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Thomas Klausner changed:
What|Removed |Added
Attachment #159103|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Thomas Klausner changed:
What|Removed |Added
CC||d...@plix.at
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #32 from Thomas Klausner ---
Created attachment 159103
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159103=edit
Bug 33036: REST API: Merge biblio records implements merging of records +
attached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Zeno Tajoli changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #30 from Zeno Tajoli ---
Created attachment 159012
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159012=edit
Patch that implemnts the end point
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Zeno Tajoli changed:
What|Removed |Added
Attachment #157481|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #28 from Zeno Tajoli ---
Hi Thomas,
could you write here a full example with curl on how do you want the call of
the API ?
I need parmas of curl and headers, json file fields and how to pass the
MARC21/UNIMARC data (a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #27 from Katrin Fischer ---
See here too: https://wiki.koha-community.org/wiki/Perltidy
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #26 from Jonathan Druart ---
(In reply to Zeno Tajoli from comment #25)
> Hi Jonathan Druart,
>
> are you sure that there are problems with tidying for this patch?
> I use perltidy conf that are in the git archive and I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #25 from Zeno Tajoli ---
Hi Jonathan Druart,
are you sure that there are problems with tidying for this patch?
I use perltidy conf that are in the git archive and I do a check with
koha-qa.pl -v 2 -c 1 and I pass the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #24 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #23)
>
> 6. Not sure about the response of the endpoint, IMO it should return the
> biblio generated by the merge.
> Also the response contains
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #22 from Jan Kissig ---
Tested merge with
- attached holds
- attached items
- attached subscription
- attached order
- POSTing XML
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #21 from Jan Kissig ---
Created attachment 157731
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157731=edit
Bug 33036: REST API: Merge biblio records implements merging of records +
attached items,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jan Kissig changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Zeno Tajoli changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Zeno Tajoli changed:
What|Removed |Added
Attachment #152678|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #18 from Zeno Tajoli ---
Created attachment 157481
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157481=edit
A MARC21 record in MARCXML format
You can use MARCXML file for tests
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #17 from Jonathan Druart ---
(In reply to Zeno Tajoli from comment #16)
> Hi Jonathan, I'm trying to develop this patch so I ask same explanation
> about your requests:
> 1)'first move the code to a module'.
> In this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Zeno Tajoli changed:
What|Removed |Added
CC||ztaj...@gmail.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #15 from Jonathan Druart ---
Also don't forget to run the QA script:
FAIL Koha/REST/V1/Biblios.pm
FAIL forbidden patterns
forbidden pattern: Use of $c->validation in API controllers
should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Katrin Fischer changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jan Kissig changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jan Kissig changed:
What|Removed |Added
Attachment #152659|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Attachment #152472|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jan Kissig changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jan Kissig changed:
What|Removed |Added
Attachment #152447|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Attachment #152438|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Attachment #152439|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Attachment #152437|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #5 from Mark Hofstetter ---
Created attachment 152438
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152438=edit
Bug 33036: REST API: Merge biblio records
implements merging of records + attached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Attachment #152436|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Patch complexity|--- |Medium patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #3 from Mark Hofstetter ---
Created attachment 152436
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152436=edit
Bug 33036: REST API: Merge biblio records implements merging of records +
attached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #2 from Jan Kissig ---
By "additionally we need a list (json, csv ..) of the records that should be
taken from the biblio_id_to_merge record" did you mean a list of fields from
the biblio_id_to_merge record?
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Change sponsored?|Seeking developer |Sponsored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #1 from Mark Hofstetter ---
I'd suggest the following url
PUT: /biblios/{biblio_id}/merge/{biblio_id_to_merge}
where biblio_id is the biblio_id of the record to be kept
additionally we need a list (json, csv ..) of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Mark Hofstetter changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |k...@trust-box.at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
Jan Kissig changed:
What|Removed |Added
Change sponsored?|--- |Seeking developer
--
You are
74 matches
Mail list logo
