[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #33 from Lucas Gass --- Created attachment 160676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160676&action=edit Bug 34668: (QA follow-up) Change file permission Signed-off-by: Lucas Gass -- You

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What|Removed |Added Attachment #158530|0 |1 is obsolete|

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What|Removed |Added Attachment #158529|0 |1 is obsolete|

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What|Removed |Added Attachment #158528|0 |1 is obsolete|

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receivin

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #29 from Lucas Gass --- Working as described. QA script is mostly happy, 1 issue with file permissions that I am fixing in a follow-up. The rest of the code looks good. DBUpdate looks good. -- You are receiving this mai

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are r

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 ByWater Sandboxes changed: What|Removed |Added Attachment #158359|0 |1 is obsolete|

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 ByWater Sandboxes changed: What|Removed |Added Attachment #157316|0 |1 is obsolete|

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 ByWater Sandboxes changed: What|Removed |Added Attachment #157315|0 |1 is obsolete|

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are re

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #25 from Shi Yao Wang --- Created attachment 158359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158359&action=edit Bug 34668: pass whole waiting_holds rs -- You are receiving this mail because: You

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #24 from Kyle M Hall --- Comment on attachment 157315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157315 Bug 34668: Add popup warn librarians of waiting holds when checking out Review of attachment

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.co

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Mia Kujala changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #22 fro

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #157312|0 |1 is obsolet

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #155188|0 |1 is obsolet

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #19 from Shi Yao Wang --- No new code changes, just changed the commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang changed: What|Removed |Added Attachment #157243|0 |1 is obsolete|

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #17 from Shi Yao Wang --- (In reply to Mia Kujala from comment #16) > Tested again. Now the popup is not showing but it proceed the checkout The popup shows up on my end... is the syspref active? Also, the popup won't sh

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #16 from Mia Kujala --- Tested again. Now the popup is not showing but it proceed the checkout -- You are receiving this mail because: You are watching all bug changes. ___ Ko

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #15 from Shi Yao Wang --- (In reply to Mia Kujala from comment #13) > I tried to signoff: Popup is showing but clicking Ok doesn't proceed the > checkout, only popup disappears. Thank you for testing. It was indeed not p

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang changed: What|Removed |Added Attachment #156992|0 |1 is obsolete|

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Mia Kujala changed: What|Removed |Added CC||mia.kuj...@xamk.fi --- Comment

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are re

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #12 from Shi Yao Wang --- Created attachment 156992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156992&action=edit Bug 34668: remove binding/unbinding event for one submit event -- You are receivin

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #11 from Nick Clemens --- (In reply to Shi Yao Wang from comment #10) > (In reply to Nick Clemens from comment #9) > I currently do not see how this can be done without binding/unbinding events > of the "Check out" button

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #10 from Shi Yao Wang --- (In reply to Nick Clemens from comment #9) > Rather than unbinding/rebinding events, could we have an action bound to > submit on the form, and then display the modal or not as needed? That would

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA CC

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Matt Blenkinsop changed: What|Removed |Added Attachment #155143|0 |1 is obsolete|

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Matt Blenkinsop changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are re

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang changed: What|Removed |Added Attachment #155045|0 |1 is obsolete|

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #4 from Blou --- I think what would happen is that the clerks would hit it automatically (and blindly) after a while, especially those that were targeted by this library request. Considering each popup would be for a dif

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Owen Leonard changed: What|Removed |Added Version|unspecified |master --- Comment #3 from O

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang changed: What|Removed |Added Status|NEW |Needs Signoff -- You are re

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang changed: What|Removed |Added Attachment #155044|0 |1 is obsolete|

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 --- Comment #1 from Shi Yao Wang --- Created attachment 155044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155044&action=edit Bug 34668: Add popup warn librarians of waiting holds when checking out When there a

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |shi-yao.w...@inlibro.com

[Koha-bugs] [Bug 34668] Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Shi Yao Wang changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr