https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #49 from Frédéric Demians ---
Backported to 22.11.x for 22.11.16
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
David Cook changed:
What|Removed |Added
CC||f.demi...@tamil.fr
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #47 from David Cook ---
(In reply to Lucas Gass from comment #45)
> https://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=t/Token.t;
> h=355282c6ed83f89f18ed0b7609667772f579b991;
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #46 from David Cook ---
Yeah it'll be something like that.
Sorry for not being more useful
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #45 from Lucas Gass ---
(In reply to David Cook from comment #44)
> (In reply to David Cook from comment #43)
> > Ah right. I think we removed some tests in master. I'll take a look...
>
> Ran out of time to look at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #44 from David Cook ---
(In reply to David Cook from comment #43)
> Ah right. I think we removed some tests in master. I'll take a look...
Ran out of time to look at this today, but the answer is in master (via bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #43 from David Cook ---
(In reply to Lucas Gass from comment #42)
> This is causing some tests to fail in 23.05.x:
>
> https://jenkins.koha-community.org/view/23.05/job/Koha_23.05_D10/
> lastCompletedBuild/testReport/
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #42 from Lucas Gass ---
This is causing some tests to fail in 23.05.x:
https://jenkins.koha-community.org/view/23.05/job/Koha_23.05_D10/lastCompletedBuild/testReport/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Lucas Gass changed:
What|Removed |Added
Status|Pushed to stable|Pushed to oldstable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #40 from David Cook ---
Note that we'll need this for 23.05 and 22.11 as well since they implement bug
33675
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Fridolin Somers changed:
What|Removed |Added
Version(s)||23.11.04
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #38 from Katrin Fischer ---
(In reply to Tomás Cohen Arazi from comment #37)
> (In reply to Katrin Fischer from comment #36)
> > Hi Tomas, thanks for testing! Am I correct, that the patches on bug 36098
> > and here are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #37 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #36)
> Hi Tomas, thanks for testing! Am I correct, that the patches on bug 36098
> and here are supposed to go in 23.11 directly now?
Bug 36098 is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #36 from Katrin Fischer ---
Hi Tomas, thanks for testing! Am I correct, that the patches on bug 36098 and
here are supposed to go in 23.11 directly now?
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #162748|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #33 from Tomás Cohen Arazi ---
Applied fine on top of 36098.
QA script happy.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Olivier Hubert changed:
What|Removed |Added
Attachment #162710|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #31 from David Cook ---
(In reply to Olivier Hubert from comment #30)
> This looks like it's fixed, in 23.11.x. With the patches from this bug and
> 36098, I was not able to reproduce the issue. SSO works as it should.
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Olivier Hubert changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Jonathan Druart changed:
What|Removed |Added
Version|master |23.11
--- Comment #29
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Olivier Hubert changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #27 from Jonathan Druart ---
Olivier, please test this (with bug 36098) as soon as you can.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #26 from David Cook ---
I've just tested this on 23.11.03.
Bug 36098 patches plus this patch should fix the problem.
I'll comment on bug 36098 asking for folk to backport the Koha::Session change.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
David Cook changed:
What|Removed |Added
Attachment #161783|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
David Cook changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
David Cook changed:
What|Removed |Added
Assignee|maryse.sim...@inlibro.com |dc...@prosentient.com.au
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #24 from David Cook ---
(In reply to Olivier Hubert from comment #21)
> Following a discussion on IRC with Jonathan, I waited until the commits for
> 34478 were pushed to master. I then updated everything on my KTD and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #23 from David Cook ---
(In reply to Olivier Hubert from comment #21)
> Following a discussion on IRC with Jonathan, I waited until the commits for
> 34478 were pushed to master. I then updated everything on my KTD and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #22 from David Cook ---
(In reply to Olivier Hubert from comment #21)
> Following a discussion on IRC with Jonathan, I waited until the commits for
> 34478 were pushed to master. I then updated everything on my KTD and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #21 from Olivier Hubert ---
Following a discussion on IRC with Jonathan, I waited until the commits for
34478 were pushed to master. I then updated everything on my KTD and made sure
the commits were there before I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #20 from David Cook ---
(In reply to Jonathan Druart from comment #13)
> David, isn't the same problem we encountered on 34478? Should not we
> backport "Make Koha::Token use session id not userenv id"?
Yep, 100%. We
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
David Cook changed:
What|Removed |Added
Depends on||36098
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #19 from David Cook ---
(In reply to David Cook from comment #18)
> Ok this is interesting. Why would another user be logged in?
Ah I know what the problem is now.
So I'm going to keep this as Failed QA because the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #18 from David Cook ---
Comment on attachment 161783
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161783
Bug 34755: Unit tests
Review of attachment 161783:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #17 from David Cook ---
(In reply to David Cook from comment #16)
> I was trying my best to break my sessions, and I did manage to reproduce the
> problem, but I can't recall exactly how.
>
> So I'm going to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #16 from David Cook ---
I was trying my best to break my sessions, and I did manage to reproduce the
problem, but I can't recall exactly how.
So I'm going to keep trying again (more carefully).
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
David Cook changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #15
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #14 from David Cook ---
(In reply to Jonathan Druart from comment #13)
> David, isn't the same problem we encountered on 34478? Should not we
> backport "Make Koha::Token use session id not userenv id"?
That's what I'm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #13 from Jonathan Druart ---
David, isn't the same problem we encountered on 34478? Should not we backport
"Make Koha::Token use session id not userenv id"?
Olivier, bug 34478 is going to be pushed very soon. It will be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #12 from Michaela Sieber ---
Hi David,
we tested once again in Master with koha testing docker and we still have this
error in Firefox and Chrome.
We can reproduce it by following the test plan. It is important, that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Blou changed:
What|Removed |Added
CC||philippe.blo...@inlibro.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #11 from David Cook ---
(In reply to Maryse Simard from comment #10)
> I still reproduce this in current master when using the exact steps given
> here. I admit it is a bit tricky to test because it seems the error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #10 from Maryse Simard ---
I still reproduce this in current master when using the exact steps given here.
I admit it is a bit tricky to test because it seems the error doesn't occur
every time but, while I can sometimes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #9 from David Cook ---
I can't reproduce this problem in master. Can you double-check your steps for
reproducing the problem?
It's working perfectly for me.
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #8 from David Cook ---
I'm really interested in this one, and probably will be taking a look at it
more over the next week or so.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Michaela Sieber changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #6 from Katrin Fischer ---
Excited to see patches on this one!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Maryse Simard changed:
What|Removed |Added
CC||maryse.sim...@inlibro.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #5 from Maryse Simard ---
Created attachment 161784
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161784=edit
Bug 34755: Resets the userenv when calling OAuth api endpoints
When using OIDC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #4 from Maryse Simard ---
Created attachment 161783
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161783=edit
Bug 34755: Unit tests
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Maryse Simard changed:
What|Removed |Added
Status|REOPENED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Katrin Fischer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
--- Comment #3 from Lukas Koszyk ---
I confirm that we have the same problem (in version 23.05.04).
I also checked the userenv variable when generating and checking the CSRF
token, in the logs I see the userenv of another user (not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Michaela Sieber changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Olivier Hubert changed:
What|Removed |Added
Status|RESOLVED|REOPENED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Michaela Sieber changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Katrin Fischer changed:
What|Removed |Added
Depends on||33675
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755
Michaela Sieber changed:
What|Removed |Added
CC||clemens.tub...@kit.edu,
64 matches
Mail list logo
