[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim changed: What|Removed |Added Severity|enhancement |normal --- Comment #22 from

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Laura Escamilla changed: What|Removed |Added Attachment #162609|0 |1 is obsolete|

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Laura Escamilla changed: What|Removed |Added Attachment #162608|0 |1 is obsolete|

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Laura Escamilla changed: What|Removed |Added Attachment #162605|0 |1 is obsolete|

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Laura Escamilla changed: What|Removed |Added Attachment #162604|0 |1 is obsolete|

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Laura Escamilla changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #16 from Pedro Amorim --- Created attachment 162609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162609=edit Bug 34920: Add cypress tests Run the agreements cypress test spec: cypress run --spec

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #15 from Pedro Amorim --- I'm unable to attach the following patch: https://github.com/PTFS-Europe/koha/commit/9d1047e1eb3e604868602a60ffd2cd04e0801a84 Error: 413 Request Entity Too Large -- You are receiving this

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #14 from Pedro Amorim --- Created attachment 162608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162608=edit Bug 34920: Ensure 'description' property is an empty string if 'lib' is null Test plan:

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #13 from Pedro Amorim --- Created attachment 162605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162605=edit Bug 34920: Add API endpoint tests prove koha/t/db_dependent/api/v1/authorised_values.t

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #12 from Pedro Amorim --- Created attachment 162604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162604=edit Bug 34920: Return sorted av_cats to be able to test -- You are receiving this mail

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim changed: What|Removed |Added Attachment #162601|0 |1 is obsolete|

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim changed: What|Removed |Added Attachment #162600|0 |1 is obsolete|

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim changed: What|Removed |Added Attachment #162121|0 |1 is obsolete|

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim changed: What|Removed |Added Attachment #162120|0 |1 is obsolete|

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Jonathan Druart changed: What|Removed |Added QA Contact||jonathan.dru...@gmail.com

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Jonathan Druart changed: What|Removed |Added Blocks||36203 Referenced Bugs:

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #11 from Jonathan Druart --- After further discussions it seems that we do not fallback to the code in other part of Koha. We just display an empty string if the description is not present. This seems wrong and not

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #10 from Pedro Amorim --- Created attachment 162601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162601=edit Bug 34920: (QA follow-up): Add API endpoint tests prove

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #9 from Pedro Amorim --- Created attachment 162600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162600=edit Bug 34920: (QA follow-up): Return sorted av_cats to be able to test -- You are receiving

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize changed: What|Removed |Added Blocks||17390 Referenced Bugs:

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #7 from Martin Renvoize --- I agree with this approach and am as such signing off.. all works nicely in testing. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize changed: What|Removed |Added Attachment #162037|0 |1 is obsolete|

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize changed: What|Removed |Added Attachment #162036|0 |1 is obsolete|

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim changed: What|Removed |Added CC||vic...@tuxayo.net -- You

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #4 from Pedro Amorim --- Created attachment 162037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162037=edit Bug 34920: Default to using av.value is av.description is falsy Test plan: 1. Enable ERM

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #3 from Pedro Amorim --- Created attachment 162036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162036=edit Bug 34920: Make av description nullable in API spec -- You are receiving this mail

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #2 from Pedro Amorim --- I don't think this is specific to ERM. This will affect any module using the authorised_values REST endpoint (Preservation module now also uses this same REST endpoint). This is to_api_mapping

[Koha-bugs] [Bug 34920] ERM breaks if an ERM authorized value is missing a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #1 from Matt Blenkinsop --- Description is a required property on the API so either we need to set it as unrequired and allow it to be NULL, or we need to put a mechanism in place to prevent a description being deleted