[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Fridolin Somers changed: What|Removed |Added Status|Pushed to main |Needs documenting ---

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Katrin Fischer changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #39 from

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #38 from Martin Renvoize --- (In reply to Katrin Fischer from comment #37) > (In reply to Katrin Fischer from comment #34) > > Please update the wiki page! > > https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks > >

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #37 from Katrin Fischer --- (In reply to Katrin Fischer from comment #34) > Please update the wiki page! > https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks *ping* -- You are receiving this mail because: You are

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Blocks||31791 Referenced

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr ---

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Fridolin Somers changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #35 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed --

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 163713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163713=edit Bug 34943: (QA follow-up) Use `before_biblio_action` and an `action` param This

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 163712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163712=edit Bug 34943: Implement `before_biblio_metadata_store` plugin hook This patch

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Attachment #163325|0 |1 is obsolete|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Patch doesn't apply ---

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Blocks||29392 Referenced Bugs:

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA QA

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Attachment #163048|0 |1 is obsolete|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Attachment #161696|0 |1 is obsolete|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Attachment #161695|0 |1 is obsolete|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #26 from Martin Renvoize --- Good catch, thanks for highlighting that Tomas. Oh the fun of trying to stay consistent when we're already rather inconsistent aye. -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #25 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #24) > Look good to me.. I'm still comparing to the _after_biblio_action_hooks sub > though and the signature looks a little different with a top

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #24 from Martin Renvoize --- Look good to me.. I'm still comparing to the _after_biblio_action_hooks sub though and the signature looks a little different with a top level hash vs a hash under a 'payload' key.. thoughts

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 163048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163048=edit Bug 34943: (QA follow-up) Use `before_biblio_action` and an `action` param This

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #21 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #19) > Actually.. reading a little deeper I have questions. > > Should we not be consistent with 'after_biblio_action' and call the hook >

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |In Discussion -- You

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #20 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #19) > Actually.. reading a little deeper I have questions. > > Should we not be consistent with 'after_biblio_action' and call the hook >

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Attachment #159691|0 |1 is obsolete|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added Attachment #159690|0 |1 is obsolete|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #15 from Martin Renvoize --- This feels like the perfect place for a plugin hook to accomplish bug 20065 :) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 David Nind changed: What|Removed |Added Attachment #159687|0 |1 is obsolete|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 David Nind changed: What|Removed |Added Attachment #159686|0 |1 is obsolete|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #12 from Tomás Cohen Arazi --- I decided to rename for hook for better scoping it (authorities could have a hook too) taking the idea from bug 29392, which feels valuable as well. -- You are receiving this mail

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 159687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159687=edit Bug 34943: Implement `before_biblio_metadata_store` plugin hook This patch

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Attachment #159684|0 |1 is obsolete|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #9 from Tomás Cohen Arazi --- David, we overlapped. I'm renaming the hook for clarity. Let me re-submit and you test again! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 David Nind changed: What|Removed |Added Attachment #159683|0 |1 is obsolete|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 David Nind changed: What|Removed |Added Attachment #159682|0 |1 is obsolete|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 159683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159683=edit Bug 34943: Implement before_record_store() plugin hook This patch implements a hook

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Attachment #159680|0 |1 is obsolete|

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 159681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159681=edit Bug 34943: Implement before_record_store() plugin hook This patch implements a hook

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 159680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159680=edit Bug 34943: Unit tests -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Patch

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #1 from Tomás Cohen Arazi --- I forgot to mention, right now we have the 'after_biblio_action' hook, but using is for the aforementioned purpose would generate a loop. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What|Removed |Added CC|