[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Baptiste changed: What|Removed |Added Attachment #159813|0 |1 is obsolete|

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Baptiste changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #36 from David Cook --- (In reply to Jonathan Druart from comment #35) > IMO this is too low level, we should not call MARC::Record::new_from_xml > everytime we store. > > It will work ofc but what about perf? I think

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #35 from Jonathan Druart --- IMO this is too low level, we should not call MARC::Record::new_from_xml everytime we store. It will work ofc but what about perf? What if I do want invalid marcxml? :D -- You are

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Attachment #159810|0 |1 is obsolete|

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Attachment #159811|0 |1 is obsolete|

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #33 from Martin Renvoize --- Created attachment 159812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159812=edit Bug 35104: Throw exception on store of invalid marcxml This patch adds an exception

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Blocks||34551 Referenced Bugs:

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Attachment #159630|0 |1 is obsolete|

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Attachment #159621|0 |1 is obsolete|

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Attachment #157642|0 |1 is obsolete|

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #32 from Martin Renvoize --- Created attachment 159811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159811=edit Bug 35104: Catch the failure on new and edited records We now catch the error and

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Attachment #159620|0 |1 is obsolete|

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #30 from David Cook --- (In reply to Martin Renvoize from comment #29) > Awesome.. I knew it was something silly when catching the exception! > > That gives me enough to get going again :), thanks David Yay teamwork!

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #29 from Martin Renvoize --- Awesome.. I knew it was something silly when catching the exception! That gives me enough to get going again :), thanks David -- You are receiving this mail because: You are the assignee

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #28 from David Cook --- I have to run and I'm away tomorrow morning, but hopefully this gets you a bit further. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #27 from David Cook --- Created attachment 159630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159630=edit Bug 35104: Fix typo when catching exception -- You are receiving this mail because: You

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #26 from David Cook --- I've applied the last 2 patches and restarted Koha... Bug 35104: [Alternative] Throw exception on store of invalid marcxml Bug 35104: Initial attempt at catching the failure on new records And

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #25 from David Cook --- Thanks for working on this, Martin. I'll try to take a look in a bit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #24 from Martin Renvoize --- Created attachment 159621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159621=edit Bug 35104: Initial attempt at catching the failure on new records Whilst I can see the

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Attachment #159615|0 |1 is obsolete|

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Status|Failed QA |In Discussion ---

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #21 from Martin Renvoize --- Created attachment 159615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159615=edit Bug 35104: [Alternative] Throw exception on store of invalid marcxml This patch adds

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #20 from David Cook --- We've got an interesting assortment of fixes at the moment... If you already have a record with invalid characters, you can open it using bug 34014 which will scrub your record clean within the

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #19 from David Cook --- (In reply to David Cook from comment #18) > That being said... the XML 1.0 spec is pretty forgiving. After review, it's > really just excluding *some* ASCII control characters, Unicode surrogates,

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #18 from David Cook --- (In reply to David Cook from comment #17) > I'm going to poke around in this a bit more... The TransformHtmlToMarc doesn't seem to affect it... If I do $record->as_formatted then I see:

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #17 from David Cook --- (In reply to David Cook from comment #16) > So the STX character from that example would be converted to something like > instead of just erased. I just tried a client-side replace where the STX

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #16 from David Cook --- (In reply to Martin Renvoize from comment #15) > Wow, that's an impressive find. Man this stuff ends up in fun "exciting" > places. Thanks! I did feel pretty good working that one out! During

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #15 from Martin Renvoize --- Wow, that's an impressive find. Man this stuff ends up in fun "exciting" places. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #14 from David Cook --- I had an interesting experience that I thought I'd share here since it's relevant. One of my librarians was copying and pasting text from a PDF into Koha. When they did it, it generated a broken

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #13 from David Cook --- (In reply to Martin Renvoize from comment #10) > This works really nicely, as such I'm signing off... > > Two little points however.. > > 1) I wonder if we could/should merge these errors into

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 David Cook changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #12

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #11 from Martin Renvoize --- (In reply to David Cook from comment #3) > As per my comment at > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549#c19 > technically the problem we're trying to solve in bug

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What|Removed |Added Attachment #157628|0 |1 is obsolete|

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 David Cook changed: What|Removed |Added Attachment #157627|0 |1 is obsolete|

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #7 from David Cook --- git-bz still not working for me, so just used "git format-patch -1 HEAD" and uploaded manually... -- You are receiving this mail because: You are the assignee for the bug. You are watching all

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 David Cook changed: What|Removed |Added Attachment #157627|application/mbox|text/plain mime

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #6 from David Cook --- Created attachment 157627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157627=edit Bug 34549: Alert when inserting text invalid in XML into bib record -- You are receiving

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 David Cook changed: What|Removed |Added Status|NEW |In Discussion -- You are

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #5 from David Cook --- I've written a Javascript based check which *mostly* gets us there. It checks the input[text] and textarea fields for bytes that aren't allowed in XML and it raises an alert if it finds any. I

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #4 from David Cook --- Created attachment 157625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157625=edit Text file containing control characters -- You are receiving this mail because: You are the

[Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 David Cook changed: What|Removed |Added Summary|We should warn when |We should warn when